Re: [PATCH 1/1] eglibc: always compile with optimization.

[jhuang0 <jackie.huang@windriver.com>]

On 11/12/2012 5:48 PM, Phil Blundell wrote:
> On Mon, 2012-11-12 at 11:31 +0800, jackie.huang@windriver.com wrote:
>> +# eglibc can't be built without optimization, if someone tries to compile an
>> +# entire image as -O0, we override it with -O2 here and give a note about it.
>> +def get_optimization(d):
>> +    if base_contains("SELECTED_OPTIMIZATION", "-O0", "x", "", d) == "x":
>> +        bb.note("eglibc can't be built with -O0, -O2 will be used instead.")
>> +        selected_optimization = d.getVar("SELECTED_OPTIMIZATION", True)
>> +        return selected_optimization.replace("-O0", "-O2")
>> +    return selected_optimization
>
> Did you test this patch at all?

I did test only in the cases that caused the defect but now I realized 
that it's not well tested and it doesn't work in other cases, sorry 
about that, I will re-work on it.

Thanks,
Jackie

>
> p.
>
>
>
>

-- 
Jackie Huang
WIND RIVER | China Development Center
MSN:jackielily@hotmail.com
Tel: +86 8477 8594
Mobile: +86 138 1027 4745