Re: [PATCH] bash: Add fix for cross compile issues

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2012-11-14 at 13:24 +0000, Richard Purdie wrote:
> On Wed, 2012-11-14 at 13:30 +0100, Martin Jansa wrote:
> > On Tue, Nov 13, 2012 at 01:59:19PM +0000, Richard Purdie wrote:
> > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > > ---
> > > diff --git a/meta/recipes-extended/bash/bash-4.2/crossfix.patch b/meta/recipes-extended/bash/bash-4.2/crossfix.patch
> > > new file mode 100644
> > > index 0000000..f587c34
> > > --- a/dev/null
> > > +++ b/meta/recipes-extended/bash/bash-4.2/crossfix.patch
> > > @@ -0,0 +1,28 @@
> > 
> > Are you using some special tool to generate git patches or some weird
> > git version?
> 
> Basically, the data from cgit in the web interface is broken and that is
> causing this.
> 
> > Patches from you where you add some file usually does not apply here,
> > It's caused by:
> > --- a/dev/null
> > +++ b/meta/recipes-extended/bash/bash-4.2/crossfix.patch
> > which usually looks like
> > --- /dev/null
> > +++ b/meta/recipes-extended/bash/bash-4.2/crossfix.patch
> 
> Right, there is a bug in cgit. I'm not sure if anyone fancies trying to
> find/fix it?

Actually, its not hard to find:

http://hjemli.net/git/cgit/tree/ui-patch.c


In header(), the:
		htmlf("\n--- a/%s\n", path1);
		htmlf("+++ b/%s\n", path2);
needs to be conditional on is_null_sha1(sha1)/is_null_sha1(sha2) with
the alternative of:
		htmlf("\n--- /%s\n", path1);
		htmlf("+++ /%s\n", path2);
which there are a variety of ways to achieve...

Michael: Fancy fixing that on the server and sending a patch
upstream? :)

Cheers,

Richard