Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: jackie.huang@windriver.com
Cc: saul.wold@intel.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 0/2] eglibc: move the fix code for optimization isssue to .inc
Date: Wed, 28 Nov 2012 07:42:24 +0000	[thread overview]
Message-ID: <1354088544.21863.134.camel@ted> (raw)
In-Reply-To: <cover.1354081123.git.jackie.huang@windriver.com>

On Wed, 2012-11-28 at 14:11 +0800, jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
> 
> I made a patch against the eglibc_2.16.bb for the optimization issue two weeks ago,
> but it's not a version specific issue and we still keep the versions 2.13 and 2.15
> (and not having the 2.16 yet), so it would be more appropriate to move the code to
> the .inc file. 
> And we also want to cherry-pick this commit to our oe-core branch so I revert the
> previous one and make a new commit against the .inc file but I'm not sure if it is
> proper to do that. Please correct me if it is not, thanks!
> 
> * Test info:
> 1) MACHINE=qemux86-64/qemuppc/qemumips
> $ bitbake core-image-sato 
> $ bitbake eglibc
> 
> 2) MACHINE=qemux86-64/qemuppc/qemumips
>    DEBUG_OPTIMIZATION = "-O0 -fno-omit-frame-pointer ${DEBUG_FLAGS} -pipe"
>    DEBUG_BUILD = "1" or SELECTED_OPTIMIZATION = "${DEBUG_OPTIMIZATION}"
> $ bitbake core-image-sato
> $ bitbake eglibc
> 
> The following changes since commit 764cc1eb3043c84121f597d2271108b91052095e:
> 
>   bitbake.conf: Change build output message to list BUILD_SYS, TARGET_SYS and NATIVELSBSTRING (2012-11-27 08:57:39 +0000)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib jhuang0/d_eglibc_1128_1
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jhuang0/d_eglibc_1128_1
> 
> Jackie Huang (2):
>   Revert "eglibc: always compile with optimization."
>   eglibc: always compile with optimization.

I've queued this on master-next. I changed it from two commits to one
commit which just moves the code for the reason you describe.

Cheers,

Richard




      parent reply	other threads:[~2012-11-28  7:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28  6:11 [PATCH 0/2] eglibc: move the fix code for optimization isssue to .inc jackie.huang
2012-11-28  6:11 ` [PATCH 1/2] Revert "eglibc: always compile with optimization." jackie.huang
2012-11-28  6:11 ` [PATCH 2/2] eglibc: always compile with optimization jackie.huang
2012-11-28  7:42 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354088544.21863.134.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=jackie.huang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=saul.wold@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox