* Re: [PATCH] eglibc: fix evacuate_scripts for external toolchains
2013-01-25 14:27 [PATCH] eglibc: fix evacuate_scripts for external toolchains Marcin Juszkiewicz
@ 2013-01-25 14:32 ` Giuseppe CONDORELLI
2013-01-25 14:33 ` Richard Purdie
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Giuseppe CONDORELLI @ 2013-01-25 14:32 UTC (permalink / raw)
To: 'Marcin Juszkiewicz', openembedded-core
Well done Marcin,
I've just met this issue working with my local external-toolchain and I had
to
locally patch the same .inc for checking. :)
Thanks for having highlighted that in the mailing list.
Regards,
Giuseppe
>-----Original Message-----
>From: openembedded-core-bounces@lists.openembedded.org
>[mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
>Of Marcin Juszkiewicz
>Sent: venerdì 25 gennaio 2013 15:28
>To: openembedded-core@lists.openembedded.org
>Subject: [OE-core] [PATCH] eglibc: fix evacuate_scripts for external
toolchains
>
>Not every external toolchain has mtrace/sotruss/xtrace scripts so check
their
>existance first.
>
>Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
>---
> meta/recipes-core/eglibc/eglibc-package.inc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/meta/recipes-core/eglibc/eglibc-package.inc b/meta/recipes-
>core/eglibc/eglibc-package.inc
>index 79c43f1..4a4e54a 100644
>--- a/meta/recipes-core/eglibc/eglibc-package.inc
>+++ b/meta/recipes-core/eglibc/eglibc-package.inc
>@@ -113,7 +113,9 @@ do_evacuate_scripts () {
> target=${D}${includedir}/eglibc-scripts-internal-
>${MULTIMACH_TARGET_SYS}
> mkdir -p $target
> for i in ${bashscripts}; do
>- cp ${D}${bindir}/$i $target/
>+ if [ -f ${D}${bindir}/$i ]; then
>+ cp ${D}${bindir}/$i $target/
>+ fi
> done
> }
>
>--
>1.8.0
>
>
>_______________________________________________
>Openembedded-core mailing list
>Openembedded-core@lists.openembedded.org
>http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] eglibc: fix evacuate_scripts for external toolchains
2013-01-25 14:27 [PATCH] eglibc: fix evacuate_scripts for external toolchains Marcin Juszkiewicz
2013-01-25 14:32 ` Giuseppe CONDORELLI
@ 2013-01-25 14:33 ` Richard Purdie
2013-01-25 14:42 ` Marcin Juszkiewicz
2013-01-25 14:35 ` Giuseppe CONDORELLI
2013-01-25 14:36 ` Martin Jansa
3 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2013-01-25 14:33 UTC (permalink / raw)
To: Marcin Juszkiewicz; +Cc: openembedded-core
On Fri, 2013-01-25 at 15:27 +0100, Marcin Juszkiewicz wrote:
> Not every external toolchain has mtrace/sotruss/xtrace scripts so check
> their existance first.
>
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> ---
> meta/recipes-core/eglibc/eglibc-package.inc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/eglibc/eglibc-package.inc b/meta/recipes-core/eglibc/eglibc-package.inc
> index 79c43f1..4a4e54a 100644
> --- a/meta/recipes-core/eglibc/eglibc-package.inc
> +++ b/meta/recipes-core/eglibc/eglibc-package.inc
> @@ -113,7 +113,9 @@ do_evacuate_scripts () {
> target=${D}${includedir}/eglibc-scripts-internal-${MULTIMACH_TARGET_SYS}
> mkdir -p $target
> for i in ${bashscripts}; do
> - cp ${D}${bindir}/$i $target/
> + if [ -f ${D}${bindir}/$i ]; then
> + cp ${D}${bindir}/$i $target/
> + fi
> done
> }
At least lets try and indent it consistently :)
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] eglibc: fix evacuate_scripts for external toolchains
2013-01-25 14:33 ` Richard Purdie
@ 2013-01-25 14:42 ` Marcin Juszkiewicz
0 siblings, 0 replies; 6+ messages in thread
From: Marcin Juszkiewicz @ 2013-01-25 14:42 UTC (permalink / raw)
To: openembedded-core
Not every external toolchain has mtrace/sotruss/xtrace scripts so check
their existance first.
Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
meta/recipes-core/eglibc/eglibc-package.inc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-core/eglibc/eglibc-package.inc b/meta/recipes-core/eglibc/eglibc-package.inc
index 79c43f1..4a4e54a 100644
--- a/meta/recipes-core/eglibc/eglibc-package.inc
+++ b/meta/recipes-core/eglibc/eglibc-package.inc
@@ -113,7 +113,9 @@ do_evacuate_scripts () {
target=${D}${includedir}/eglibc-scripts-internal-${MULTIMACH_TARGET_SYS}
mkdir -p $target
for i in ${bashscripts}; do
- cp ${D}${bindir}/$i $target/
+ if [ -f ${D}${bindir}/$i ]; then
+ cp ${D}${bindir}/$i $target/
+ fi
done
}
--
1.8.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] eglibc: fix evacuate_scripts for external toolchains
2013-01-25 14:27 [PATCH] eglibc: fix evacuate_scripts for external toolchains Marcin Juszkiewicz
2013-01-25 14:32 ` Giuseppe CONDORELLI
2013-01-25 14:33 ` Richard Purdie
@ 2013-01-25 14:35 ` Giuseppe CONDORELLI
2013-01-25 14:36 ` Martin Jansa
3 siblings, 0 replies; 6+ messages in thread
From: Giuseppe CONDORELLI @ 2013-01-25 14:35 UTC (permalink / raw)
To: 'Marcin Juszkiewicz', openembedded-core
However, what about the resultant libraries as well as libsotruss?
Do we have to also to remove them from file inclusion to avoid warnings?
Cheers,
Giuseppe
>-----Original Message-----
>From: Giuseppe Condorelli [mailto:giuseppe.condorelli@st.com]
>Sent: venerdì 25 gennaio 2013 15:32
>To: 'Marcin Juszkiewicz'; 'openembedded-core@lists.openembedded.org'
>Subject: RE: [OE-core] [PATCH] eglibc: fix evacuate_scripts for external
>toolchains
>
>Well done Marcin,
>I've just met this issue working with my local external-toolchain and I
had to
>locally patch the same .inc for checking. :)
>
>Thanks for having highlighted that in the mailing list.
>Regards,
>Giuseppe
>
>>-----Original Message-----
>>From: openembedded-core-bounces@lists.openembedded.org
>>[mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
>Of
>>Marcin Juszkiewicz
>>Sent: venerdì 25 gennaio 2013 15:28
>>To: openembedded-core@lists.openembedded.org
>>Subject: [OE-core] [PATCH] eglibc: fix evacuate_scripts for external
>>toolchains
>>
>>Not every external toolchain has mtrace/sotruss/xtrace scripts so check
>>their existance first.
>>
>>Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
>>---
>> meta/recipes-core/eglibc/eglibc-package.inc | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>>diff --git a/meta/recipes-core/eglibc/eglibc-package.inc
>>b/meta/recipes- core/eglibc/eglibc-package.inc index 79c43f1..4a4e54a
>>100644
>>--- a/meta/recipes-core/eglibc/eglibc-package.inc
>>+++ b/meta/recipes-core/eglibc/eglibc-package.inc
>>@@ -113,7 +113,9 @@ do_evacuate_scripts () {
>> target=${D}${includedir}/eglibc-scripts-internal-
>>${MULTIMACH_TARGET_SYS}
>> mkdir -p $target
>> for i in ${bashscripts}; do
>>- cp ${D}${bindir}/$i $target/
>>+ if [ -f ${D}${bindir}/$i ]; then
>>+ cp ${D}${bindir}/$i $target/
>>+ fi
>> done
>> }
>>
>>--
>>1.8.0
>>
>>
>>_______________________________________________
>>Openembedded-core mailing list
>>Openembedded-core@lists.openembedded.org
>>http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] eglibc: fix evacuate_scripts for external toolchains
2013-01-25 14:27 [PATCH] eglibc: fix evacuate_scripts for external toolchains Marcin Juszkiewicz
` (2 preceding siblings ...)
2013-01-25 14:35 ` Giuseppe CONDORELLI
@ 2013-01-25 14:36 ` Martin Jansa
3 siblings, 0 replies; 6+ messages in thread
From: Martin Jansa @ 2013-01-25 14:36 UTC (permalink / raw)
To: Marcin Juszkiewicz; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]
On Fri, Jan 25, 2013 at 03:27:55PM +0100, Marcin Juszkiewicz wrote:
> Not every external toolchain has mtrace/sotruss/xtrace scripts so check
> their existance first.
>
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> ---
> meta/recipes-core/eglibc/eglibc-package.inc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/eglibc/eglibc-package.inc b/meta/recipes-core/eglibc/eglibc-package.inc
> index 79c43f1..4a4e54a 100644
> --- a/meta/recipes-core/eglibc/eglibc-package.inc
> +++ b/meta/recipes-core/eglibc/eglibc-package.inc
> @@ -113,7 +113,9 @@ do_evacuate_scripts () {
> target=${D}${includedir}/eglibc-scripts-internal-${MULTIMACH_TARGET_SYS}
> mkdir -p $target
> for i in ${bashscripts}; do
> - cp ${D}${bindir}/$i $target/
> + if [ -f ${D}${bindir}/$i ]; then
> + cp ${D}${bindir}/$i $target/
> + fi
Please don't use mix of spaces and tabs for indentation.
> done
> }
>
> --
> 1.8.0
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread