[PATCH] mesa-dri: add extra dri drivers

[PATCH] mesa-dri: add extra dri drivers

[igeiser]

From: Ian Reinhart Geiser <igeiser@devonit.com>

On x86 the ATI and NVidia drm drivers are valid to build.
Currently there are _append_x86 and _append_x64 lines that
explicitly add i915 and i965.  For consistency I think that
the ATI and NVidia drm driver should be added. In classic
these were tunable via the machine configuration files. I
would argue we should go back to that so we should make
the DRIDRIVERS field something that can be defined there.

* Made the DRIDRIVERS field overridable.
* Add ATI and NVidia DRI drivers to the build list for
  x86 and x86_64.

Signed-off-by: Ian Reinhart Geiser <igeiser@devonit.com>
---
 meta/recipes-graphics/mesa/mesa-dri.inc |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-graphics/mesa/mesa-dri.inc b/meta/recipes-graphics/mesa/mesa-dri.inc
index 1f6ec78..12e9dd5 100644
--- a/meta/recipes-graphics/mesa/mesa-dri.inc
+++ b/meta/recipes-graphics/mesa/mesa-dri.inc
@@ -1,9 +1,9 @@
 DEPENDS += "libdrm expat udev"
 X11_DEPS += "dri2proto"
 
-DRIDRIVERS = "swrast"
-DRIDRIVERS_append_x86 = ",i915,i965"
-DRIDRIVERS_append_x86-64 = ",i915,i965"
+DRIDRIVERS ?= "swrast"
+DRIDRIVERS_append_x86 = ",i915,i965,nouveau,r200,radeon"
+DRIDRIVERS_append_x86-64 = ",i915,i965,nouveau,r200,radeon"
 
 EXTRA_OECONF += "--disable-gallium --without-gallium-drivers"
 EXTRA_OECONF += "--enable-dri --with-dri-drivers=${DRIDRIVERS}"
-- 
1.7.9.5

Re: [PATCH] mesa-dri: add extra dri drivers

[Burton, Ross]

On 30 January 2013 13:26,  <igeiser@devonit.com> wrote:
> On x86 the ATI and NVidia drm drivers are valid to build.
> Currently there are _append_x86 and _append_x64 lines that
> explicitly add i915 and i965.  For consistency I think that
> the ATI and NVidia drm driver should be added. In classic
> these were tunable via the machine configuration files. I
> would argue we should go back to that so we should make
> the DRIDRIVERS field something that can be defined there.
>
> * Made the DRIDRIVERS field overridable.
> * Add ATI and NVidia DRI drivers to the build list for
>   x86 and x86_64.

I'm not sure why we need to make this machine-tunable - we currently
build all drivers in libdrm (but split them between packages), so why
not just enable all working DRI drivers in Mesa and split them between
packages.

Machine configurations can pull in specific driver packages (or all of
them) without making Mesa itself machine-specific.

Can you send a V2 without the conditional assignment (unless you have
an argument for keeping it), with a commit message that just describes
the patch.

Ross

Re: [PATCH] mesa-dri: add extra dri drivers

[Ian Geiser]

> -----Original Message-----
> From: Burton, Ross [mailto:ross.burton@intel.com]
> Sent: Wednesday, January 30, 2013 10:16 AM
> To: Ian Geiser
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] mesa-dri: add extra dri drivers
> 
> On 30 January 2013 13:26,  <igeiser@devonit.com> wrote:
> > On x86 the ATI and NVidia drm drivers are valid to build.
> > Currently there are _append_x86 and _append_x64 lines that explicitly
> > add i915 and i965.  For consistency I think that the ATI and NVidia
> > drm driver should be added. In classic these were tunable via the
> > machine configuration files. I would argue we should go back to that
> > so we should make the DRIDRIVERS field something that can be defined
> > there.
> >
> > * Made the DRIDRIVERS field overridable.
> > * Add ATI and NVidia DRI drivers to the build list for
> >   x86 and x86_64.
> 
> I'm not sure why we need to make this machine-tunable - we currently
> build all drivers in libdrm (but split them between packages), so why
> not just enable all working DRI drivers in Mesa and split them between
> packages.
> 
> Machine configurations can pull in specific driver packages (or all of
> them) without making Mesa itself machine-specific.
> 
> Can you send a V2 without the conditional assignment (unless you have
> an argument for keeping it), with a commit message that just describes
> the patch.
No, I was just extending what was there so I have no real preference.  I will need to check if it impacts non-x86 builds.  I do not think it will be a problem, since most non-x86 systems have their own GL implementations.  I think it will just enable swrast on ones that are not x86.  I will resubmit with it set to auto where it will only build the appropriate drivers after I test.  Thanks!

Re: [PATCH] mesa-dri: add extra dri drivers

[Burton, Ross]

On 30 January 2013 16:38, Ian Geiser <igeiser@devonit.com> wrote:
> No, I was just extending what was there so I have no real preference.  I will need to check if it impacts non-x86 builds.  I do not think it will be a problem, since most non-x86 systems have their own GL implementations.  I think it will just enable swrast on ones that are not x86.  I will resubmit with it set to auto where it will only build the appropriate drivers after I test.  Thanks!

In general explicitly stating things is preferred so the current
arrangement works nicely, so just adding the extra drivers to the
append lines is good.

Ross