* [PATCH] nfs-utils: Add scratch directory for NFS upcall state storage
@ 2013-02-26 23:59 Rich Dubielzig
0 siblings, 0 replies; 7+ messages in thread
From: Rich Dubielzig @ 2013-02-26 23:59 UTC (permalink / raw)
To: Openembedded-core; +Cc: rich.dubielzig
When the /var/lib/nfs/v4recovery directory is not present, NFSD cannot
record the upcall state and cannot end the 90-second grace period on
startup. This is true even when NFS4 is not being served according to
nfsstat.
More details and discussion here:
https://lkml.org/lkml/2012/6/11/206
Signed-off-by: Rich Dubielzig <rich.dubielzig@windriver.com>
---
.../nfs-utils/nfs-utils_1.2.3.bb | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
index 84c4464..f9dedfb 100644
--- a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
+++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
@@ -12,7 +12,7 @@ DEPENDS = "libcap libnfsidmap libevent util-linux tcp-wrappers"
RDEPENDS_${PN} = "rpcbind"
RRECOMMENDS_${PN} = "kernel-module-nfsd"
-PR = "r4"
+PR = "r5"
SRC_URI = "${SOURCEFORGE_MIRROR}/nfs/nfs-utils-${PV}.tar.bz2 \
file://nfs-utils-1.0.6-uclibc.patch \
@@ -53,6 +53,7 @@ RDEPENDS_${PN}-stats = "python"
do_install_append () {
install -d ${D}${sysconfdir}/init.d
install -m 0755 ${WORKDIR}/nfsserver ${D}${sysconfdir}/init.d/nfsserver
+ install -d ${D}${localstatedir}/lib/nfs/v4recovery
# the following are built by CC_FOR_BUILD
rm -f ${D}${sbindir}/rpcdebug
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] nfs-utils: Add scratch directory for NFS upcall state storage
@ 2013-02-25 18:44 Rich Dubielzig
2013-02-25 23:45 ` Saul Wold
0 siblings, 1 reply; 7+ messages in thread
From: Rich Dubielzig @ 2013-02-25 18:44 UTC (permalink / raw)
To: Openembedded-core; +Cc: rich.dubielzig
When the /var/lib/nfs/v4recovery directory is not present, NFSD cannot
record the upcall state and cannot end the 90-second grace period on
startup. This is true even when NFS4 is not being served according to
nfsstat.
More details and discussion here:
https://lkml.org/lkml/2012/6/11/206
Signed-off-by: Rich Dubielzig <rich.dubielzig@windriver.com>
---
.../nfs-utils/nfs-utils_1.2.3.bb | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
index 84c4464..a0b2399 100644
--- a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
+++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
@@ -12,7 +12,7 @@ DEPENDS = "libcap libnfsidmap libevent util-linux tcp-wrappers"
RDEPENDS_${PN} = "rpcbind"
RRECOMMENDS_${PN} = "kernel-module-nfsd"
-PR = "r4"
+PR = "r5"
SRC_URI = "${SOURCEFORGE_MIRROR}/nfs/nfs-utils-${PV}.tar.bz2 \
file://nfs-utils-1.0.6-uclibc.patch \
@@ -58,4 +58,7 @@ do_install_append () {
rm -f ${D}${sbindir}/rpcdebug
rm -f ${D}${sbindir}/rpcgen
rm -f ${D}${sbindir}/locktest
+
+ # needed to allow NFSD to end its grace period
+ install -d ${D}/var/lib/nfs/v4recovery
}
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] nfs-utils: Add scratch directory for NFS upcall state storage
2013-02-25 18:44 Rich Dubielzig
@ 2013-02-25 23:45 ` Saul Wold
2013-02-26 20:02 ` Dubielzig, Rich
0 siblings, 1 reply; 7+ messages in thread
From: Saul Wold @ 2013-02-25 23:45 UTC (permalink / raw)
To: Rich Dubielzig; +Cc: Openembedded-core
On 02/25/2013 10:44 AM, Rich Dubielzig wrote:
> When the /var/lib/nfs/v4recovery directory is not present, NFSD cannot
> record the upcall state and cannot end the 90-second grace period on
> startup. This is true even when NFS4 is not being served according to
> nfsstat.
>
> More details and discussion here:
> https://lkml.org/lkml/2012/6/11/206
>
> Signed-off-by: Rich Dubielzig <rich.dubielzig@windriver.com>
> ---
> .../nfs-utils/nfs-utils_1.2.3.bb | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
> index 84c4464..a0b2399 100644
> --- a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
> +++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
> @@ -12,7 +12,7 @@ DEPENDS = "libcap libnfsidmap libevent util-linux tcp-wrappers"
> RDEPENDS_${PN} = "rpcbind"
> RRECOMMENDS_${PN} = "kernel-module-nfsd"
>
> -PR = "r4"
> +PR = "r5"
>
> SRC_URI = "${SOURCEFORGE_MIRROR}/nfs/nfs-utils-${PV}.tar.bz2 \
> file://nfs-utils-1.0.6-uclibc.patch \
> @@ -58,4 +58,7 @@ do_install_append () {
> rm -f ${D}${sbindir}/rpcdebug
> rm -f ${D}${sbindir}/rpcgen
> rm -f ${D}${sbindir}/locktest
> +
> + # needed to allow NFSD to end its grace period
> + install -d ${D}/var/lib/nfs/v4recovery
This should really use ${localstatedir} instead of var, it would also be
better to co-locate this with the other directory creations earlier in
the do_install_append().
Sau!
> }
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] nfs-utils: Add scratch directory for NFS upcall state storage
2013-02-25 23:45 ` Saul Wold
@ 2013-02-26 20:02 ` Dubielzig, Rich
2013-02-27 0:03 ` Khem Raj
0 siblings, 1 reply; 7+ messages in thread
From: Dubielzig, Rich @ 2013-02-26 20:02 UTC (permalink / raw)
To: Saul Wold; +Cc: Openembedded-core@lists.openembedded.org
I can make this change, but if ${localstatedir} ends up being different than /var it would not be consistent with current kernel code which hardcodes the path "/var/lib/nfs/v4recovery" by default in fs/nfsd/nfs4recover.c
http://lxr.linux.no/#linux+v3.8/fs/nfsd/nfs4recover.c
-Rich
________________________________________
From: Saul Wold [sgw@linux.intel.com]
Sent: Monday, February 25, 2013 3:45 PM
To: Dubielzig, Rich
Cc: Openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] nfs-utils: Add scratch directory for NFS upcall state storage
On 02/25/2013 10:44 AM, Rich Dubielzig wrote:
> When the /var/lib/nfs/v4recovery directory is not present, NFSD cannot
> record the upcall state and cannot end the 90-second grace period on
> startup. This is true even when NFS4 is not being served according to
> nfsstat.
>
> More details and discussion here:
> https://lkml.org/lkml/2012/6/11/206
>
> Signed-off-by: Rich Dubielzig <rich.dubielzig@windriver.com>
> ---
> .../nfs-utils/nfs-utils_1.2.3.bb | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
> index 84c4464..a0b2399 100644
> --- a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
> +++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
> @@ -12,7 +12,7 @@ DEPENDS = "libcap libnfsidmap libevent util-linux tcp-wrappers"
> RDEPENDS_${PN} = "rpcbind"
> RRECOMMENDS_${PN} = "kernel-module-nfsd"
>
> -PR = "r4"
> +PR = "r5"
>
> SRC_URI = "${SOURCEFORGE_MIRROR}/nfs/nfs-utils-${PV}.tar.bz2 \
> file://nfs-utils-1.0.6-uclibc.patch \
> @@ -58,4 +58,7 @@ do_install_append () {
> rm -f ${D}${sbindir}/rpcdebug
> rm -f ${D}${sbindir}/rpcgen
> rm -f ${D}${sbindir}/locktest
> +
> + # needed to allow NFSD to end its grace period
> + install -d ${D}/var/lib/nfs/v4recovery
This should really use ${localstatedir} instead of var, it would also be
better to co-locate this with the other directory creations earlier in
the do_install_append().
Sau!
> }
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] nfs-utils: Add scratch directory for NFS upcall state storage
2013-02-26 20:02 ` Dubielzig, Rich
@ 2013-02-27 0:03 ` Khem Raj
0 siblings, 0 replies; 7+ messages in thread
From: Khem Raj @ 2013-02-27 0:03 UTC (permalink / raw)
To: Dubielzig, Rich; +Cc: Openembedded-core@lists.openembedded.org
On Tue, Feb 26, 2013 at 12:02 PM, Dubielzig, Rich
<rich.dubielzig@windriver.com> wrote:
> I can make this change, but if ${localstatedir} ends up being different than /var it would not be consistent with current kernel code which hardcodes the path "/var/lib/nfs/v4recovery" by default in fs/nfsd/nfs4recover.c
>
> http://lxr.linux.no/#linux+v3.8/fs/nfsd/nfs4recover.c
too bad. I think if you add this to commend and keep it hardcoded that
will be better for future reference IMO so we know why we
used /var and not conf var.
>
> -Rich
> ________________________________________
> From: Saul Wold [sgw@linux.intel.com]
> Sent: Monday, February 25, 2013 3:45 PM
> To: Dubielzig, Rich
> Cc: Openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] nfs-utils: Add scratch directory for NFS upcall state storage
>
> On 02/25/2013 10:44 AM, Rich Dubielzig wrote:
>> When the /var/lib/nfs/v4recovery directory is not present, NFSD cannot
>> record the upcall state and cannot end the 90-second grace period on
>> startup. This is true even when NFS4 is not being served according to
>> nfsstat.
>>
>> More details and discussion here:
>> https://lkml.org/lkml/2012/6/11/206
>>
>> Signed-off-by: Rich Dubielzig <rich.dubielzig@windriver.com>
>> ---
>> .../nfs-utils/nfs-utils_1.2.3.bb | 5 ++++-
>> 1 files changed, 4 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
>> index 84c4464..a0b2399 100644
>> --- a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
>> +++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
>> @@ -12,7 +12,7 @@ DEPENDS = "libcap libnfsidmap libevent util-linux tcp-wrappers"
>> RDEPENDS_${PN} = "rpcbind"
>> RRECOMMENDS_${PN} = "kernel-module-nfsd"
>>
>> -PR = "r4"
>> +PR = "r5"
>>
>> SRC_URI = "${SOURCEFORGE_MIRROR}/nfs/nfs-utils-${PV}.tar.bz2 \
>> file://nfs-utils-1.0.6-uclibc.patch \
>> @@ -58,4 +58,7 @@ do_install_append () {
>> rm -f ${D}${sbindir}/rpcdebug
>> rm -f ${D}${sbindir}/rpcgen
>> rm -f ${D}${sbindir}/locktest
>> +
>> + # needed to allow NFSD to end its grace period
>> + install -d ${D}/var/lib/nfs/v4recovery
>
> This should really use ${localstatedir} instead of var, it would also be
> better to co-locate this with the other directory creations earlier in
> the do_install_append().
>
> Sau!
>
>> }
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] nfs-utils: Add scratch directory for NFS upcall state storage
@ 2013-02-25 18:33 Rich Dubielzig
0 siblings, 0 replies; 7+ messages in thread
From: Rich Dubielzig @ 2013-02-25 18:33 UTC (permalink / raw)
To: Openembedded-core; +Cc: rich.dubielzig
When the /var/lib/nfs/v4recovery directory is not present, NFSD cannot
record the upcall state and cannot end the 90-second grace period on
startup. This is true even when NFS4 is not being served according to
nfsstat.
More details and discussion here:
https://lkml.org/lkml/2012/6/11/206
Signed-off-by: Rich Dubielzig <rich.dubielzig@windriver.com>
---
.../nfs-utils/nfs-utils_1.2.3.bb | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
index 84c4464..8999bc8 100644
--- a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
+++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
@@ -58,4 +58,7 @@ do_install_append () {
rm -f ${D}${sbindir}/rpcdebug
rm -f ${D}${sbindir}/rpcgen
rm -f ${D}${sbindir}/locktest
+
+ # needed to allow NFSD to end its grace period
+ install -d ${D}/var/lib/nfs/v4recovery
}
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] nfs-utils: Add scratch directory for NFS upcall state storage
@ 2013-02-25 18:06 Rich Dubielzig
0 siblings, 0 replies; 7+ messages in thread
From: Rich Dubielzig @ 2013-02-25 18:06 UTC (permalink / raw)
To: openembedded-core
When the /var/lib/nfs/v4recovery directory is not present, NFSD cannot
record the upcall state and cannot end the 90-second grace period on
startup. This is true even when NFS4 is not being served according to
nfsstat.
More details and discussion here:
https://lkml.org/lkml/2012/6/11/206
Signed-off-by: Rich Dubielzig <rich.dubielzig@windriver.com>
---
.../nfs-utils/nfs-utils_1.2.3.bb | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
index 84c4464..8999bc8 100644
--- a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
+++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
@@ -58,4 +58,7 @@ do_install_append () {
rm -f ${D}${sbindir}/rpcdebug
rm -f ${D}${sbindir}/rpcgen
rm -f ${D}${sbindir}/locktest
+
+ # needed to allow NFSD to end its grace period
+ install -d ${D}/var/lib/nfs/v4recovery
}
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-02-27 0:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-26 23:59 [PATCH] nfs-utils: Add scratch directory for NFS upcall state storage Rich Dubielzig
-- strict thread matches above, loose matches on Subject: below --
2013-02-25 18:44 Rich Dubielzig
2013-02-25 23:45 ` Saul Wold
2013-02-26 20:02 ` Dubielzig, Rich
2013-02-27 0:03 ` Khem Raj
2013-02-25 18:33 Rich Dubielzig
2013-02-25 18:06 Rich Dubielzig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox