* [PATCH v2] btrfs-tools: added PV to git package recipe
@ 2013-03-01 12:19 Emilia Ciobanu
2013-03-01 12:41 ` Richard Purdie
0 siblings, 1 reply; 10+ messages in thread
From: Emilia Ciobanu @ 2013-03-01 12:19 UTC (permalink / raw)
To: openembedded-core
Signed-off-by: Emilia Ciobanu <emilia.maria.silvia.ciobanu@intel.com>
---
.../btrfs-tools/btrfs-tools_git.bb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb b/meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb
index e963a74..df216b1 100644
--- a/meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb
+++ b/meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb
@@ -17,6 +17,8 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git;p
S = "${WORKDIR}/git"
+PV = "0.20-rc1+git${SRCPV}"
+
PR = "r6"
SRC_URI += " file://fix_use_of_gcc.patch \
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2] btrfs-tools: added PV to git package recipe
2013-03-01 12:19 [PATCH v2] btrfs-tools: added PV to git package recipe Emilia Ciobanu
@ 2013-03-01 12:41 ` Richard Purdie
2013-03-01 19:11 ` Saul Wold
0 siblings, 1 reply; 10+ messages in thread
From: Richard Purdie @ 2013-03-01 12:41 UTC (permalink / raw)
To: Emilia Ciobanu; +Cc: openembedded-core
On Fri, 2013-03-01 at 14:19 +0200, Emilia Ciobanu wrote:
> Signed-off-by: Emilia Ciobanu <emilia.maria.silvia.ciobanu@intel.com>
> ---
> .../btrfs-tools/btrfs-tools_git.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb b/meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb
> index e963a74..df216b1 100644
> --- a/meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb
> +++ b/meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb
> @@ -17,6 +17,8 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git;p
>
> S = "${WORKDIR}/git"
>
> +PV = "0.20-rc1+git${SRCPV}"
> +
> PR = "r6"
Sadly this won't allow an upgrade path to 0.20 when its released.
We'd either need to use 0.20~rc1 or 0.19+0.20-rc1 as the string.
Cheers,
Richard
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2] btrfs-tools: added PV to git package recipe
2013-03-01 12:41 ` Richard Purdie
@ 2013-03-01 19:11 ` Saul Wold
2013-03-01 19:24 ` Martin Jansa
0 siblings, 1 reply; 10+ messages in thread
From: Saul Wold @ 2013-03-01 19:11 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On 03/01/2013 04:41 AM, Richard Purdie wrote:
> On Fri, 2013-03-01 at 14:19 +0200, Emilia Ciobanu wrote:
>> Signed-off-by: Emilia Ciobanu <emilia.maria.silvia.ciobanu@intel.com>
>> ---
>> .../btrfs-tools/btrfs-tools_git.bb | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb b/meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb
>> index e963a74..df216b1 100644
>> --- a/meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb
>> +++ b/meta/recipes-devtools/btrfs-tools/btrfs-tools_git.bb
>> @@ -17,6 +17,8 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git;p
>>
>> S = "${WORKDIR}/git"
>>
>> +PV = "0.20-rc1+git${SRCPV}"
>> +
>> PR = "r6"
>
> Sadly this won't allow an upgrade path to 0.20 when its released.
>
> We'd either need to use 0.20~rc1 or 0.19+0.20-rc1 as the string.
I would suggest the 0.20~rc1 variation since the Git Rev we are at is
already beyong 0.20-rc1 tag.
Sau!
>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2] btrfs-tools: added PV to git package recipe
2013-03-01 19:11 ` Saul Wold
@ 2013-03-01 19:24 ` Martin Jansa
2013-03-01 23:09 ` Burton, Ross
2013-03-01 23:46 ` Richard Purdie
0 siblings, 2 replies; 10+ messages in thread
From: Martin Jansa @ 2013-03-01 19:24 UTC (permalink / raw)
To: Saul Wold; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 2472 bytes --]
I don't think 0.20~rc1 sorts lower then 0.20 at least in opkg world:
OE @ ~/projects/opkg-utils $ ./opkg-compare-versions 0.20~rc1 '<=' 0.20 &&
echo "Y"
OE @ ~/projects/opkg-utils $ ./opkg-compare-versions 0.20-rc1 '<=' 0.20 &&
echo "Y"
OE @ ~/projects/opkg-utils $ ./opkg-compare-versions 0.19+0.20~rc1 '<='
0.20 && echo "Y"
Y
OE @ ~/projects/opkg-utils $ ./opkg-compare-versions 0.19+0.20-rc1 '<='
0.20 && echo "Y"
Y
On Fri, Mar 1, 2013 at 8:11 PM, Saul Wold <sgw@linux.intel.com> wrote:
> On 03/01/2013 04:41 AM, Richard Purdie wrote:
>
>> On Fri, 2013-03-01 at 14:19 +0200, Emilia Ciobanu wrote:
>>
>>> Signed-off-by: Emilia Ciobanu <emilia.maria.silvia.ciobanu@**intel.com<emilia.maria.silvia.ciobanu@intel.com>
>>> >
>>> ---
>>> .../btrfs-tools/btrfs-tools_**git.bb <http://btrfs-tools_git.bb>
>>> | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/meta/recipes-devtools/btrfs-**tools/btrfs-tools_git.bbb/meta/recipes-devtools/btrfs-
>>> **tools/btrfs-tools_git.bb
>>> index e963a74..df216b1 100644
>>> --- a/meta/recipes-devtools/btrfs-**tools/btrfs-tools_git.bb
>>> +++ b/meta/recipes-devtools/btrfs-**tools/btrfs-tools_git.bb
>>> @@ -17,6 +17,8 @@ SRC_URI = "git://git.kernel.org/pub/scm/**
>>> linux/kernel/git/mason/btrfs-**progs.git;p<http://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git;p>
>>>
>>> S = "${WORKDIR}/git"
>>>
>>> +PV = "0.20-rc1+git${SRCPV}"
>>> +
>>> PR = "r6"
>>>
>>
>> Sadly this won't allow an upgrade path to 0.20 when its released.
>>
>> We'd either need to use 0.20~rc1 or 0.19+0.20-rc1 as the string.
>>
>
> I would suggest the 0.20~rc1 variation since the Git Rev we are at is
> already beyong 0.20-rc1 tag.
>
> Sau!
>
>
>
>> Cheers,
>>
>> Richard
>>
>>
>> ______________________________**_________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.**openembedded.org<Openembedded-core@lists.openembedded.org>
>> http://lists.linuxtogo.org/**cgi-bin/mailman/listinfo/**openembedded-core<http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core>
>>
>>
>>
> ______________________________**_________________
> Openembedded-core mailing list
> Openembedded-core@lists.**openembedded.org<Openembedded-core@lists.openembedded.org>
> http://lists.linuxtogo.org/**cgi-bin/mailman/listinfo/**openembedded-core<http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core>
>
[-- Attachment #2: Type: text/html, Size: 4011 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2] btrfs-tools: added PV to git package recipe
2013-03-01 19:24 ` Martin Jansa
@ 2013-03-01 23:09 ` Burton, Ross
2013-03-01 23:19 ` Richard Purdie
2013-03-01 23:46 ` Richard Purdie
1 sibling, 1 reply; 10+ messages in thread
From: Burton, Ross @ 2013-03-01 23:09 UTC (permalink / raw)
To: Martin Jansa; +Cc: Patches and discussions about the oe-core layer
On 1 March 2013 19:24, Martin Jansa <martin.jansa@gmail.com> wrote:
> I don't think 0.20~rc1 sorts lower then 0.20 at least in opkg world:
Hmph, stupid opkg. That's just a quick change to the comparison logic
though right? Deb and rpm have these semantics for ~.
Ross
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] btrfs-tools: added PV to git package recipe
2013-03-01 23:09 ` Burton, Ross
@ 2013-03-01 23:19 ` Richard Purdie
0 siblings, 0 replies; 10+ messages in thread
From: Richard Purdie @ 2013-03-01 23:19 UTC (permalink / raw)
To: Burton, Ross; +Cc: the oe-core layer, Martin Jansa, Patches
On Fri, 2013-03-01 at 23:09 +0000, Burton, Ross wrote:
> On 1 March 2013 19:24, Martin Jansa <martin.jansa@gmail.com> wrote:
> > I don't think 0.20~rc1 sorts lower then 0.20 at least in opkg world:
>
> Hmph, stupid opkg. That's just a quick change to the comparison logic
> though right? Deb and rpm have these semantics for ~.
I'm sure I've seen changes for opkg itself and I think this util is out
of sync with the changes in opkg itself. It should really link against
libopkg and use the *same* version comparison algorithm.
Cheers,
Richard
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] btrfs-tools: added PV to git package recipe
2013-03-01 19:24 ` Martin Jansa
2013-03-01 23:09 ` Burton, Ross
@ 2013-03-01 23:46 ` Richard Purdie
2013-03-04 8:42 ` Ciobanu, Emilia Maria Silvia
1 sibling, 1 reply; 10+ messages in thread
From: Richard Purdie @ 2013-03-01 23:46 UTC (permalink / raw)
To: Martin Jansa; +Cc: oe-core layer, Patches
On Fri, 2013-03-01 at 20:24 +0100, Martin Jansa wrote:
> I don't think 0.20~rc1 sorts lower then 0.20 at least in opkg world:
>
>
> OE @ ~/projects/opkg-utils $ ./opkg-compare-versions 0.20~rc1 '<='
> 0.20 && echo "Y"
> OE @ ~/projects/opkg-utils $ ./opkg-compare-versions 0.20-rc1 '<='
> 0.20 && echo "Y"
> OE @ ~/projects/opkg-utils $ ./opkg-compare-versions 0.19+0.20~rc1
> '<=' 0.20 && echo "Y"
> Y
> OE @ ~/projects/opkg-utils $ ./opkg-compare-versions 0.19+0.20-rc1
> '<=' 0.20 && echo "Y"
> Y
Just to follow up, I added this support to opkg itself back in 2008:
http://code.google.com/p/opkg/source/detail?spec=svn40&r=40
It would be nice to finally be able to start using it!
Cheers,
Richard
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2] btrfs-tools: added PV to git package recipe
2013-03-01 23:46 ` Richard Purdie
@ 2013-03-04 8:42 ` Ciobanu, Emilia Maria Silvia
2013-03-04 10:03 ` Richard Purdie
0 siblings, 1 reply; 10+ messages in thread
From: Ciobanu, Emilia Maria Silvia @ 2013-03-04 8:42 UTC (permalink / raw)
To: Richard Purdie, Martin Jansa; +Cc: oe-core layer
I've tried building the package after added the "0.20~rc1" tag for
PV. This format for the tag doesn't seem to be supported. I
get the following error:
invalid tag value("^[A-Za-z0-9+._]+$") Version: Version: 0.20~rc1+git0+fdb6c0402337d9607c7a39155088eaf033742752
Thanks,
Ema
________________________________________
From: openembedded-core-bounces@lists.openembedded.org [openembedded-core-bounces@lists.openembedded.org] on behalf of Richard Purdie [richard.purdie@linuxfoundation.org]
Sent: Saturday, March 02, 2013 1:46 AM
To: Martin Jansa
Cc: oe-core layer; Patches
Subject: Re: [OE-core] [PATCH v2] btrfs-tools: added PV to git package recipe
On Fri, 2013-03-01 at 20:24 +0100, Martin Jansa wrote:
> I don't think 0.20~rc1 sorts lower then 0.20 at least in opkg world:
>
>
> OE @ ~/projects/opkg-utils $ ./opkg-compare-versions 0.20~rc1 '<='
> 0.20 && echo "Y"
> OE @ ~/projects/opkg-utils $ ./opkg-compare-versions 0.20-rc1 '<='
> 0.20 && echo "Y"
> OE @ ~/projects/opkg-utils $ ./opkg-compare-versions 0.19+0.20~rc1
> '<=' 0.20 && echo "Y"
> Y
> OE @ ~/projects/opkg-utils $ ./opkg-compare-versions 0.19+0.20-rc1
> '<=' 0.20 && echo "Y"
> Y
Just to follow up, I added this support to opkg itself back in 2008:
http://code.google.com/p/opkg/source/detail?spec=svn40&r=40
It would be nice to finally be able to start using it!
Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2] btrfs-tools: added PV to git package recipe
2013-03-04 8:42 ` Ciobanu, Emilia Maria Silvia
@ 2013-03-04 10:03 ` Richard Purdie
2013-03-04 11:13 ` Ciobanu, Emilia Maria Silvia
0 siblings, 1 reply; 10+ messages in thread
From: Richard Purdie @ 2013-03-04 10:03 UTC (permalink / raw)
To: Ciobanu, Emilia Maria Silvia; +Cc: Martin Jansa, oe-core layer
On Mon, 2013-03-04 at 08:42 +0000, Ciobanu, Emilia Maria Silvia wrote:
> I've tried building the package after added the "0.20~rc1" tag for
> PV. This format for the tag doesn't seem to be supported. I
> get the following error:
> invalid tag value("^[A-Za-z0-9+._]+$") Version: Version: 0.20~rc1+git0+fdb6c0402337d9607c7a39155088eaf033742752
Which part of the system did that error come from?
From what you've said, we should probably go with 0.19 for now and if we
upgrade past the tag, switch to 0.19+0.20-rc1.
We need to open a bug about ~ not working in package versions with the
bug in opkg-compare-versions and the above issue being mentioned.
Cheers,
Richard
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH v2] btrfs-tools: added PV to git package recipe
2013-03-04 10:03 ` Richard Purdie
@ 2013-03-04 11:13 ` Ciobanu, Emilia Maria Silvia
0 siblings, 0 replies; 10+ messages in thread
From: Ciobanu, Emilia Maria Silvia @ 2013-03-04 11:13 UTC (permalink / raw)
To: Richard Purdie; +Cc: Martin Jansa, oe-core layer
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
The error appeared at do_package.
I've attached the logfile.
Thanks,
Ema
________________________________________
From: Richard Purdie [richard.purdie@linuxfoundation.org]
Sent: Monday, March 04, 2013 12:03 PM
To: Ciobanu, Emilia Maria Silvia
Cc: Martin Jansa; oe-core layer
Subject: Re: [OE-core] [PATCH v2] btrfs-tools: added PV to git package recipe
On Mon, 2013-03-04 at 08:42 +0000, Ciobanu, Emilia Maria Silvia wrote:
> I've tried building the package after added the "0.20~rc1" tag for
> PV. This format for the tag doesn't seem to be supported. I
> get the following error:
> invalid tag value("^[A-Za-z0-9+._]+$") Version: Version: 0.20~rc1+git0+fdb6c0402337d9607c7a39155088eaf033742752
Which part of the system did that error come from?
From what you've said, we should probably go with 0.19 for now and if we
upgrade past the tag, switch to 0.19+0.20-rc1.
We need to open a bug about ~ not working in package versions with the
bug in opkg-compare-versions and the above issue being mentioned.
Cheers,
Richard
[-- Attachment #2: log.do_package_write_rpm.7628 --]
[-- Type: application/octet-stream, Size: 1374 bytes --]
DEBUG: Executing python function sstate_task_prefunc
DEBUG: Python function sstate_task_prefunc finished
DEBUG: Executing python function do_package_write_rpm
DEBUG: Executing python function read_subpackage_metadata
DEBUG: Python function read_subpackage_metadata finished
DEBUG: Executing python function do_package_rpm
DEBUG: Executing python function write_specfile
NOTE: Creating RPM package for btrfs-tools-dbg
NOTE: Not creating empty RPM package for btrfs-tools-staticdev
NOTE: Creating EMPTY RPM Package for btrfs-tools-dev
NOTE: Creating RPM package for btrfs-tools-doc
NOTE: Not creating empty RPM package for btrfs-tools-locale
NOTE: Creating RPM package for btrfs-tools
NOTE: Creating RPM package for btrfs-tools
DEBUG: Python function write_specfile finished
DEBUG: Executing shell function BUILDSPEC
error: line 3: invalid tag value("^[A-Za-z0-9+._]+$") Version: Version: 0.20~rc1+git0+fdb6c0402337d9607c7a39155088eaf033742752
error: Package has no %description: btrfs-tools.i586
Building target platforms: i586-poky-linux
DEBUG: Python function do_package_rpm finished
DEBUG: Python function do_package_write_rpm finished
ERROR: Function failed: BUILDSPEC (see /home/ema/ssd/webapy-app/poky/build/tmp/work/i586-poky-linux/btrfs-tools/0.20~rc1+gitAUTOINC+fdb6c0402337d9607c7a39155088eaf033742752-r6/temp/log.do_package_write_rpm.7628 for further information)
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-03-04 11:31 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-01 12:19 [PATCH v2] btrfs-tools: added PV to git package recipe Emilia Ciobanu
2013-03-01 12:41 ` Richard Purdie
2013-03-01 19:11 ` Saul Wold
2013-03-01 19:24 ` Martin Jansa
2013-03-01 23:09 ` Burton, Ross
2013-03-01 23:19 ` Richard Purdie
2013-03-01 23:46 ` Richard Purdie
2013-03-04 8:42 ` Ciobanu, Emilia Maria Silvia
2013-03-04 10:03 ` Richard Purdie
2013-03-04 11:13 ` Ciobanu, Emilia Maria Silvia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox