Missing gst-plugins-good package Was: [oe-commits] Richard Purdie : recipes: Fix ALLOW_EMPTY with no package specified

Missing gst-plugins-good package Was: [oe-commits] Richard Purdie : recipes: Fix ALLOW_EMPTY with no package specified

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]

On Tue, Mar 05, 2013 at 01:14:17PM +0000, git@git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: fe81bd4f600877e63433184cfc2e22c33bb77db6
> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=fe81bd4f600877e63433184cfc2e22c33bb77db6
> 
> Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> Date:   Sun Mar  3 15:54:29 2013 +0000
> 
> recipes: Fix ALLOW_EMPTY with no package specified
> 
> There are various usages of ALLOW_EMPTY with no packages specified. This
> is not recommended syntax, nor is it likely to be supported in the future.
> This patch improves the references in OE-Core, either removing them if they're
> pointless (e.g. when PACKAGES="") or specifying which package it applies to.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> --- a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
> +++ b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
> @@ -24,8 +24,6 @@ python populate_packages_prepend () {
>      d.setVar('DESCRIPTION_' + metapkg, pn + ' meta package')
>  }
>  
> -ALLOW_EMPTY = "1"
> -
>  PACKAGES += "${PN}-apps ${PN}-meta ${PN}-glib"
>  FILES_${PN}-apps = "${bindir}"

This change is correct ('ALLOW_EMPTY_' + metapkg is set few lines above).

Just wanted to warn others that I've found few examples in other layers
which were RDEPENDing also on ${PN} not metapkg and after this cleanup
some packages were failing to install in rootfs.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: Missing gst-plugins-good package Was: [oe-commits] Richard Purdie : recipes: Fix ALLOW_EMPTY with no package specified

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]

On Wed, Mar 06, 2013 at 09:53:39PM +0100, Martin Jansa wrote:
> On Tue, Mar 05, 2013 at 01:14:17PM +0000, git@git.openembedded.org wrote:
> > Module: openembedded-core.git
> > Branch: master
> > Commit: fe81bd4f600877e63433184cfc2e22c33bb77db6
> > URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=fe81bd4f600877e63433184cfc2e22c33bb77db6
> > 
> > Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> > Date:   Sun Mar  3 15:54:29 2013 +0000
> > 
> > recipes: Fix ALLOW_EMPTY with no package specified
> > 
> > There are various usages of ALLOW_EMPTY with no packages specified. This
> > is not recommended syntax, nor is it likely to be supported in the future.
> > This patch improves the references in OE-Core, either removing them if they're
> > pointless (e.g. when PACKAGES="") or specifying which package it applies to.
> > 
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > --- a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
> > +++ b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
> > @@ -24,8 +24,6 @@ python populate_packages_prepend () {
> >      d.setVar('DESCRIPTION_' + metapkg, pn + ' meta package')
> >  }
> >  
> > -ALLOW_EMPTY = "1"
> > -
> >  PACKAGES += "${PN}-apps ${PN}-meta ${PN}-glib"
> >  FILES_${PN}-apps = "${bindir}"
> 
> This change is correct ('ALLOW_EMPTY_' + metapkg is set few lines above).
> 
> Just wanted to warn others that I've found few examples in other layers
> which were RDEPENDing also on ${PN} not metapkg and after this cleanup
> some packages were failing to install in rootfs.

I take this back
even gst-plugins-good-meta is RDEPENDing on gst-plugins-good so
ALLOW_EMPTY_${PN} = "1" should be also set.

The problem is not in gst-plugins-bad, because this one includes few
/usr/lib/libgst*.so files (while only /usr/lib/gstreamer-0.10 are
splitted).

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

[PATCH] gst-plugins-package: return few ALLOW_EMPTY settings

[Martin Jansa]

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/recipes-multimedia/gstreamer/gst-plugins-package.inc | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
index 3e9ef92..7ae3ef6 100644
--- a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
+++ b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
@@ -24,6 +24,13 @@ python populate_packages_prepend () {
     d.setVar('DESCRIPTION_' + metapkg, pn + ' meta package')
 }
 
+# metapkg has runtime dependency on PN
+# each plugin depends on PN, plugin-dev on PN-dev and plugin-staticdev on PN-staticdev
+# so we need them even when empty (like in gst-plugins-good case)
+ALLOW_EMPTY_${PN} = "1"
+ALLOW_EMPTY_${PN}-dev = "1"
+ALLOW_EMPTY_${PN}-staticdev = "1"
+
 PACKAGES += "${PN}-apps ${PN}-meta ${PN}-glib"
 FILES_${PN}-apps = "${bindir}"
 
-- 
1.8.1.5