Re: [oe-commits] Denys Dmytriyenko : tune-cortexa15: add tunes for ARM Cortex-A15

* Re: [oe-commits] Denys Dmytriyenko : tune-cortexa15: add tunes for ARM Cortex-A15
       [not found] <20130307111408.37FDE5038A@opal>
@ 2013-03-07 13:38 ` Martin Jansa
  2013-03-07 13:41   ` [PATCH] tune-cortexa*: Fix TUNE_FEATURES and PACKAGE_EXTRA_ARCHS for thf-neon Martin Jansa
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Jansa @ 2013-03-07 13:38 UTC (permalink / raw)
  To: openembedded-core, Denys Dmytriyenko; +Cc: openembedded-commits

[-- Attachment #1: Type: text/plain, Size: 5250 bytes --]

On Thu, Mar 07, 2013 at 11:14:08AM +0000, git@git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: 513180af7f67b614dd0dbd8d9d77c057c45190b8
> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=513180af7f67b614dd0dbd8d9d77c057c45190b8
> 
> Author: Denys Dmytriyenko <denys@ti.com>
> Date:   Mon Mar  4 22:12:33 2013 -0500
> 
> tune-cortexa15: add tunes for ARM Cortex-A15
> 
> http://www.arm.com/products/processors/cortex-a/cortex-a15.php
> 
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>

I've compared new tune files with tune-cortexa8 (after s/a15/a8; s/a7/a8) and there are some differences:

< TUNE_FEATURES_tune-cortexa8thf-neon ?= "${TUNE_FEATURES_tune-armv7ahf-neon} cortexa8"
---
> TUNE_FEATURES_tune-cortexa8thf-neon ?= "${TUNE_FEATURES_tune-armv7athf-neon} cortexa8"
36c36
< PACKAGE_EXTRA_ARCHS_tune-cortexa8thf-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7athf-neon} cortexa8hf-vfp cortexa8hf-vfp-neon cortexa8t2-vfp cortexa8t2hf-vfp-neon"
---
> PACKAGE_EXTRA_ARCHS_tune-cortexa8thf-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7ahf-neon} cortexa8hf-vfp cortexa8hf-vfp-neon cortexa8t2hf-vfp cortexa8t2hf-vfp-neon"
OE @ ~/openembedded-core/meta/conf/machine/include $ diff tune-cortexa7.inc tune-cortexa8.inc 

< TUNE_FEATURES_tune-cortexa8thf-neon ?= "${TUNE_FEATURES_tune-armv7ahf-neon} cortexa8"
---
> TUNE_FEATURES_tune-cortexa8thf-neon ?= "${TUNE_FEATURES_tune-armv7athf-neon} cortexa8"
36c36
< PACKAGE_EXTRA_ARCHS_tune-cortexa8thf-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7athf-neon} cortexa8hf-vfp cortexa8hf-vfp-neon cortexa8t2-vfp cortexa8t2hf-vfp-neon"
---
> PACKAGE_EXTRA_ARCHS_tune-cortexa8thf-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7ahf-neon} cortexa8hf-vfp cortexa8hf-vfp-neon cortexa8t2hf-vfp cortexa8t2hf-vfp-neon"

I guess it's because a7/a15 were created from a9 which has the same issue (only a8 was fixed)

I'll send patch to fix those, but please test it.

> ---
> 
>  meta/conf/machine/include/tune-cortexa15.inc |   36 ++++++++++++++++++++++++++
>  1 files changed, 36 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/conf/machine/include/tune-cortexa15.inc b/meta/conf/machine/include/tune-cortexa15.inc
> new file mode 100644
> index 0000000..a9a8d0d
> --- /dev/null
> +++ b/meta/conf/machine/include/tune-cortexa15.inc
> @@ -0,0 +1,36 @@
> +DEFAULTTUNE ?= "armv7a-neon"
> +
> +require conf/machine/include/arm/arch-armv7a.inc
> +
> +TUNEVALID[cortexa15] = "Enable Cortex-A15 specific processor optimizations"
> +TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "cortexa15", "-mtune=cortex-a15", "", d)}"
> +
> +# Little Endian base configs
> +AVAILTUNES += "cortexa15 cortexa15t cortexa15-neon cortexa15t-neon"
> +ARMPKGARCH_tune-cortexa15 = "cortexa15"
> +ARMPKGARCH_tune-cortexa15t = "cortexa15"
> +ARMPKGARCH_tune-cortexa15-neon = "cortexa15"
> +ARMPKGARCH_tune-cortexa15t-neon = "cortexa15"
> +TUNE_FEATURES_tune-cortexa15 = "${TUNE_FEATURES_tune-armv7a} cortexa15"
> +TUNE_FEATURES_tune-cortexa15t = "${TUNE_FEATURES_tune-armv7at} cortexa15"
> +TUNE_FEATURES_tune-cortexa15-neon = "${TUNE_FEATURES_tune-armv7a-neon} cortexa15"
> +TUNE_FEATURES_tune-cortexa15t-neon = "${TUNE_FEATURES_tune-armv7at-neon} cortexa15"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa15 = "${PACKAGE_EXTRA_ARCHS_tune-armv7a} cortexa15-vfp"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa15t = "${PACKAGE_EXTRA_ARCHS_tune-armv7at} cortexa15-vfp cortexa15t2-vfp"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa15-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7a-neon} cortexa15-vfp cortexa15-vfp-neon"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa15t-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7at-neon} cortexa15-vfp cortexa15-vfp-neon cortexa15t2-vfp cortexa15t2-vfp-neon"
> +
> +# VFP Tunes
> +AVAILTUNES += "cortexa15hf cortexa15thf cortexa15hf-neon cortexa15thf-neon"
> +ARMPKGARCH_tune-cortexa15hf = "cortexa15"
> +ARMPKGARCH_tune-cortexa15thf = "cortexa15"
> +ARMPKGARCH_tune-cortexa15hf-neon = "cortexa15"
> +ARMPKGARCH_tune-cortexa15thf-neon = "cortexa15"
> +TUNE_FEATURES_tune-cortexa15hf ?= "${TUNE_FEATURES_tune-armv7ahf} cortexa15"
> +TUNE_FEATURES_tune-cortexa15thf ?= "${TUNE_FEATURES_tune-armv7athf} cortexa15"
> +TUNE_FEATURES_tune-cortexa15hf-neon ?= "${TUNE_FEATURES_tune-armv7ahf-neon} cortexa15"
> +TUNE_FEATURES_tune-cortexa15thf-neon ?= "${TUNE_FEATURES_tune-armv7ahf-neon} cortexa15"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa15hf = "${PACKAGE_EXTRA_ARCHS_tune-armv7ahf} cortexa15hf-vfp"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa15thf = "${PACKAGE_EXTRA_ARCHS_tune-armv7athf} cortexa15hf-vfp cortexa15t2hf-vfp"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa15hf-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7ahf-neon} cortexa15hf-vfp cortexa15hf-vfp-neon"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa15thf-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv7athf-neon} cortexa15hf-vfp cortexa15hf-vfp-neon cortexa15t2-vfp cortexa15t2hf-vfp-neon"
> 
> 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread