Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Phil Blundell <philb@gnu.org>
To: Rich Dubielzig <rich.dubielzig@windriver.com>
Cc: Openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] eglibc: Handle QA warnings in nativesdk (denzil)
Date: Fri, 08 Mar 2013 23:25:33 +0000	[thread overview]
Message-ID: <1362785133.19943.9.camel@x121e.pbcl.net> (raw)
In-Reply-To: <1362780455-31958-1-git-send-email-rich.dubielzig@windriver.com>

On Fri, 2013-03-08 at 14:07 -0800, Rich Dubielzig wrote:
> -FILES_${PN}-utils = "${bindir}/* ${sbindir}/*"
> +FILES_${PN}-utils = "${bindir}/* ${sbindir}/* ${base_sbindir}/ldconfig ${sysconfdir}/ld.so.conf"

Is that really correct?  There seem to be several slightly dubious
things about this patch:

1. In the version of oe-core I'm looking at, both ldconfig and
ld.so.conf go into ${PN} if USE_LDCONFIG=1, which is the default.
(Arguably this ought really to be a DISTRO_FEATURE nowadays.)  So,
adding them unconditionally to PN-utils seems like it is confusing at
best.

2. ld.so.conf isn't a utility and it isn't entirely obvious that it
belongs in PN-utils at all.

3. Your commit message didn't mention the change to ldconfig, and also
didn't give any details of what exactly the QA warnings were that it was
fixing.

thanks

p.





      parent reply	other threads:[~2013-03-08 23:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-08 22:07 [PATCH] eglibc: Handle QA warnings in nativesdk (denzil) Rich Dubielzig
2013-03-08 22:11 ` Khem Raj
2013-03-08 22:15   ` Richard Purdie
2013-03-08 22:44     ` Dubielzig, Rich
2013-03-08 23:25 ` Phil Blundell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1362785133.19943.9.camel@x121e.pbcl.net \
    --to=philb@gnu.org \
    --cc=Openembedded-core@lists.openembedded.org \
    --cc=rich.dubielzig@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox