Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] classes/buildhistory: implement history collection for SDKs
Date: Sat, 23 Mar 2013 16:05:20 +0000	[thread overview]
Message-ID: <1364054720.3097.27.camel@ted> (raw)
In-Reply-To: <d6c0028803399294e9eb24cd598a2edf65bbcfbf.1363981980.git.paul.eggleton@linux.intel.com>

On Fri, 2013-03-22 at 19:53 +0000, Paul Eggleton wrote:
> SDKs are constructed in a similar manner to images, and the contents can
> be influenced by a number of different factors, thus tracking the
> contents of produced SDKs when buildhistory is enabled can help detect
> the same kinds of issues as with images.
> 
> This required adding POPULATE_SDK_POST_HOST_COMMAND and
> SDK_POSTPROCESS_COMMAND variables so that data collection functions can
> be injected at the appropriate points in the SDK construction process,
> as well as moving the list_installed_packages and
> rootfs_list_installed_depends functions from the rootfs_{rpm,ipk,deb} to
> the package_{rpm,ipk,deb} classes so they can also be called during
> do_populate_sdk as well as do_rootfs.
> 
> Implements [YOCTO #3964].
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  meta/classes/buildhistory.bbclass      |  130 ++++++++++++++++++++++----------
>  meta/classes/package_deb.bbclass       |   28 +++++++
>  meta/classes/package_ipk.bbclass       |   24 ++++++
>  meta/classes/package_rpm.bbclass       |   17 +++++
>  meta/classes/populate_sdk_base.bbclass |    2 +
>  meta/classes/populate_sdk_deb.bbclass  |    1 +
>  meta/classes/populate_sdk_ipk.bbclass  |    2 +
>  meta/classes/populate_sdk_rpm.bbclass  |    1 +
>  meta/classes/rootfs_deb.bbclass        |   27 -------
>  meta/classes/rootfs_ipk.bbclass        |   22 ------
>  meta/classes/rootfs_rpm.bbclass        |   16 ----
>  11 files changed, 165 insertions(+), 105 deletions(-)

This broke all the builds. Try setting PACKAGE_CLASSES with multiple
entries. The order determines the exact breakage. The first class
inherited needs to "win" but with the overlapping function names, this
isn't the case.

Cheers,

Richard




  reply	other threads:[~2013-03-23 16:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22 19:53 [PATCH 0/2] Buildhistory improvements Paul Eggleton
2013-03-22 19:53 ` [PATCH 1/2] classes/buildhistory: implement history collection for SDKs Paul Eggleton
2013-03-23 16:05   ` Richard Purdie [this message]
2013-03-23 17:32     ` Paul Eggleton
2013-03-23 17:41       ` Richard Purdie
2013-03-22 19:53 ` [PATCH 2/2] classes/buildhistory: trim trailing spaces in file listings Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364054720.3097.27.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox