Re: [PATCH 1/2] classes/buildhistory: implement history collection for SDKs

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Saturday 23 March 2013 16:05:20 Richard Purdie wrote:
> On Fri, 2013-03-22 at 19:53 +0000, Paul Eggleton wrote:
> > SDKs are constructed in a similar manner to images, and the contents can
> > be influenced by a number of different factors, thus tracking the
> > contents of produced SDKs when buildhistory is enabled can help detect
> > the same kinds of issues as with images.
> > 
> > This required adding POPULATE_SDK_POST_HOST_COMMAND and
> > SDK_POSTPROCESS_COMMAND variables so that data collection functions can
> > be injected at the appropriate points in the SDK construction process,
> > as well as moving the list_installed_packages and
> > rootfs_list_installed_depends functions from the rootfs_{rpm,ipk,deb} to
> > the package_{rpm,ipk,deb} classes so they can also be called during
> > do_populate_sdk as well as do_rootfs.
> > 
> > Implements [YOCTO #3964].
> > 
> > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> > ---
> > 
> >  meta/classes/buildhistory.bbclass      |  130
> >  ++++++++++++++++++++++---------- meta/classes/package_deb.bbclass      
> >  |   28 +++++++
> >  meta/classes/package_ipk.bbclass       |   24 ++++++
> >  meta/classes/package_rpm.bbclass       |   17 +++++
> >  meta/classes/populate_sdk_base.bbclass |    2 +
> >  meta/classes/populate_sdk_deb.bbclass  |    1 +
> >  meta/classes/populate_sdk_ipk.bbclass  |    2 +
> >  meta/classes/populate_sdk_rpm.bbclass  |    1 +
> >  meta/classes/rootfs_deb.bbclass        |   27 -------
> >  meta/classes/rootfs_ipk.bbclass        |   22 ------
> >  meta/classes/rootfs_rpm.bbclass        |   16 ----
> >  11 files changed, 165 insertions(+), 105 deletions(-)
> 
> This broke all the builds. Try setting PACKAGE_CLASSES with multiple
> entries. The order determines the exact breakage. The first class
> inherited needs to "win" but with the overlapping function names, this
> isn't the case.

I will look into this this evening.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre