* [PATCH 3/3] lsb: distro codename info added
@ 2013-03-29 14:12 Cristian Iorga
2013-03-29 16:25 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Cristian Iorga @ 2013-03-29 14:12 UTC (permalink / raw)
To: openembedded-core
Poky distro codename info added to /etc/lsb-release file.
lsb_release script will not complain anymore about
the incompleteness of /etc/lsb-release file by
returning an error code.
Increases LSB compliance.
Partial fix for [YOCTO #4071].
Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
---
meta/recipes-extended/lsb/lsb_4.1.bb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb b/meta/recipes-extended/lsb/lsb_4.1.bb
index 01368b3..b28e9b6 100644
--- a/meta/recipes-extended/lsb/lsb_4.1.bb
+++ b/meta/recipes-extended/lsb/lsb_4.1.bb
@@ -2,7 +2,7 @@ DESCRIPTION = "LSB support for OpenEmbedded"
SECTION = "console/utils"
HOMEPAGE = "http://prdownloads.sourceforge.net/lsb"
LICENSE = "GPLv2+"
-PR = "r1"
+PR = "r2"
# lsb_release needs getopt
RDEPENDS_${PN} += "util-linux"
@@ -41,6 +41,7 @@ do_install(){
echo "\"" >> ${D}${sysconfdir}/lsb-release
echo "DISTRIB_ID=${DISTRO}" >> ${D}${sysconfdir}/lsb-release
echo "DISTRIB_RELEASE=${DISTRO_VERSION}" >> ${D}${sysconfdir}/lsb-release
+ echo "DISTRIB_CODENAME=${DISTRO_CODENAME}" >> ${D}${sysconfdir}/lsb-release
echo "DISTRIB_DESCRIPTION=\"${DISTRO_NAME} ${DISTRO_VERSION}\"" >> ${D}${sysconfdir}/lsb-release
if [ "${TARGET_ARCH}" = "i586" ];then
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 3/3] lsb: distro codename info added
2013-03-29 14:12 [PATCH 3/3] lsb: distro codename info added Cristian Iorga
@ 2013-03-29 16:25 ` Richard Purdie
2013-03-29 16:42 ` Iorga, Cristian
0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2013-03-29 16:25 UTC (permalink / raw)
To: Cristian Iorga; +Cc: openembedded-core
On Fri, 2013-03-29 at 16:12 +0200, Cristian Iorga wrote:
> Poky distro codename info added to /etc/lsb-release file.
> lsb_release script will not complain anymore about
> the incompleteness of /etc/lsb-release file by
> returning an error code.
> Increases LSB compliance.
>
> Partial fix for [YOCTO #4071].
>
> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> ---
> meta/recipes-extended/lsb/lsb_4.1.bb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
What about people who haven't set DISTRO_CODENAME?
Cheers,
Richard
> diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb b/meta/recipes-extended/lsb/lsb_4.1.bb
> index 01368b3..b28e9b6 100644
> --- a/meta/recipes-extended/lsb/lsb_4.1.bb
> +++ b/meta/recipes-extended/lsb/lsb_4.1.bb
> @@ -2,7 +2,7 @@ DESCRIPTION = "LSB support for OpenEmbedded"
> SECTION = "console/utils"
> HOMEPAGE = "http://prdownloads.sourceforge.net/lsb"
> LICENSE = "GPLv2+"
> -PR = "r1"
> +PR = "r2"
>
> # lsb_release needs getopt
> RDEPENDS_${PN} += "util-linux"
> @@ -41,6 +41,7 @@ do_install(){
> echo "\"" >> ${D}${sysconfdir}/lsb-release
> echo "DISTRIB_ID=${DISTRO}" >> ${D}${sysconfdir}/lsb-release
> echo "DISTRIB_RELEASE=${DISTRO_VERSION}" >> ${D}${sysconfdir}/lsb-release
> + echo "DISTRIB_CODENAME=${DISTRO_CODENAME}" >> ${D}${sysconfdir}/lsb-release
> echo "DISTRIB_DESCRIPTION=\"${DISTRO_NAME} ${DISTRO_VERSION}\"" >> ${D}${sysconfdir}/lsb-release
>
> if [ "${TARGET_ARCH}" = "i586" ];then
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 3/3] lsb: distro codename info added
2013-03-29 16:25 ` Richard Purdie
@ 2013-03-29 16:42 ` Iorga, Cristian
2013-03-29 17:02 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Iorga, Cristian @ 2013-03-29 16:42 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core@lists.openembedded.org
Hi Richard,
I guess a check can be done to see if DISTRO_CODENAME is set or not and add it selectively.
Is that ok?
/Cristian
-----Original Message-----
From: Richard Purdie [mailto:richard.purdie@linuxfoundation.org]
Sent: Friday, March 29, 2013 6:26 PM
To: Iorga, Cristian
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 3/3] lsb: distro codename info added
On Fri, 2013-03-29 at 16:12 +0200, Cristian Iorga wrote:
> Poky distro codename info added to /etc/lsb-release file.
> lsb_release script will not complain anymore about the incompleteness
> of /etc/lsb-release file by returning an error code.
> Increases LSB compliance.
>
> Partial fix for [YOCTO #4071].
>
> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> ---
> meta/recipes-extended/lsb/lsb_4.1.bb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
What about people who haven't set DISTRO_CODENAME?
Cheers,
Richard
> diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb
> b/meta/recipes-extended/lsb/lsb_4.1.bb
> index 01368b3..b28e9b6 100644
> --- a/meta/recipes-extended/lsb/lsb_4.1.bb
> +++ b/meta/recipes-extended/lsb/lsb_4.1.bb
> @@ -2,7 +2,7 @@ DESCRIPTION = "LSB support for OpenEmbedded"
> SECTION = "console/utils"
> HOMEPAGE = "http://prdownloads.sourceforge.net/lsb"
> LICENSE = "GPLv2+"
> -PR = "r1"
> +PR = "r2"
>
> # lsb_release needs getopt
> RDEPENDS_${PN} += "util-linux"
> @@ -41,6 +41,7 @@ do_install(){
> echo "\"" >> ${D}${sysconfdir}/lsb-release
> echo "DISTRIB_ID=${DISTRO}" >> ${D}${sysconfdir}/lsb-release
> echo "DISTRIB_RELEASE=${DISTRO_VERSION}" >>
> ${D}${sysconfdir}/lsb-release
> + echo "DISTRIB_CODENAME=${DISTRO_CODENAME}" >>
> +${D}${sysconfdir}/lsb-release
> echo "DISTRIB_DESCRIPTION=\"${DISTRO_NAME} ${DISTRO_VERSION}\"" >>
> ${D}${sysconfdir}/lsb-release
>
> if [ "${TARGET_ARCH}" = "i586" ];then
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-29 17:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-29 14:12 [PATCH 3/3] lsb: distro codename info added Cristian Iorga
2013-03-29 16:25 ` Richard Purdie
2013-03-29 16:42 ` Iorga, Cristian
2013-03-29 17:02 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox