Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] recipes: Fix ALLOW_EMPTY with no package specified
@ 2013-03-03 15:54 Richard Purdie
  0 siblings, 0 replies; 17+ messages in thread
From: Richard Purdie @ 2013-03-03 15:54 UTC (permalink / raw)
  To: openembedded-core

There are various usages of ALLOW_EMPTY with no packages specified. This
is not recommended syntax, nor is it likely to be supported in the future.
This patch improves the references in OE-Core, either removing them if they're
pointless (e.g. when PACKAGES="") or specifying which package it applies to.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-connectivity/openssl/ocf-linux.inc           |    2 +-
 meta/recipes-core/meta/package-index.bb                   |    1 -
 meta/recipes-devtools/installer/adt-installer_1.0.bb      |    2 --
 meta/recipes-extended/psmisc/psmisc.inc                   |    2 +-
 meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb   |    6 +++++-
 meta/recipes-multimedia/gstreamer/gst-plugins-package.inc |    2 --
 6 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/meta/recipes-connectivity/openssl/ocf-linux.inc b/meta/recipes-connectivity/openssl/ocf-linux.inc
index dba1f02..4efdc2f 100644
--- a/meta/recipes-connectivity/openssl/ocf-linux.inc
+++ b/meta/recipes-connectivity/openssl/ocf-linux.inc
@@ -20,5 +20,5 @@ do_install() {
     install -m 0644 ${S}/ocf/*.h ${D}${includedir}/crypto/
 }
 
-ALLOW_EMPTY = "1"
+ALLOW_EMPTY_${PN} = "1"
 BBCLASSEXTEND = "native nativesdk"
diff --git a/meta/recipes-core/meta/package-index.bb b/meta/recipes-core/meta/package-index.bb
index 99ac1a8..76bf331 100644
--- a/meta/recipes-core/meta/package-index.bb
+++ b/meta/recipes-core/meta/package-index.bb
@@ -2,7 +2,6 @@ DESCRIPTION = "Rebuild the package index"
 LICENSE = "MIT"
 
 INHIBIT_DEFAULT_DEPS = "1"
-ALLOW_EMPTY = "1"
 PACKAGES = ""
 
 do_fetch[noexec] = "1"
diff --git a/meta/recipes-devtools/installer/adt-installer_1.0.bb b/meta/recipes-devtools/installer/adt-installer_1.0.bb
index 227e866..0cc3b33 100644
--- a/meta/recipes-devtools/installer/adt-installer_1.0.bb
+++ b/meta/recipes-devtools/installer/adt-installer_1.0.bb
@@ -26,8 +26,6 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3
                     file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
 LICENSE = "MIT"
 
-ALLOW_EMPTY = "1"
-
 PACKAGES = ""
 
 PR = "r11"
diff --git a/meta/recipes-extended/psmisc/psmisc.inc b/meta/recipes-extended/psmisc/psmisc.inc
index 76af99e..68e0656 100644
--- a/meta/recipes-extended/psmisc/psmisc.inc
+++ b/meta/recipes-extended/psmisc/psmisc.inc
@@ -15,7 +15,7 @@ S = "${WORKDIR}/psmisc-${PV}"
 
 inherit autotools gettext
 
-ALLOW_EMPTY = "1"
+ALLOW_EMPTY_${PN} = "1"
 
 PACKAGES =+ "fuser fuser-doc killall killall-doc pstree pstree-doc"
 PACKAGES += "psmisc-extras"
diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
index 37c70c2..210da37 100644
--- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
+++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
@@ -14,7 +14,11 @@ PACKAGES = "\
     gst-meta-debug \
     gst-meta-video"
 
-ALLOW_EMPTY = "1"
+ALLOW_EMPTY_gst-meta-base = "1"
+ALLOW_EMPTY_gst-meta-x11-base = "1"
+ALLOW_EMPTY_gst-meta-audio = "1"
+ALLOW_EMPTY_gst-meta-debug = "1"
+ALLOW_EMPTY_gst-meta-video = "1"
 
 RDEPENDS_gst-meta-base = "\
     ${@base_contains('DISTRO_FEATURES', 'x11', 'gst-meta-x11-base', '', d)} \
diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
index f26aca5..3e9ef92 100644
--- a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
+++ b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
@@ -24,8 +24,6 @@ python populate_packages_prepend () {
     d.setVar('DESCRIPTION_' + metapkg, pn + ' meta package')
 }
 
-ALLOW_EMPTY = "1"
-
 PACKAGES += "${PN}-apps ${PN}-meta ${PN}-glib"
 FILES_${PN}-apps = "${bindir}"
 





^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 1/7] kernel.bbclass: Ensure we have correct version information in deploy data
@ 2013-04-15 11:07 Richard Purdie
  2013-04-15 11:07 ` [PATCH] recipes: Fix ALLOW_EMPTY with no package specified Richard Purdie
                   ` (7 more replies)
  0 siblings, 8 replies; 17+ messages in thread
From: Richard Purdie @ 2013-04-15 11:07 UTC (permalink / raw)
  To: openembedded-core

Currently the names used for the kernel in deploy will contain "AUTOREV"
instead of the final incremental numbering. This fixes the problem by
ensuring data is obtained from the PR service and using the PKG* variables
instead of PE/PV/PR directly.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes/kernel.bbclass |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 8c8c95b..00e27ef 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -200,6 +200,7 @@ kernel_do_install() {
 		sed -i 's#-I/usr/include/slang#-I=/usr/include/slang#g' $kerneldir/tools/perf/Makefile
 	fi
 }
+do_install[prefuncs] += "package_get_auto_pr"
 
 sysroot_stage_all_append() {
 	sysroot_stage_dir ${D}${KERNEL_SRC_PATH} ${SYSROOT_DESTDIR}${KERNEL_SRC_PATH}
@@ -333,11 +334,11 @@ do_sizecheck[dirs] = "${B}"
 
 addtask sizecheck before do_install after do_strip
 
-KERNEL_IMAGE_BASE_NAME ?= "${KERNEL_IMAGETYPE}-${PE}-${PV}-${PR}-${MACHINE}-${DATETIME}"
+KERNEL_IMAGE_BASE_NAME ?= "${KERNEL_IMAGETYPE}-${PKGE}-${PKGV}-${PKGR}-${MACHINE}-${DATETIME}"
 # Don't include the DATETIME variable in the sstate package signatures
 KERNEL_IMAGE_BASE_NAME[vardepsexclude] = "DATETIME"
 KERNEL_IMAGE_SYMLINK_NAME ?= "${KERNEL_IMAGETYPE}-${MACHINE}"
-MODULE_IMAGE_BASE_NAME ?= "modules-${PE}-${PV}-${PR}-${MACHINE}-${DATETIME}"
+MODULE_IMAGE_BASE_NAME ?= "modules-${PKGE}-${PKGV}-${PKGR}-${MACHINE}-${DATETIME}"
 MODULE_IMAGE_BASE_NAME[vardepsexclude] = "DATETIME"
 MODULE_TARBALL_BASE_NAME ?= "${MODULE_IMAGE_BASE_NAME}.tgz"
 # Don't include the DATETIME variable in the sstate package signatures
@@ -386,6 +387,7 @@ kernel_do_deploy() {
 	cd -
 }
 do_deploy[dirs] = "${DEPLOYDIR} ${B}"
+do_deploy[prefuncs] += "package_get_auto_pr"
 
 addtask deploy before do_build after do_install
 
-- 
1.7.10.4




^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH] recipes: Fix ALLOW_EMPTY with no package specified
  2013-04-15 11:07 [PATCH 1/7] kernel.bbclass: Ensure we have correct version information in deploy data Richard Purdie
@ 2013-04-15 11:07 ` Richard Purdie
  2013-04-15 11:43   ` Martin Jansa
  2013-04-15 11:07 ` [PATCH 2/7] update-alternatives: Ensure DEPENDS is correct in multilib case Richard Purdie
                   ` (6 subsequent siblings)
  7 siblings, 1 reply; 17+ messages in thread
From: Richard Purdie @ 2013-04-15 11:07 UTC (permalink / raw)
  To: openembedded-core

There are various usages of ALLOW_EMPTY with no packages specified. This
is not recommended syntax, nor is it likely to be supported in the future.
This patch improves the references in OE-Core, either removing them if they're
pointless (e.g. when PACKAGES="") or specifying which package it applies to.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-connectivity/openssl/ocf-linux.inc           |    2 +-
 meta/recipes-core/meta/package-index.bb                   |    1 -
 meta/recipes-devtools/installer/adt-installer_1.0.bb      |    2 --
 meta/recipes-extended/psmisc/psmisc.inc                   |    2 +-
 meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb   |    6 +++++-
 meta/recipes-multimedia/gstreamer/gst-plugins-package.inc |    2 --
 6 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/meta/recipes-connectivity/openssl/ocf-linux.inc b/meta/recipes-connectivity/openssl/ocf-linux.inc
index dba1f02..4efdc2f 100644
--- a/meta/recipes-connectivity/openssl/ocf-linux.inc
+++ b/meta/recipes-connectivity/openssl/ocf-linux.inc
@@ -20,5 +20,5 @@ do_install() {
     install -m 0644 ${S}/ocf/*.h ${D}${includedir}/crypto/
 }
 
-ALLOW_EMPTY = "1"
+ALLOW_EMPTY_${PN} = "1"
 BBCLASSEXTEND = "native nativesdk"
diff --git a/meta/recipes-core/meta/package-index.bb b/meta/recipes-core/meta/package-index.bb
index 99ac1a8..76bf331 100644
--- a/meta/recipes-core/meta/package-index.bb
+++ b/meta/recipes-core/meta/package-index.bb
@@ -2,7 +2,6 @@ DESCRIPTION = "Rebuild the package index"
 LICENSE = "MIT"
 
 INHIBIT_DEFAULT_DEPS = "1"
-ALLOW_EMPTY = "1"
 PACKAGES = ""
 
 do_fetch[noexec] = "1"
diff --git a/meta/recipes-devtools/installer/adt-installer_1.0.bb b/meta/recipes-devtools/installer/adt-installer_1.0.bb
index 227e866..0cc3b33 100644
--- a/meta/recipes-devtools/installer/adt-installer_1.0.bb
+++ b/meta/recipes-devtools/installer/adt-installer_1.0.bb
@@ -26,8 +26,6 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3
                     file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
 LICENSE = "MIT"
 
-ALLOW_EMPTY = "1"
-
 PACKAGES = ""
 
 PR = "r11"
diff --git a/meta/recipes-extended/psmisc/psmisc.inc b/meta/recipes-extended/psmisc/psmisc.inc
index 76af99e..68e0656 100644
--- a/meta/recipes-extended/psmisc/psmisc.inc
+++ b/meta/recipes-extended/psmisc/psmisc.inc
@@ -15,7 +15,7 @@ S = "${WORKDIR}/psmisc-${PV}"
 
 inherit autotools gettext
 
-ALLOW_EMPTY = "1"
+ALLOW_EMPTY_${PN} = "1"
 
 PACKAGES =+ "fuser fuser-doc killall killall-doc pstree pstree-doc"
 PACKAGES += "psmisc-extras"
diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
index 37c70c2..210da37 100644
--- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
+++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
@@ -14,7 +14,11 @@ PACKAGES = "\
     gst-meta-debug \
     gst-meta-video"
 
-ALLOW_EMPTY = "1"
+ALLOW_EMPTY_gst-meta-base = "1"
+ALLOW_EMPTY_gst-meta-x11-base = "1"
+ALLOW_EMPTY_gst-meta-audio = "1"
+ALLOW_EMPTY_gst-meta-debug = "1"
+ALLOW_EMPTY_gst-meta-video = "1"
 
 RDEPENDS_gst-meta-base = "\
     ${@base_contains('DISTRO_FEATURES', 'x11', 'gst-meta-x11-base', '', d)} \
diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
index f26aca5..3e9ef92 100644
--- a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
+++ b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
@@ -24,8 +24,6 @@ python populate_packages_prepend () {
     d.setVar('DESCRIPTION_' + metapkg, pn + ' meta package')
 }
 
-ALLOW_EMPTY = "1"
-
 PACKAGES += "${PN}-apps ${PN}-meta ${PN}-glib"
 FILES_${PN}-apps = "${bindir}"
 
-- 
1.7.10.4




^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 2/7] update-alternatives: Ensure DEPENDS is correct in multilib case
  2013-04-15 11:07 [PATCH 1/7] kernel.bbclass: Ensure we have correct version information in deploy data Richard Purdie
  2013-04-15 11:07 ` [PATCH] recipes: Fix ALLOW_EMPTY with no package specified Richard Purdie
@ 2013-04-15 11:07 ` Richard Purdie
  2013-04-15 11:07 ` [PATCH 3/7] ttf-bitstream-vera: Use fontcache class for postinstall Richard Purdie
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 17+ messages in thread
From: Richard Purdie @ 2013-04-15 11:07 UTC (permalink / raw)
  To: openembedded-core

Ensure that the DEPENDS we're adding is correct in the multilib case by
including MLPREFIX, fixing unnecessary dependencies in those images.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes/update-alternatives.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/update-alternatives.bbclass b/meta/classes/update-alternatives.bbclass
index f7ad4d4..45f4291 100644
--- a/meta/classes/update-alternatives.bbclass
+++ b/meta/classes/update-alternatives.bbclass
@@ -169,7 +169,7 @@ def gen_updatealternativesvardeps(d):
 
 def ua_extend_depends(d):
     if not 'virtual/update-alternatives' in d.getVar('PROVIDES', True):
-        d.appendVar('DEPENDS', ' virtual/update-alternatives')
+        d.appendVar('DEPENDS', ' virtual/${MLPREFIX}update-alternatives')
 
 python __anonymous() {
     # Update Alternatives only works on target packages...
-- 
1.7.10.4




^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 3/7] ttf-bitstream-vera: Use fontcache class for postinstall
  2013-04-15 11:07 [PATCH 1/7] kernel.bbclass: Ensure we have correct version information in deploy data Richard Purdie
  2013-04-15 11:07 ` [PATCH] recipes: Fix ALLOW_EMPTY with no package specified Richard Purdie
  2013-04-15 11:07 ` [PATCH 2/7] update-alternatives: Ensure DEPENDS is correct in multilib case Richard Purdie
@ 2013-04-15 11:07 ` Richard Purdie
  2013-04-15 11:07 ` [PATCH 4/7] encodings: Set RDEPENDS correctly Richard Purdie
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 17+ messages in thread
From: Richard Purdie @ 2013-04-15 11:07 UTC (permalink / raw)
  To: openembedded-core

Using the fontcache class means we can run the postinstall at build time
so this is generally more efficient.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-graphics/ttf-fonts/ttf-bitstream-vera_1.10.bb |   10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/meta/recipes-graphics/ttf-fonts/ttf-bitstream-vera_1.10.bb b/meta/recipes-graphics/ttf-fonts/ttf-bitstream-vera_1.10.bb
index 71e85e4..ccd865c 100644
--- a/meta/recipes-graphics/ttf-fonts/ttf-bitstream-vera_1.10.bb
+++ b/meta/recipes-graphics/ttf-fonts/ttf-bitstream-vera_1.10.bb
@@ -10,7 +10,9 @@ LIC_FILES_CHKSUM = "file://COPYRIGHT.TXT;md5=27d7484b1e18d0ee4ce538644a3f04be"
 PR = "r7"
 RDEPENDS_${PN} = "fontconfig-utils"
 
-inherit allarch
+inherit allarch fontcache
+
+FONT_PACKAGES = "${PN}"
 
 SRC_URI = "${GNOME_MIRROR}/ttf-bitstream-vera/1.10/ttf-bitstream-vera-${PV}.tar.bz2" 
 
@@ -31,12 +33,6 @@ do_install () {
         done 
 } 
 
-pkg_postinst_${PN} () {
-#!/bin/sh
-fc-cache
-}
-
-
 FILES_${PN} = "/etc ${datadir}/fonts"
 
 SRC_URI[md5sum] = "bb22bd5b4675f5dbe17c6963d8c00ed6"
-- 
1.7.10.4




^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 4/7] encodings: Set RDEPENDS correctly
  2013-04-15 11:07 [PATCH 1/7] kernel.bbclass: Ensure we have correct version information in deploy data Richard Purdie
                   ` (2 preceding siblings ...)
  2013-04-15 11:07 ` [PATCH 3/7] ttf-bitstream-vera: Use fontcache class for postinstall Richard Purdie
@ 2013-04-15 11:07 ` Richard Purdie
  2013-04-15 11:07 ` [PATCH 5/7] qemuwrapper-cross: Inhibit default dependencies Richard Purdie
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 17+ messages in thread
From: Richard Purdie @ 2013-04-15 11:07 UTC (permalink / raw)
  To: openembedded-core

The .inc file sets RDEPENDS for the general font case but the dependencies
don't apply to this recipe. This removes those dependencies, simplifying the
dependency chains a little.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-graphics/xorg-font/encodings_1.0.4.bb |    1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-graphics/xorg-font/encodings_1.0.4.bb b/meta/recipes-graphics/xorg-font/encodings_1.0.4.bb
index cf7b3e3..90846d8 100644
--- a/meta/recipes-graphics/xorg-font/encodings_1.0.4.bb
+++ b/meta/recipes-graphics/xorg-font/encodings_1.0.4.bb
@@ -10,6 +10,7 @@ PE = "1"
 PR = "${INC_PR}.1"
 
 DEPENDS = "mkfontscale-native font-util-native"
+RDEPENDS_${PN} = ""
 
 SRC_URI += "file://nocompiler.patch"
 
-- 
1.7.10.4




^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 5/7] qemuwrapper-cross: Inhibit default dependencies
  2013-04-15 11:07 [PATCH 1/7] kernel.bbclass: Ensure we have correct version information in deploy data Richard Purdie
                   ` (3 preceding siblings ...)
  2013-04-15 11:07 ` [PATCH 4/7] encodings: Set RDEPENDS correctly Richard Purdie
@ 2013-04-15 11:07 ` Richard Purdie
  2013-04-15 11:07 ` [PATCH 6/7] nfs-export-root: Update to use packagegroup naming Richard Purdie
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 17+ messages in thread
From: Richard Purdie @ 2013-04-15 11:07 UTC (permalink / raw)
  To: openembedded-core

This wrapper script doesn't need a compile or any of the default system
dependencies so lets inhibit them. This also stops the script
being rebuild every time the toolchain changes.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-devtools/qemu/qemuwrapper-cross_1.0.bb |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-devtools/qemu/qemuwrapper-cross_1.0.bb b/meta/recipes-devtools/qemu/qemuwrapper-cross_1.0.bb
index f23a7d7..41617a6 100644
--- a/meta/recipes-devtools/qemu/qemuwrapper-cross_1.0.bb
+++ b/meta/recipes-devtools/qemu/qemuwrapper-cross_1.0.bb
@@ -18,3 +18,5 @@ SYSROOT_PREPROCESS_FUNCS += "qemuwrapper_sysroot_preprocess"
 qemuwrapper_sysroot_preprocess () {
 	sysroot_stage_dir ${D}${bindir_crossscripts} ${SYSROOT_DESTDIR}${bindir_crossscripts}
 }
+
+INHIBIT_DEFAULT_DEPS = "1"
-- 
1.7.10.4




^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 6/7] nfs-export-root: Update to use packagegroup naming
  2013-04-15 11:07 [PATCH 1/7] kernel.bbclass: Ensure we have correct version information in deploy data Richard Purdie
                   ` (4 preceding siblings ...)
  2013-04-15 11:07 ` [PATCH 5/7] qemuwrapper-cross: Inhibit default dependencies Richard Purdie
@ 2013-04-15 11:07 ` Richard Purdie
  2013-04-15 11:07 ` [PATCH 7/7] allarch: Drop various problematic allarch usages Richard Purdie
  2013-04-15 11:38 ` [PATCH 1/7] kernel.bbclass: Ensure we have correct version information in deploy data Martin Jansa
  7 siblings, 0 replies; 17+ messages in thread
From: Richard Purdie @ 2013-04-15 11:07 UTC (permalink / raw)
  To: openembedded-core

task packages were renamed to use packagegroup so fix this reference.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-devtools/devel-config/nfs-export-root.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/devel-config/nfs-export-root.bb b/meta/recipes-devtools/devel-config/nfs-export-root.bb
index fff60ca..4d9f6dd 100644
--- a/meta/recipes-devtools/devel-config/nfs-export-root.bb
+++ b/meta/recipes-devtools/devel-config/nfs-export-root.bb
@@ -14,6 +14,6 @@ do_install() {
 	install -m 0644 exports ${D}${sysconfdir}/
 }
 
-RDEPENDS_${PN} = "task-core-nfs-server"
+RDEPENDS_${PN} = "packagegroup-core-nfs-server"
 
 inherit allarch
-- 
1.7.10.4




^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH 7/7] allarch: Drop various problematic allarch usages
  2013-04-15 11:07 [PATCH 1/7] kernel.bbclass: Ensure we have correct version information in deploy data Richard Purdie
                   ` (5 preceding siblings ...)
  2013-04-15 11:07 ` [PATCH 6/7] nfs-export-root: Update to use packagegroup naming Richard Purdie
@ 2013-04-15 11:07 ` Richard Purdie
  2013-04-15 15:16   ` Mark Hatle
  2013-04-15 11:38 ` [PATCH 1/7] kernel.bbclass: Ensure we have correct version information in deploy data Martin Jansa
  7 siblings, 1 reply; 17+ messages in thread
From: Richard Purdie @ 2013-04-15 11:07 UTC (permalink / raw)
  To: openembedded-core

In each of these cases allarch is used where the package in question has a
dependency on things which are not allach and change when MACHINE is changed.

This leads to a rebuild of the package each time MACHINE is switched and
the sstate checksum changes. The dependencies in question are not suited
be being marked as ABISAFE.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-core/udev/udev-extraconf_1.0.bb               |    2 --
 meta/recipes-devtools/devel-config/anjuta-remote-run.bb    |    2 --
 meta/recipes-devtools/devel-config/distcc-config.bb        |    2 --
 meta/recipes-devtools/devel-config/nfs-export-root.bb      |    2 --
 meta/recipes-graphics/ttf-fonts/liberation-fonts_1.04.bb   |    2 +-
 meta/recipes-graphics/ttf-fonts/ttf-bitstream-vera_1.10.bb |    2 +-
 meta/recipes-graphics/x11-common/x11-common_0.1.bb         |    2 --
 7 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/meta/recipes-core/udev/udev-extraconf_1.0.bb b/meta/recipes-core/udev/udev-extraconf_1.0.bb
index ea95a60..fd9a333 100644
--- a/meta/recipes-core/udev/udev-extraconf_1.0.bb
+++ b/meta/recipes-core/udev/udev-extraconf_1.0.bb
@@ -4,8 +4,6 @@ LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
                     file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
 
-inherit allarch
-
 PR = "r8"
 
 SRC_URI = " \
diff --git a/meta/recipes-devtools/devel-config/anjuta-remote-run.bb b/meta/recipes-devtools/devel-config/anjuta-remote-run.bb
index 51fdf9e..b9cded7 100644
--- a/meta/recipes-devtools/devel-config/anjuta-remote-run.bb
+++ b/meta/recipes-devtools/devel-config/anjuta-remote-run.bb
@@ -15,5 +15,3 @@ do_install() {
 PACKAGES = "${PN}"
 RDEPENDS_${PN} = "dbus rsync"
 
-inherit allarch
-
diff --git a/meta/recipes-devtools/devel-config/distcc-config.bb b/meta/recipes-devtools/devel-config/distcc-config.bb
index 8deaa66..c9c024d 100644
--- a/meta/recipes-devtools/devel-config/distcc-config.bb
+++ b/meta/recipes-devtools/devel-config/distcc-config.bb
@@ -21,5 +21,3 @@ do_install() {
 }
 
 RDEPENDS_${PN} = "distcc"
-
-inherit allarch
diff --git a/meta/recipes-devtools/devel-config/nfs-export-root.bb b/meta/recipes-devtools/devel-config/nfs-export-root.bb
index 4d9f6dd..5fa8cb3 100644
--- a/meta/recipes-devtools/devel-config/nfs-export-root.bb
+++ b/meta/recipes-devtools/devel-config/nfs-export-root.bb
@@ -15,5 +15,3 @@ do_install() {
 }
 
 RDEPENDS_${PN} = "packagegroup-core-nfs-server"
-
-inherit allarch
diff --git a/meta/recipes-graphics/ttf-fonts/liberation-fonts_1.04.bb b/meta/recipes-graphics/ttf-fonts/liberation-fonts_1.04.bb
index a34825a..c99521f 100644
--- a/meta/recipes-graphics/ttf-fonts/liberation-fonts_1.04.bb
+++ b/meta/recipes-graphics/ttf-fonts/liberation-fonts_1.04.bb
@@ -12,7 +12,7 @@ RDEPENDS_${PN} = "fontconfig-utils"
 PR = "r4"
 PE = "1"
 
-inherit allarch fontcache
+inherit fontcache
 
 FONT_PACKAGES = "${PN}"
 
diff --git a/meta/recipes-graphics/ttf-fonts/ttf-bitstream-vera_1.10.bb b/meta/recipes-graphics/ttf-fonts/ttf-bitstream-vera_1.10.bb
index ccd865c..75f78a2 100644
--- a/meta/recipes-graphics/ttf-fonts/ttf-bitstream-vera_1.10.bb
+++ b/meta/recipes-graphics/ttf-fonts/ttf-bitstream-vera_1.10.bb
@@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = "file://COPYRIGHT.TXT;md5=27d7484b1e18d0ee4ce538644a3f04be"
 PR = "r7"
 RDEPENDS_${PN} = "fontconfig-utils"
 
-inherit allarch fontcache
+inherit fontcache
 
 FONT_PACKAGES = "${PN}"
 
diff --git a/meta/recipes-graphics/x11-common/x11-common_0.1.bb b/meta/recipes-graphics/x11-common/x11-common_0.1.bb
index 49de5a3..2df1347 100644
--- a/meta/recipes-graphics/x11-common/x11-common_0.1.bb
+++ b/meta/recipes-graphics/x11-common/x11-common_0.1.bb
@@ -9,8 +9,6 @@ SRC_URI = "file://etc \
 
 S = "${WORKDIR}"
 
-inherit allarch
-
 do_install() {
 	cp -R ${S}/etc ${D}${sysconfdir}
 	chmod -R 755 ${D}${sysconfdir}
-- 
1.7.10.4




^ permalink raw reply related	[flat|nested] 17+ messages in thread

* Re: [PATCH 1/7] kernel.bbclass: Ensure we have correct version information in deploy data
  2013-04-15 11:07 [PATCH 1/7] kernel.bbclass: Ensure we have correct version information in deploy data Richard Purdie
                   ` (6 preceding siblings ...)
  2013-04-15 11:07 ` [PATCH 7/7] allarch: Drop various problematic allarch usages Richard Purdie
@ 2013-04-15 11:38 ` Martin Jansa
  2013-04-15 14:46   ` Richard Purdie
  7 siblings, 1 reply; 17+ messages in thread
From: Martin Jansa @ 2013-04-15 11:38 UTC (permalink / raw)
  To: Richard Purdie; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 2416 bytes --]

On Mon, Apr 15, 2013 at 12:07:01PM +0100, Richard Purdie wrote:
> Currently the names used for the kernel in deploy will contain "AUTOREV"

Here it shows "AUTOINC"

> instead of the final incremental numbering. This fixes the problem by
> ensuring data is obtained from the PR service and using the PKG* variables
> instead of PE/PV/PR directly.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/classes/kernel.bbclass |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 8c8c95b..00e27ef 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -200,6 +200,7 @@ kernel_do_install() {
>  		sed -i 's#-I/usr/include/slang#-I=/usr/include/slang#g' $kerneldir/tools/perf/Makefile
>  	fi
>  }
> +do_install[prefuncs] += "package_get_auto_pr"
>  
>  sysroot_stage_all_append() {
>  	sysroot_stage_dir ${D}${KERNEL_SRC_PATH} ${SYSROOT_DESTDIR}${KERNEL_SRC_PATH}
> @@ -333,11 +334,11 @@ do_sizecheck[dirs] = "${B}"
>  
>  addtask sizecheck before do_install after do_strip
>  
> -KERNEL_IMAGE_BASE_NAME ?= "${KERNEL_IMAGETYPE}-${PE}-${PV}-${PR}-${MACHINE}-${DATETIME}"
> +KERNEL_IMAGE_BASE_NAME ?= "${KERNEL_IMAGETYPE}-${PKGE}-${PKGV}-${PKGR}-${MACHINE}-${DATETIME}"
>  # Don't include the DATETIME variable in the sstate package signatures
>  KERNEL_IMAGE_BASE_NAME[vardepsexclude] = "DATETIME"
>  KERNEL_IMAGE_SYMLINK_NAME ?= "${KERNEL_IMAGETYPE}-${MACHINE}"
> -MODULE_IMAGE_BASE_NAME ?= "modules-${PE}-${PV}-${PR}-${MACHINE}-${DATETIME}"
> +MODULE_IMAGE_BASE_NAME ?= "modules-${PKGE}-${PKGV}-${PKGR}-${MACHINE}-${DATETIME}"
>  MODULE_IMAGE_BASE_NAME[vardepsexclude] = "DATETIME"
>  MODULE_TARBALL_BASE_NAME ?= "${MODULE_IMAGE_BASE_NAME}.tgz"
>  # Don't include the DATETIME variable in the sstate package signatures
> @@ -386,6 +387,7 @@ kernel_do_deploy() {
>  	cd -
>  }
>  do_deploy[dirs] = "${DEPLOYDIR} ${B}"
> +do_deploy[prefuncs] += "package_get_auto_pr"
>  
>  addtask deploy before do_build after do_install
>  
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH] recipes: Fix ALLOW_EMPTY with no package specified
  2013-04-15 11:07 ` [PATCH] recipes: Fix ALLOW_EMPTY with no package specified Richard Purdie
@ 2013-04-15 11:43   ` Martin Jansa
  2013-04-15 12:06     ` Richard Purdie
  0 siblings, 1 reply; 17+ messages in thread
From: Martin Jansa @ 2013-04-15 11:43 UTC (permalink / raw)
  To: Richard Purdie; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 4572 bytes --]

On Mon, Apr 15, 2013 at 12:07:02PM +0100, Richard Purdie wrote:
> There are various usages of ALLOW_EMPTY with no packages specified. This
> is not recommended syntax, nor is it likely to be supported in the future.
> This patch improves the references in OE-Core, either removing them if they're
> pointless (e.g. when PACKAGES="") or specifying which package it applies to.

Was this one sent by accident?

http://git.openembedded.org/openembedded-core/commit/?id=fe81bd4f600877e63433184cfc2e22c33bb77db6

> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/recipes-connectivity/openssl/ocf-linux.inc           |    2 +-
>  meta/recipes-core/meta/package-index.bb                   |    1 -
>  meta/recipes-devtools/installer/adt-installer_1.0.bb      |    2 --
>  meta/recipes-extended/psmisc/psmisc.inc                   |    2 +-
>  meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb   |    6 +++++-
>  meta/recipes-multimedia/gstreamer/gst-plugins-package.inc |    2 --
>  6 files changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/meta/recipes-connectivity/openssl/ocf-linux.inc b/meta/recipes-connectivity/openssl/ocf-linux.inc
> index dba1f02..4efdc2f 100644
> --- a/meta/recipes-connectivity/openssl/ocf-linux.inc
> +++ b/meta/recipes-connectivity/openssl/ocf-linux.inc
> @@ -20,5 +20,5 @@ do_install() {
>      install -m 0644 ${S}/ocf/*.h ${D}${includedir}/crypto/
>  }
>  
> -ALLOW_EMPTY = "1"
> +ALLOW_EMPTY_${PN} = "1"
>  BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta/recipes-core/meta/package-index.bb b/meta/recipes-core/meta/package-index.bb
> index 99ac1a8..76bf331 100644
> --- a/meta/recipes-core/meta/package-index.bb
> +++ b/meta/recipes-core/meta/package-index.bb
> @@ -2,7 +2,6 @@ DESCRIPTION = "Rebuild the package index"
>  LICENSE = "MIT"
>  
>  INHIBIT_DEFAULT_DEPS = "1"
> -ALLOW_EMPTY = "1"
>  PACKAGES = ""
>  
>  do_fetch[noexec] = "1"
> diff --git a/meta/recipes-devtools/installer/adt-installer_1.0.bb b/meta/recipes-devtools/installer/adt-installer_1.0.bb
> index 227e866..0cc3b33 100644
> --- a/meta/recipes-devtools/installer/adt-installer_1.0.bb
> +++ b/meta/recipes-devtools/installer/adt-installer_1.0.bb
> @@ -26,8 +26,6 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3
>                      file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>  LICENSE = "MIT"
>  
> -ALLOW_EMPTY = "1"
> -
>  PACKAGES = ""
>  
>  PR = "r11"
> diff --git a/meta/recipes-extended/psmisc/psmisc.inc b/meta/recipes-extended/psmisc/psmisc.inc
> index 76af99e..68e0656 100644
> --- a/meta/recipes-extended/psmisc/psmisc.inc
> +++ b/meta/recipes-extended/psmisc/psmisc.inc
> @@ -15,7 +15,7 @@ S = "${WORKDIR}/psmisc-${PV}"
>  
>  inherit autotools gettext
>  
> -ALLOW_EMPTY = "1"
> +ALLOW_EMPTY_${PN} = "1"
>  
>  PACKAGES =+ "fuser fuser-doc killall killall-doc pstree pstree-doc"
>  PACKAGES += "psmisc-extras"
> diff --git a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> index 37c70c2..210da37 100644
> --- a/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> +++ b/meta/recipes-multimedia/gstreamer/gst-meta-base_0.10.bb
> @@ -14,7 +14,11 @@ PACKAGES = "\
>      gst-meta-debug \
>      gst-meta-video"
>  
> -ALLOW_EMPTY = "1"
> +ALLOW_EMPTY_gst-meta-base = "1"
> +ALLOW_EMPTY_gst-meta-x11-base = "1"
> +ALLOW_EMPTY_gst-meta-audio = "1"
> +ALLOW_EMPTY_gst-meta-debug = "1"
> +ALLOW_EMPTY_gst-meta-video = "1"
>  
>  RDEPENDS_gst-meta-base = "\
>      ${@base_contains('DISTRO_FEATURES', 'x11', 'gst-meta-x11-base', '', d)} \
> diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
> index f26aca5..3e9ef92 100644
> --- a/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
> +++ b/meta/recipes-multimedia/gstreamer/gst-plugins-package.inc
> @@ -24,8 +24,6 @@ python populate_packages_prepend () {
>      d.setVar('DESCRIPTION_' + metapkg, pn + ' meta package')
>  }
>  
> -ALLOW_EMPTY = "1"
> -
>  PACKAGES += "${PN}-apps ${PN}-meta ${PN}-glib"
>  FILES_${PN}-apps = "${bindir}"
>  
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH] recipes: Fix ALLOW_EMPTY with no package specified
  2013-04-15 11:43   ` Martin Jansa
@ 2013-04-15 12:06     ` Richard Purdie
  0 siblings, 0 replies; 17+ messages in thread
From: Richard Purdie @ 2013-04-15 12:06 UTC (permalink / raw)
  To: Martin Jansa; +Cc: openembedded-core

On Mon, 2013-04-15 at 13:43 +0200, Martin Jansa wrote:
> On Mon, Apr 15, 2013 at 12:07:02PM +0100, Richard Purdie wrote:
> > There are various usages of ALLOW_EMPTY with no packages specified. This
> > is not recommended syntax, nor is it likely to be supported in the future.
> > This patch improves the references in OE-Core, either removing them if they're
> > pointless (e.g. when PACKAGES="") or specifying which package it applies to.
> 
> Was this one sent by accident?
> 
> http://git.openembedded.org/openembedded-core/commit/?id=fe81bd4f600877e63433184cfc2e22c33bb77db6

Yes, sent by accident, sorry about the noise.

Cheers,

Richard




^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 1/7] kernel.bbclass: Ensure we have correct version information in deploy data
  2013-04-15 11:38 ` [PATCH 1/7] kernel.bbclass: Ensure we have correct version information in deploy data Martin Jansa
@ 2013-04-15 14:46   ` Richard Purdie
  0 siblings, 0 replies; 17+ messages in thread
From: Richard Purdie @ 2013-04-15 14:46 UTC (permalink / raw)
  To: Martin Jansa; +Cc: openembedded-core

On Mon, 2013-04-15 at 13:38 +0200, Martin Jansa wrote:
> On Mon, Apr 15, 2013 at 12:07:01PM +0100, Richard Purdie wrote:
> > Currently the names used for the kernel in deploy will contain "AUTOREV"
> 
> Here it shows "AUTOINC"

It should say AUTOINC in the commit message too...

Cheers,

Richard




^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 7/7] allarch: Drop various problematic allarch usages
  2013-04-15 11:07 ` [PATCH 7/7] allarch: Drop various problematic allarch usages Richard Purdie
@ 2013-04-15 15:16   ` Mark Hatle
  2013-04-15 15:40     ` Richard Purdie
  0 siblings, 1 reply; 17+ messages in thread
From: Mark Hatle @ 2013-04-15 15:16 UTC (permalink / raw)
  To: openembedded-core

On 4/15/13 6:07 AM, Richard Purdie wrote:
> In each of these cases allarch is used where the package in question has a
> dependency on things which are not allach and change when MACHINE is changed.
>
> This leads to a rebuild of the package each time MACHINE is switched and
> the sstate checksum changes. The dependencies in question are not suited
> be being marked as ABISAFE.

In each of these cases, does the contents of the package change when the MACHINE 
(or something in that machine) are modified?  If so, I agree they are definitely 
not allarch.

However, if the dependency really doesn't matter, then why isn't ABISAFE correct 
in each case?

--Mark

> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>   meta/recipes-core/udev/udev-extraconf_1.0.bb               |    2 --
>   meta/recipes-devtools/devel-config/anjuta-remote-run.bb    |    2 --
>   meta/recipes-devtools/devel-config/distcc-config.bb        |    2 --
>   meta/recipes-devtools/devel-config/nfs-export-root.bb      |    2 --
>   meta/recipes-graphics/ttf-fonts/liberation-fonts_1.04.bb   |    2 +-
>   meta/recipes-graphics/ttf-fonts/ttf-bitstream-vera_1.10.bb |    2 +-
>   meta/recipes-graphics/x11-common/x11-common_0.1.bb         |    2 --
>   7 files changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/meta/recipes-core/udev/udev-extraconf_1.0.bb b/meta/recipes-core/udev/udev-extraconf_1.0.bb
> index ea95a60..fd9a333 100644
> --- a/meta/recipes-core/udev/udev-extraconf_1.0.bb
> +++ b/meta/recipes-core/udev/udev-extraconf_1.0.bb
> @@ -4,8 +4,6 @@ LICENSE = "MIT"
>   LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>                       file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>
> -inherit allarch
> -
>   PR = "r8"
>
>   SRC_URI = " \
> diff --git a/meta/recipes-devtools/devel-config/anjuta-remote-run.bb b/meta/recipes-devtools/devel-config/anjuta-remote-run.bb
> index 51fdf9e..b9cded7 100644
> --- a/meta/recipes-devtools/devel-config/anjuta-remote-run.bb
> +++ b/meta/recipes-devtools/devel-config/anjuta-remote-run.bb
> @@ -15,5 +15,3 @@ do_install() {
>   PACKAGES = "${PN}"
>   RDEPENDS_${PN} = "dbus rsync"
>
> -inherit allarch
> -
> diff --git a/meta/recipes-devtools/devel-config/distcc-config.bb b/meta/recipes-devtools/devel-config/distcc-config.bb
> index 8deaa66..c9c024d 100644
> --- a/meta/recipes-devtools/devel-config/distcc-config.bb
> +++ b/meta/recipes-devtools/devel-config/distcc-config.bb
> @@ -21,5 +21,3 @@ do_install() {
>   }
>
>   RDEPENDS_${PN} = "distcc"
> -
> -inherit allarch
> diff --git a/meta/recipes-devtools/devel-config/nfs-export-root.bb b/meta/recipes-devtools/devel-config/nfs-export-root.bb
> index 4d9f6dd..5fa8cb3 100644
> --- a/meta/recipes-devtools/devel-config/nfs-export-root.bb
> +++ b/meta/recipes-devtools/devel-config/nfs-export-root.bb
> @@ -15,5 +15,3 @@ do_install() {
>   }
>
>   RDEPENDS_${PN} = "packagegroup-core-nfs-server"
> -
> -inherit allarch
> diff --git a/meta/recipes-graphics/ttf-fonts/liberation-fonts_1.04.bb b/meta/recipes-graphics/ttf-fonts/liberation-fonts_1.04.bb
> index a34825a..c99521f 100644
> --- a/meta/recipes-graphics/ttf-fonts/liberation-fonts_1.04.bb
> +++ b/meta/recipes-graphics/ttf-fonts/liberation-fonts_1.04.bb
> @@ -12,7 +12,7 @@ RDEPENDS_${PN} = "fontconfig-utils"
>   PR = "r4"
>   PE = "1"
>
> -inherit allarch fontcache
> +inherit fontcache
>
>   FONT_PACKAGES = "${PN}"
>
> diff --git a/meta/recipes-graphics/ttf-fonts/ttf-bitstream-vera_1.10.bb b/meta/recipes-graphics/ttf-fonts/ttf-bitstream-vera_1.10.bb
> index ccd865c..75f78a2 100644
> --- a/meta/recipes-graphics/ttf-fonts/ttf-bitstream-vera_1.10.bb
> +++ b/meta/recipes-graphics/ttf-fonts/ttf-bitstream-vera_1.10.bb
> @@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = "file://COPYRIGHT.TXT;md5=27d7484b1e18d0ee4ce538644a3f04be"
>   PR = "r7"
>   RDEPENDS_${PN} = "fontconfig-utils"
>
> -inherit allarch fontcache
> +inherit fontcache
>
>   FONT_PACKAGES = "${PN}"
>
> diff --git a/meta/recipes-graphics/x11-common/x11-common_0.1.bb b/meta/recipes-graphics/x11-common/x11-common_0.1.bb
> index 49de5a3..2df1347 100644
> --- a/meta/recipes-graphics/x11-common/x11-common_0.1.bb
> +++ b/meta/recipes-graphics/x11-common/x11-common_0.1.bb
> @@ -9,8 +9,6 @@ SRC_URI = "file://etc \
>
>   S = "${WORKDIR}"
>
> -inherit allarch
> -
>   do_install() {
>   	cp -R ${S}/etc ${D}${sysconfdir}
>   	chmod -R 755 ${D}${sysconfdir}
>




^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 7/7] allarch: Drop various problematic allarch usages
  2013-04-15 15:16   ` Mark Hatle
@ 2013-04-15 15:40     ` Richard Purdie
  2013-04-15 15:49       ` Mark Hatle
  0 siblings, 1 reply; 17+ messages in thread
From: Richard Purdie @ 2013-04-15 15:40 UTC (permalink / raw)
  To: Mark Hatle; +Cc: openembedded-core

On Mon, 2013-04-15 at 10:16 -0500, Mark Hatle wrote:
> On 4/15/13 6:07 AM, Richard Purdie wrote:
> > In each of these cases allarch is used where the package in question has a
> > dependency on things which are not allach and change when MACHINE is changed.
> >
> > This leads to a rebuild of the package each time MACHINE is switched and
> > the sstate checksum changes. The dependencies in question are not suited
> > be being marked as ABISAFE.
> 
> In each of these cases, does the contents of the package change when the MACHINE 
> (or something in that machine) are modified?  If so, I agree they are definitely 
> not allarch.

The contents does not, the sstate checksum however does due to the
dependencies. The dependencies are thinks like gtk+ and dbus.

> However, if the dependency really doesn't matter, then why isn't ABISAFE correct 
> in each case?

I'm using ABISAFE in this context as shorthand for
SIGGEN_EXCLUDERECIPES_ABISAFE and those are defined as things which
don't need to rebuild if the dependency changes.

gtk+ and dbus both provide libraries and we do want software to rebuild
if they change. In the allarch case we could whitelist the dependency
however in the general case we shouldn't.

Even with that problem addressed somehow, it leaves an issue with ipk
multilibs where the distcc-config allarch recipe would always depend
upon "distcc" and hence distcc would get pulled into the image,
regardless of any other multilib settings (which in turn pulls in gtk+
for example). A "lib64-xxx-image" would therefore end up with near
enough two copies of half the system due to this. This is something we
really need to fix in the opkg implementation of multilibs but I have no
idea how.

Combine the two issues together, neither of which can be addressed at
this point of the release cycle and I put the above patch forwards until
we can better resolve this.

Cheers,

Richard





^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 7/7] allarch: Drop various problematic allarch usages
  2013-04-15 15:40     ` Richard Purdie
@ 2013-04-15 15:49       ` Mark Hatle
  2013-04-15 16:15         ` Martin Jansa
  0 siblings, 1 reply; 17+ messages in thread
From: Mark Hatle @ 2013-04-15 15:49 UTC (permalink / raw)
  To: Richard Purdie; +Cc: openembedded-core

On 4/15/13 10:40 AM, Richard Purdie wrote:
> On Mon, 2013-04-15 at 10:16 -0500, Mark Hatle wrote:
>> On 4/15/13 6:07 AM, Richard Purdie wrote:
>>> In each of these cases allarch is used where the package in question has a
>>> dependency on things which are not allach and change when MACHINE is changed.
>>>
>>> This leads to a rebuild of the package each time MACHINE is switched and
>>> the sstate checksum changes. The dependencies in question are not suited
>>> be being marked as ABISAFE.
>>
>> In each of these cases, does the contents of the package change when the MACHINE
>> (or something in that machine) are modified?  If so, I agree they are definitely
>> not allarch.
>
> The contents does not, the sstate checksum however does due to the
> dependencies. The dependencies are thinks like gtk+ and dbus.
>
>> However, if the dependency really doesn't matter, then why isn't ABISAFE correct
>> in each case?
>
> I'm using ABISAFE in this context as shorthand for
> SIGGEN_EXCLUDERECIPES_ABISAFE and those are defined as things which
> don't need to rebuild if the dependency changes.

So this can't be set on a package specific basis?  If that is the case, it may 
make sense to look into a recipe specific way of declaring a 'lack' of 
dependency on rebuilding others in the future.

> gtk+ and dbus both provide libraries and we do want software to rebuild
> if they change. In the allarch case we could whitelist the dependency
> however in the general case we shouldn't.

Ya I agree, I thought it could be done easily on a per-package basis.

> Even with that problem addressed somehow, it leaves an issue with ipk
> multilibs where the distcc-config allarch recipe would always depend
> upon "distcc" and hence distcc would get pulled into the image,
> regardless of any other multilib settings (which in turn pulls in gtk+
> for example). A "lib64-xxx-image" would therefore end up with near
> enough two copies of half the system due to this. This is something we
> really need to fix in the opkg implementation of multilibs but I have no
> idea how.

This is more then just a problem in opkg, it may be more evident there.. but it 
is something we should look into as well.

> Combine the two issues together, neither of which can be addressed at
> this point of the release cycle and I put the above patch forwards until
> we can better resolve this.
>
> Cheers,
>
> Richard
>
>




^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH 7/7] allarch: Drop various problematic allarch usages
  2013-04-15 15:49       ` Mark Hatle
@ 2013-04-15 16:15         ` Martin Jansa
  0 siblings, 0 replies; 17+ messages in thread
From: Martin Jansa @ 2013-04-15 16:15 UTC (permalink / raw)
  To: Mark Hatle; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 2985 bytes --]

On Mon, Apr 15, 2013 at 10:49:20AM -0500, Mark Hatle wrote:
> On 4/15/13 10:40 AM, Richard Purdie wrote:
> > On Mon, 2013-04-15 at 10:16 -0500, Mark Hatle wrote:
> >> On 4/15/13 6:07 AM, Richard Purdie wrote:
> >>> In each of these cases allarch is used where the package in question has a
> >>> dependency on things which are not allach and change when MACHINE is changed.
> >>>
> >>> This leads to a rebuild of the package each time MACHINE is switched and
> >>> the sstate checksum changes. The dependencies in question are not suited
> >>> be being marked as ABISAFE.
> >>
> >> In each of these cases, does the contents of the package change when the MACHINE
> >> (or something in that machine) are modified?  If so, I agree they are definitely
> >> not allarch.
> >
> > The contents does not, the sstate checksum however does due to the
> > dependencies. The dependencies are thinks like gtk+ and dbus.
> >
> >> However, if the dependency really doesn't matter, then why isn't ABISAFE correct
> >> in each case?
> >
> > I'm using ABISAFE in this context as shorthand for
> > SIGGEN_EXCLUDERECIPES_ABISAFE and those are defined as things which
> > don't need to rebuild if the dependency changes.
> 
> So this can't be set on a package specific basis?  If that is the case, it may 
> make sense to look into a recipe specific way of declaring a 'lack' of 
> dependency on rebuilding others in the future.
> 
> > gtk+ and dbus both provide libraries and we do want software to rebuild
> > if they change. In the allarch case we could whitelist the dependency
> > however in the general case we shouldn't.
> 
> Ya I agree, I thought it could be done easily on a per-package basis.

Yes it can be
SIGGEN_EXCLUDERECIPES_ABISAFE += "distcc-config->distcc"
should work.

> > Even with that problem addressed somehow, it leaves an issue with ipk
> > multilibs where the distcc-config allarch recipe would always depend
> > upon "distcc" and hence distcc would get pulled into the image,
> > regardless of any other multilib settings (which in turn pulls in gtk+
> > for example). A "lib64-xxx-image" would therefore end up with near
> > enough two copies of half the system due to this. This is something we
> > really need to fix in the opkg implementation of multilibs but I have no
> > idea how.
> 
> This is more then just a problem in opkg, it may be more evident there.. but it 
> is something we should look into as well.
> 
> > Combine the two issues together, neither of which can be addressed at
> > this point of the release cycle and I put the above patch forwards until
> > we can better resolve this.
> >
> > Cheers,
> >
> > Richard
> >
> >
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2013-04-15 16:33 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-15 11:07 [PATCH 1/7] kernel.bbclass: Ensure we have correct version information in deploy data Richard Purdie
2013-04-15 11:07 ` [PATCH] recipes: Fix ALLOW_EMPTY with no package specified Richard Purdie
2013-04-15 11:43   ` Martin Jansa
2013-04-15 12:06     ` Richard Purdie
2013-04-15 11:07 ` [PATCH 2/7] update-alternatives: Ensure DEPENDS is correct in multilib case Richard Purdie
2013-04-15 11:07 ` [PATCH 3/7] ttf-bitstream-vera: Use fontcache class for postinstall Richard Purdie
2013-04-15 11:07 ` [PATCH 4/7] encodings: Set RDEPENDS correctly Richard Purdie
2013-04-15 11:07 ` [PATCH 5/7] qemuwrapper-cross: Inhibit default dependencies Richard Purdie
2013-04-15 11:07 ` [PATCH 6/7] nfs-export-root: Update to use packagegroup naming Richard Purdie
2013-04-15 11:07 ` [PATCH 7/7] allarch: Drop various problematic allarch usages Richard Purdie
2013-04-15 15:16   ` Mark Hatle
2013-04-15 15:40     ` Richard Purdie
2013-04-15 15:49       ` Mark Hatle
2013-04-15 16:15         ` Martin Jansa
2013-04-15 11:38 ` [PATCH 1/7] kernel.bbclass: Ensure we have correct version information in deploy data Martin Jansa
2013-04-15 14:46   ` Richard Purdie
  -- strict thread matches above, loose matches on Subject: below --
2013-03-03 15:54 [PATCH] recipes: Fix ALLOW_EMPTY with no package specified Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox