Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Maupin, Chase" <chase.maupin@ti.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCHv2] u-boot: Add UBOOT_LOCALVERSION to control version string
Date: Tue, 16 Apr 2013 23:21:35 +0100	[thread overview]
Message-ID: <1366150895.25282.11.camel@ted> (raw)
In-Reply-To: <7D46E86EC0A8354091174257B2FED101594F0D62@DLEE11.ent.ti.com>

On Tue, 2013-04-16 at 11:59 +0000, Maupin, Chase wrote:
> > -----Original Message-----
> > From: Maupin, Chase
> > Sent: Thursday, April 11, 2013 8:03 AM
> > To: openembedded-core@lists.openembedded.org
> > Cc: Maupin, Chase
> > Subject: [PATCHv2] u-boot: Add UBOOT_LOCALVERSION to control
> > version string
> > 
> > * Add a variable called UBOOT_LOCALVERSION which when set will
> >   place a version string in the .scmversion file of the u-boot
> >   sources.  This string will be picked up by the u-boot Makefile
> >   and will be appended to the u-boot version.  This is done to
> >   make it easier to identify what revision of the u-boot sources
> >   are being run.  For example you can use a setting like the
> >   following to add the short commit id to the u-boot version
> >   string:
> > 
> > UBOOT_LOCALVERSION = "-g${@d.getVar('SRCPV',
> > True).partition('+')[2][0:7]}"
> > 
> 
> Ping on this patch

These are really enhancements, not bug fixes and are too late for 1.4
since they came in after the feature freeze.

I'm nervous of them as there have been several iterations and I can't
easily tell what impact these will have on the different package
backends, or linux-yocto verses non linux-yocto for example.

Its simply too late and there are other bigger issues I'm worried about.
I therefore don't want to take this additional risk, sorry.

Cheers,

Richard




  reply	other threads:[~2013-04-16 22:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-11 13:03 [PATCHv2] kernel: Add KERNEL_LOCALVERSION to control version string Chase Maupin
2013-04-11 13:03 ` [PATCHv2] u-boot: Add UBOOT_LOCALVERSION " Chase Maupin
2013-04-16 11:59   ` Maupin, Chase
2013-04-16 22:21     ` Richard Purdie [this message]
2013-04-17  4:41       ` Denys Dmytriyenko
2013-04-16 11:58 ` [PATCHv2] kernel: Add KERNEL_LOCALVERSION " Maupin, Chase

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366150895.25282.11.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=chase.maupin@ti.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox