Re: [PATCHv2] u-boot: Add UBOOT_LOCALVERSION to control version string

[Denys Dmytriyenko <denis@denix.org>]

On Tue, Apr 16, 2013 at 11:21:35PM +0100, Richard Purdie wrote:
> On Tue, 2013-04-16 at 11:59 +0000, Maupin, Chase wrote:
> > > -----Original Message-----
> > > From: Maupin, Chase
> > > Sent: Thursday, April 11, 2013 8:03 AM
> > > To: openembedded-core@lists.openembedded.org
> > > Cc: Maupin, Chase
> > > Subject: [PATCHv2] u-boot: Add UBOOT_LOCALVERSION to control
> > > version string
> > > 
> > > * Add a variable called UBOOT_LOCALVERSION which when set will
> > >   place a version string in the .scmversion file of the u-boot
> > >   sources.  This string will be picked up by the u-boot Makefile
> > >   and will be appended to the u-boot version.  This is done to
> > >   make it easier to identify what revision of the u-boot sources
> > >   are being run.  For example you can use a setting like the
> > >   following to add the short commit id to the u-boot version
> > >   string:
> > > 
> > > UBOOT_LOCALVERSION = "-g${@d.getVar('SRCPV',
> > > True).partition('+')[2][0:7]}"
> > > 
> > 
> > Ping on this patch
> 
> These are really enhancements, not bug fixes and are too late for 1.4
> since they came in after the feature freeze.
> 
> I'm nervous of them as there have been several iterations and I can't
> easily tell what impact these will have on the different package
> backends, or linux-yocto verses non linux-yocto for example.
> 
> Its simply too late and there are other bigger issues I'm worried about.
> I therefore don't want to take this additional risk, sorry.

Richard,

Thanks for the explanation, it's understood.
Do you want to take it after the release? Would you prefer a ping or a new 
submission of this patch?

-- 
Denys