* [PATCH] dbus: remove /var/run from package as it is created on startup
@ 2013-05-23 4:02 Jonathan Liu
2013-05-23 11:38 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Liu @ 2013-05-23 4:02 UTC (permalink / raw)
To: openembedded-core
/var/run is a tmpfs that is created on startup.
For sysvinit, /var/run/dbus is created by populate-volatiles.sh.
For systemd, /var/run/dbus is created implicitly by dbus.socket when
creating a listen stream socket at /var/run/dbus/system_bus_socket.
Signed-off-by: Jonathan Liu <net147@gmail.com>
---
meta/recipes-core/dbus/dbus.inc | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
index 2be5bda..8055824 100644
--- a/meta/recipes-core/dbus/dbus.inc
+++ b/meta/recipes-core/dbus/dbus.inc
@@ -101,9 +101,9 @@ do_install() {
> ${D}${sysconfdir}/default/volatiles/99_dbus
- mkdir -p ${D}${localstatedir}/run/dbus ${D}${localstatedir}/lib/dbus
+ mkdir -p ${D}${localstatedir}/lib/dbus
- chown messagebus:messagebus ${D}${localstatedir}/run/dbus ${D}${localstatedir}/lib/dbus
+ chown messagebus:messagebus ${D}${localstatedir}/lib/dbus
chown root:messagebus ${D}${libexecdir}/dbus-daemon-launch-helper
chmod 4755 ${D}${libexecdir}/dbus-daemon-launch-helper
@@ -113,6 +113,9 @@ do_install() {
# Remove empty testexec directory as we don't build tests
rm -rf ${D}${libdir}/dbus-1.0/test
+
+ # Remove /var/run as it is created on startup
+ rm -rf ${D}${localstatedir}/run
}
do_install_class-native() {
--
1.8.2.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dbus: remove /var/run from package as it is created on startup
2013-05-23 4:02 [PATCH] dbus: remove /var/run from package as it is created on startup Jonathan Liu
@ 2013-05-23 11:38 ` Richard Purdie
2013-05-23 12:31 ` Jonathan Liu
0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2013-05-23 11:38 UTC (permalink / raw)
To: Jonathan Liu; +Cc: openembedded-core
On Thu, 2013-05-23 at 14:02 +1000, Jonathan Liu wrote:
> /var/run is a tmpfs that is created on startup.
> For sysvinit, /var/run/dbus is created by populate-volatiles.sh.
> For systemd, /var/run/dbus is created implicitly by dbus.socket when
> creating a listen stream socket at /var/run/dbus/system_bus_socket.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
> meta/recipes-core/dbus/dbus.inc | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
> index 2be5bda..8055824 100644
> --- a/meta/recipes-core/dbus/dbus.inc
> +++ b/meta/recipes-core/dbus/dbus.inc
> @@ -101,9 +101,9 @@ do_install() {
> > ${D}${sysconfdir}/default/volatiles/99_dbus
>
>
> - mkdir -p ${D}${localstatedir}/run/dbus ${D}${localstatedir}/lib/dbus
> + mkdir -p ${D}${localstatedir}/lib/dbus
>
> - chown messagebus:messagebus ${D}${localstatedir}/run/dbus ${D}${localstatedir}/lib/dbus
> + chown messagebus:messagebus ${D}${localstatedir}/lib/dbus
Is what populate-volatiles does truly equivalent? Does this directory
need to be owned by messagebus (which is a user created by dbus) iirc?
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dbus: remove /var/run from package as it is created on startup
2013-05-23 11:38 ` Richard Purdie
@ 2013-05-23 12:31 ` Jonathan Liu
2013-05-23 12:50 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Liu @ 2013-05-23 12:31 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On 23/05/2013 9:38 PM, Richard Purdie wrote:
> On Thu, 2013-05-23 at 14:02 +1000, Jonathan Liu wrote:
>> /var/run is a tmpfs that is created on startup.
>> For sysvinit, /var/run/dbus is created by populate-volatiles.sh.
>> For systemd, /var/run/dbus is created implicitly by dbus.socket when
>> creating a listen stream socket at /var/run/dbus/system_bus_socket.
>>
>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>> ---
>> meta/recipes-core/dbus/dbus.inc | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
>> index 2be5bda..8055824 100644
>> --- a/meta/recipes-core/dbus/dbus.inc
>> +++ b/meta/recipes-core/dbus/dbus.inc
>> @@ -101,9 +101,9 @@ do_install() {
>> > ${D}${sysconfdir}/default/volatiles/99_dbus
>>
>>
>> - mkdir -p ${D}${localstatedir}/run/dbus ${D}${localstatedir}/lib/dbus
>> + mkdir -p ${D}${localstatedir}/lib/dbus
>>
>> - chown messagebus:messagebus ${D}${localstatedir}/run/dbus ${D}${localstatedir}/lib/dbus
>> + chown messagebus:messagebus ${D}${localstatedir}/lib/dbus
> Is what populate-volatiles does truly equivalent? Does this directory
> need to be owned by messagebus (which is a user created by dbus) iirc?
>
> Cheers,
>
> Richard
The dbus recipe writes /etc/default/volatiles/99_dbus.
For sysvinit case, this will cause populate-volatiles.sh to create
/var/run/dbus owned by messagebus:messagebus with 0755 permissions so it
is the same.
The systemd init doesn't use populate-volatiles.sh and it's created
implicitly so it is owned by root:root with 0755 permissions.
For distributions using sysvinit (e.g. Debian), /var/run/dbus is
typically owned by messagebus:messagebus. There is no dbus user/group in
/etc/passwd or /etc/group.
For distributions using systemd (e.g. Arch Linux and Fedora),
/var/run/dbus (actually /run/dbus) is typically owned by root:root.
There is no messagebus user/group in /etc/passwd or /etc/group, but
there is dbus.
Regards,
Jonathan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dbus: remove /var/run from package as it is created on startup
2013-05-23 12:31 ` Jonathan Liu
@ 2013-05-23 12:50 ` Richard Purdie
0 siblings, 0 replies; 4+ messages in thread
From: Richard Purdie @ 2013-05-23 12:50 UTC (permalink / raw)
To: Jonathan Liu; +Cc: openembedded-core
On Thu, 2013-05-23 at 22:31 +1000, Jonathan Liu wrote:
> On 23/05/2013 9:38 PM, Richard Purdie wrote:
> > On Thu, 2013-05-23 at 14:02 +1000, Jonathan Liu wrote:
> >> /var/run is a tmpfs that is created on startup.
> >> For sysvinit, /var/run/dbus is created by populate-volatiles.sh.
> >> For systemd, /var/run/dbus is created implicitly by dbus.socket when
> >> creating a listen stream socket at /var/run/dbus/system_bus_socket.
> >>
> >> Signed-off-by: Jonathan Liu <net147@gmail.com>
> >> ---
> >> meta/recipes-core/dbus/dbus.inc | 7 +++++--
> >> 1 file changed, 5 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
> >> index 2be5bda..8055824 100644
> >> --- a/meta/recipes-core/dbus/dbus.inc
> >> +++ b/meta/recipes-core/dbus/dbus.inc
> >> @@ -101,9 +101,9 @@ do_install() {
> >> > ${D}${sysconfdir}/default/volatiles/99_dbus
> >>
> >>
> >> - mkdir -p ${D}${localstatedir}/run/dbus ${D}${localstatedir}/lib/dbus
> >> + mkdir -p ${D}${localstatedir}/lib/dbus
> >>
> >> - chown messagebus:messagebus ${D}${localstatedir}/run/dbus ${D}${localstatedir}/lib/dbus
> >> + chown messagebus:messagebus ${D}${localstatedir}/lib/dbus
> > Is what populate-volatiles does truly equivalent? Does this directory
> > need to be owned by messagebus (which is a user created by dbus) iirc?
> >
> > Cheers,
> >
> > Richard
> The dbus recipe writes /etc/default/volatiles/99_dbus.
That is the piece I'd missed, thanks :).
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-23 12:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-23 4:02 [PATCH] dbus: remove /var/run from package as it is created on startup Jonathan Liu
2013-05-23 11:38 ` Richard Purdie
2013-05-23 12:31 ` Jonathan Liu
2013-05-23 12:50 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox