From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 10/21] ncurses, busybox, cml1.bbclass: Fix menuconfig display corruption
Date: Wed, 29 May 2013 22:15:17 +0100 [thread overview]
Message-ID: <1369862117.14887.233.camel@ted> (raw)
In-Reply-To: <1369840203-21898-11-git-send-email-mark.hatle@windriver.com>
On Wed, 2013-05-29 at 10:09 -0500, Mark Hatle wrote:
> From: Jason Wessel <jason.wessel@windriver.com>
>
> Previously there was a change to the ncurses compile to make it more
> like the typical way it was compiled on a host system. This fixed a
> whole class of host machines, but masked the real underlying problem
> with the display corruption issues and menuconfig.
>
> The corner case that led to the discovery that the wrong curses.h file
> was getting used was when there was no curses libraries at all on one
> of the development hosts. What had happened before was that
> /usr/include/curses.h on the host system had to match closely enough
> to the curses.h in the sysroot and then linking against the sysroot
> version of curses.so was ok (meaning no display corruption). But on
> some systems with ncurses.h vs curses.h such as SuSE hosts, there were
> still issues.
>
> If we fix the root of the problem and force the mconf and lxdialog to
> use the correct headers and libraries from the sysroot there is no
> further issues and the menuconfig target works properly. It also
> means we can back out the custom compilation flags to the ncurses
> recipe because they are no longer needed.
>
> For the kernel part of the menuconfig / nconfig changes it will be
> merged separately and this is all based on:
>
> https://lkml.org/lkml/2013/3/3/103
>
> Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
> ---
> meta/classes/cml1.bbclass | 5 +-
> .../busybox-1.20.2/busybox-cross-menuconfig.patch | 69 ++++++++++++++++++++++
> meta/recipes-core/busybox/busybox_1.20.2.bb | 3 +-
> meta/recipes-core/ncurses/ncurses.inc | 14 -----
> 4 files changed, 74 insertions(+), 17 deletions(-)
> create mode 100644 meta/recipes-core/busybox/busybox-1.20.2/busybox-cross-menuconfig.patch
Jason asked us to hold off merging this until things were sorted out in
the mainline kernel. Has that happened?
Cheers,
Richard
next prev parent reply other threads:[~2013-05-29 21:15 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 15:09 [PATCH 0/21] Misc patch set Mark Hatle
2013-05-29 15:09 ` [PATCH 1/21] libxpm: inherit gettext Mark Hatle
2013-05-29 15:09 ` [PATCH 2/21] Add directory information to the pkgdata files Mark Hatle
2013-05-29 15:11 ` Paul Eggleton
2013-05-29 15:23 ` Mark Hatle
2013-05-29 15:59 ` Martin Jansa
2013-05-29 16:30 ` Mark Hatle
2013-05-29 17:36 ` Khem Raj
2013-05-29 19:59 ` Phil Blundell
2013-05-29 20:44 ` Mark Hatle
2013-05-30 8:29 ` Paul Eggleton
2013-05-30 8:33 ` Richard Purdie
2013-05-29 15:09 ` [PATCH 3/21] cmake.bbclass: modify construction of compiler flags Mark Hatle
2013-05-29 15:09 ` [PATCH 4/21] acpid: modify CFLAGS Mark Hatle
2013-05-29 15:09 ` [PATCH 5/21] libpam: Avoid wildcards in the SRC_URI Mark Hatle
2013-05-29 15:09 ` [PATCH 6/21] util-linux: Add ability to compile with nativesdk Mark Hatle
2013-05-29 15:09 ` [PATCH 7/21] dbus-glib: use BPN instead of PN Mark Hatle
2013-05-29 15:09 ` [PATCH 8/21] initscripts: let status return 0 when proc is running well Mark Hatle
2013-05-29 15:09 ` [PATCH 9/21] pull ldlinux.sys and isolinux.bin from correct places Mark Hatle
2013-05-29 15:09 ` [PATCH 10/21] ncurses, busybox, cml1.bbclass: Fix menuconfig display corruption Mark Hatle
2013-05-29 21:15 ` Richard Purdie [this message]
2013-05-29 15:09 ` [PATCH 11/21] guile: don't search for libreadline in host libdir Mark Hatle
2013-05-29 15:09 ` [PATCH 12/21] dpkg-native: Fix native perl path Mark Hatle
2013-05-29 15:09 ` [PATCH 13/21] qmake_base.bbclass:add linux-gnun32-oe-g++ to QMAKESPEC Mark Hatle
2013-05-29 15:09 ` [PATCH 14/21] portmap: /etc/init.d/portmap restart complains "command not found" Mark Hatle
2013-05-29 15:09 ` [PATCH 15/21] fix libnl two parentheses bugs in lib/cache_mngr.c file Mark Hatle
2013-05-29 15:09 ` [PATCH 16/21] bind: add ipv6 support Mark Hatle
2013-05-29 15:09 ` [PATCH 17/21] grep: fix for CVE-2012-5667 Mark Hatle
2013-05-29 21:21 ` Richard Purdie
2013-05-29 15:10 ` [PATCH 18/21] Fix problems expanding the IMAGE_INSTALL package groups Mark Hatle
2013-05-29 21:10 ` Richard Purdie
2013-05-29 21:28 ` Mark Hatle
2013-05-29 21:59 ` Richard Purdie
2013-05-30 10:46 ` Phil Blundell
2013-05-30 12:22 ` Mark Hatle
2013-05-30 20:10 ` Richard Purdie
2013-05-29 15:10 ` [PATCH 19/21] siteinfo.bbclass: Add mips64 common siteinfo Mark Hatle
2013-05-29 15:10 ` [PATCH 20/21] cracklib: Allow byte order patch to work on older Linux hosts Mark Hatle
2013-05-29 15:10 ` [PATCH 21/21] libarchive: Fix build dependencies Mark Hatle
2013-05-30 0:53 ` [PATCH 0/21] Misc patch set Saul Wold
2013-05-30 3:55 ` Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369862117.14887.233.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox