From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 17/21] grep: fix for CVE-2012-5667
Date: Wed, 29 May 2013 22:21:42 +0100 [thread overview]
Message-ID: <1369862502.14887.234.camel@ted> (raw)
In-Reply-To: <1369840203-21898-18-git-send-email-mark.hatle@windriver.com>
On Wed, 2013-05-29 at 10:09 -0500, Mark Hatle wrote:
> From: Ming Liu <ming.liu@windriver.com>
>
> Multiple integer overflows in GNU Grep before 2.11 might allow
> context-dependent attackers to execute arbitrary code via vectors
> involving a long input line that triggers a heap-based buffer overflow.
>
> http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2012-5667
>
> Signed-off-by: Ming Liu <ming.liu@windriver.com>
> ---
> .../grep/grep-2.5.1a/grep-CVE-2012-5667.patch | 28 ++++++++++++++++++++++
> meta/recipes-extended/grep/grep_2.5.1a.bb | 3 ++-
> 2 files changed, 30 insertions(+), 1 deletion(-)
> create mode 100644 meta/recipes-extended/grep/grep-2.5.1a/grep-CVE-2012-5667.patch
>
> diff --git a/meta/recipes-extended/grep/grep-2.5.1a/grep-CVE-2012-5667.patch b/meta/recipes-extended/grep/grep-2.5.1a/grep-CVE-2012-5667.patch
> new file mode 100644
> index 0000000..e163736
> --- /dev/null
> +++ b/meta/recipes-extended/grep/grep-2.5.1a/grep-CVE-2012-5667.patch
> @@ -0,0 +1,28 @@
> +The patch to fix CVE-2012-5667
> +Reference: https://bugzilla.redhat.com/attachment.cgi?id=686605&action=diff
> +
> +Multiple integer overflows in GNU Grep before 2.11 might allow
> +context-dependent attackers to execute arbitrary code via vectors
> +involving a long input line that triggers a heap-based buffer overflow.
> +
> +http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2012-5667
> +
> +Signed-off-by Ming Liu <ming.liu@windriver.com>
> +---
> + grep.c | 7 +++----
> + 1 file changed, 3 insertions(+), 4 deletions(-)
This needs an Upstream-Status field (I know its clear when you read it
but the scripts can't do that).
Cheers,
Richard
> +--- a/src/grep.c 2013-05-15 13:39:33.359191769 +0800
> ++++ a/src/grep.c 2013-05-15 13:50:22.609191882 +0800
> +@@ -306,6 +306,11 @@ fillbuf (size_t save, struct stats const
> + int cc = 1;
> + char *readbuf;
> + size_t readsize;
> ++ const size_t max_save = INT_MAX / 2;
> ++
> ++ /* Limit the amount of saved data to INT_MAX to fix CVE-2012-5667 */
> ++ if (save > max_save)
> ++ error (2, 0, _("line too long"));
> +
> + /* Offset from start of buffer to start of old stuff
> + that we want to save. */
> diff --git a/meta/recipes-extended/grep/grep_2.5.1a.bb b/meta/recipes-extended/grep/grep_2.5.1a.bb
> index d6386ed..247c837 100644
> --- a/meta/recipes-extended/grep/grep_2.5.1a.bb
> +++ b/meta/recipes-extended/grep/grep_2.5.1a.bb
> @@ -13,7 +13,8 @@ SRC_URI = "${GNU_MIRROR}/grep/grep-${PV}.tar.bz2 \
> file://gettext.patch \
> file://fix64-int-to-pointer.patch \
> file://Makevars \
> - "
> + file://grep-CVE-2012-5667.patch \
> + "
>
> SRC_URI[md5sum] = "52202fe462770fa6be1bb667bd6cf30c"
> SRC_URI[sha256sum] = "38c8a2bb9223d1fb1b10bdd607cf44830afc92fd451ac4cd07619bf92bdd3132"
next prev parent reply other threads:[~2013-05-29 21:21 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 15:09 [PATCH 0/21] Misc patch set Mark Hatle
2013-05-29 15:09 ` [PATCH 1/21] libxpm: inherit gettext Mark Hatle
2013-05-29 15:09 ` [PATCH 2/21] Add directory information to the pkgdata files Mark Hatle
2013-05-29 15:11 ` Paul Eggleton
2013-05-29 15:23 ` Mark Hatle
2013-05-29 15:59 ` Martin Jansa
2013-05-29 16:30 ` Mark Hatle
2013-05-29 17:36 ` Khem Raj
2013-05-29 19:59 ` Phil Blundell
2013-05-29 20:44 ` Mark Hatle
2013-05-30 8:29 ` Paul Eggleton
2013-05-30 8:33 ` Richard Purdie
2013-05-29 15:09 ` [PATCH 3/21] cmake.bbclass: modify construction of compiler flags Mark Hatle
2013-05-29 15:09 ` [PATCH 4/21] acpid: modify CFLAGS Mark Hatle
2013-05-29 15:09 ` [PATCH 5/21] libpam: Avoid wildcards in the SRC_URI Mark Hatle
2013-05-29 15:09 ` [PATCH 6/21] util-linux: Add ability to compile with nativesdk Mark Hatle
2013-05-29 15:09 ` [PATCH 7/21] dbus-glib: use BPN instead of PN Mark Hatle
2013-05-29 15:09 ` [PATCH 8/21] initscripts: let status return 0 when proc is running well Mark Hatle
2013-05-29 15:09 ` [PATCH 9/21] pull ldlinux.sys and isolinux.bin from correct places Mark Hatle
2013-05-29 15:09 ` [PATCH 10/21] ncurses, busybox, cml1.bbclass: Fix menuconfig display corruption Mark Hatle
2013-05-29 21:15 ` Richard Purdie
2013-05-29 15:09 ` [PATCH 11/21] guile: don't search for libreadline in host libdir Mark Hatle
2013-05-29 15:09 ` [PATCH 12/21] dpkg-native: Fix native perl path Mark Hatle
2013-05-29 15:09 ` [PATCH 13/21] qmake_base.bbclass:add linux-gnun32-oe-g++ to QMAKESPEC Mark Hatle
2013-05-29 15:09 ` [PATCH 14/21] portmap: /etc/init.d/portmap restart complains "command not found" Mark Hatle
2013-05-29 15:09 ` [PATCH 15/21] fix libnl two parentheses bugs in lib/cache_mngr.c file Mark Hatle
2013-05-29 15:09 ` [PATCH 16/21] bind: add ipv6 support Mark Hatle
2013-05-29 15:09 ` [PATCH 17/21] grep: fix for CVE-2012-5667 Mark Hatle
2013-05-29 21:21 ` Richard Purdie [this message]
2013-05-29 15:10 ` [PATCH 18/21] Fix problems expanding the IMAGE_INSTALL package groups Mark Hatle
2013-05-29 21:10 ` Richard Purdie
2013-05-29 21:28 ` Mark Hatle
2013-05-29 21:59 ` Richard Purdie
2013-05-30 10:46 ` Phil Blundell
2013-05-30 12:22 ` Mark Hatle
2013-05-30 20:10 ` Richard Purdie
2013-05-29 15:10 ` [PATCH 19/21] siteinfo.bbclass: Add mips64 common siteinfo Mark Hatle
2013-05-29 15:10 ` [PATCH 20/21] cracklib: Allow byte order patch to work on older Linux hosts Mark Hatle
2013-05-29 15:10 ` [PATCH 21/21] libarchive: Fix build dependencies Mark Hatle
2013-05-30 0:53 ` [PATCH 0/21] Misc patch set Saul Wold
2013-05-30 3:55 ` Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369862502.14887.234.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox