* [PATCH] boot-directdisk: use awk instead of echo -ne for dash compatibility
@ 2013-07-20 12:11 Jonathan Liu
2013-07-22 10:17 ` Iorga, Cristian
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Liu @ 2013-07-20 12:11 UTC (permalink / raw)
To: openembedded-core
The echo command is a dash shell built-in and does not support the
-n and -e options so use awk instead.
This fixes the partition table being corrupted when writing the MBR
disk signature into the image.
[YOCTO #4859]
Signed-off-by: Jonathan Liu <net147@gmail.com>
---
meta/classes/boot-directdisk.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/boot-directdisk.bbclass b/meta/classes/boot-directdisk.bbclass
index 182957b..8a55aae 100644
--- a/meta/classes/boot-directdisk.bbclass
+++ b/meta/classes/boot-directdisk.bbclass
@@ -81,7 +81,7 @@ build_boot_dd() {
parted $IMAGE set 1 boot on
parted $IMAGE print
- echo -ne "$(echo ${DISK_SIGNATURE} | fold -w 2 | tac | paste -sd '' | sed 's/\(..\)/\\x&/g')" | \
+ awk "BEGIN { printf \"$(echo ${DISK_SIGNATURE} | fold -w 2 | tac | paste -sd '' | sed 's/\(..\)/\\x&/g')\" }" | \
dd of=$IMAGE bs=1 seek=440 conv=notrunc
OFFSET=`expr $END2 / 512`
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] boot-directdisk: use awk instead of echo -ne for dash compatibility
2013-07-20 12:11 [PATCH] boot-directdisk: use awk instead of echo -ne for dash compatibility Jonathan Liu
@ 2013-07-22 10:17 ` Iorga, Cristian
0 siblings, 0 replies; 2+ messages in thread
From: Iorga, Cristian @ 2013-07-22 10:17 UTC (permalink / raw)
To: Jonathan Liu, openembedded-core@lists.openembedded.org
ACK.
-----Original Message-----
From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Jonathan Liu
Sent: Saturday, July 20, 2013 3:11 PM
To: openembedded-core@lists.openembedded.org
Subject: [OE-core] [PATCH] boot-directdisk: use awk instead of echo -ne for dash compatibility
The echo command is a dash shell built-in and does not support the
-n and -e options so use awk instead.
This fixes the partition table being corrupted when writing the MBR
disk signature into the image.
[YOCTO #4859]
Signed-off-by: Jonathan Liu <net147@gmail.com>
---
meta/classes/boot-directdisk.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/boot-directdisk.bbclass b/meta/classes/boot-directdisk.bbclass
index 182957b..8a55aae 100644
--- a/meta/classes/boot-directdisk.bbclass
+++ b/meta/classes/boot-directdisk.bbclass
@@ -81,7 +81,7 @@ build_boot_dd() {
parted $IMAGE set 1 boot on
parted $IMAGE print
- echo -ne "$(echo ${DISK_SIGNATURE} | fold -w 2 | tac | paste -sd '' | sed 's/\(..\)/\\x&/g')" | \
+ awk "BEGIN { printf \"$(echo ${DISK_SIGNATURE} | fold -w 2 | tac | paste -sd '' | sed 's/\(..\)/\\x&/g')\" }" | \
dd of=$IMAGE bs=1 seek=440 conv=notrunc
OFFSET=`expr $END2 / 512`
--
1.8.3.2
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-22 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-20 12:11 [PATCH] boot-directdisk: use awk instead of echo -ne for dash compatibility Jonathan Liu
2013-07-22 10:17 ` Iorga, Cristian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox