From: Colin Walters <walters@verbum.org>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] glib-2.0: fix broken python script header on machines using buildtools
Date: Fri, 20 Sep 2013 12:19:25 -0400 [thread overview]
Message-ID: <1379693965.1665.13.camel@localhost> (raw)
In-Reply-To: <4037078.8vkzREKUPL@helios>
On Fri, 2013-09-20 at 17:14 +0100, Paul Eggleton wrote:
> Hi Colin,
>
> On Friday 20 September 2013 12:04:15 Colin Walters wrote:
> > On Fri, 2013-09-20 at 15:43 +0100, Paul Eggleton wrote:
> > > it also seems sensible to do
> > > this for native as well instead of explicitly trying to exclude that
> > > case.
> >
> > But someone presumably introduced the explicit special case for native
> > for a reason, I'd expect some blame analysis to be done here to
> > determine whether those reasons were bogus or not.
>
> I already did that as a matter of course; there is no clue in the message
> for the commit that added it:
>
> http://cgit.openembedded.org/openembedded-core/commit/?id=08fd9740b9359425ec6ee9810fab1152e9737b0c
Ok, well then I'd expect something in your commit message similar to
"There was no original rationale for why native was special cased, and I
think it should be safe to remove."
It might be still cached in Richard's brain of course...let's see =)
next prev parent reply other threads:[~2013-09-20 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 14:43 [PATCH] glib-2.0: fix broken python script header on machines using buildtools Paul Eggleton
2013-09-20 16:04 ` Colin Walters
2013-09-20 16:14 ` Paul Eggleton
2013-09-20 16:19 ` Colin Walters [this message]
2013-09-20 16:27 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379693965.1665.13.camel@localhost \
--to=walters@verbum.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox