Re: [PATCH] glib-2.0: fix broken python script header on machines using buildtools

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2013-09-20 at 12:19 -0400, Colin Walters wrote:
> On Fri, 2013-09-20 at 17:14 +0100, Paul Eggleton wrote:
> > Hi Colin,
> > 
> > On Friday 20 September 2013 12:04:15 Colin Walters wrote:
> > > On Fri, 2013-09-20 at 15:43 +0100, Paul Eggleton wrote:
> > > >  it also seems sensible to do
> > > > this for native as well instead of explicitly trying to exclude that
> > > > case.
> > > 
> > > But someone presumably introduced the explicit special case for native
> > > for a reason, I'd expect some blame analysis to be done here to
> > > determine whether those reasons were bogus or not.
> > 
> > I already did that as a matter of course; there is no clue in the message
> > for the commit that added it:
> > 
> > http://cgit.openembedded.org/openembedded-core/commit/?id=08fd9740b9359425ec6ee9810fab1152e9737b0c
> 
> Ok, well then I'd expect something in your commit message similar to
> "There was no original rationale for why native was special cased, and I
> think it should be safe to remove."
> 
> It might be still cached in Richard's brain of course...let's see =)

That particular expression would have at best been a null operation for
the -native case. Its around release time so I probably fixed the thing
that was broken, no more, no less.

I'm fine with replacing it with something better.

Cheers,

Richard