Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/2] Add shutdown to group by default
@ 2013-09-24 14:45 Saul Wold
  2013-09-24 14:45 ` [PATCH 1/2] sysvinit: don't use useradd Saul Wold
  2013-09-24 14:45 ` [PATCH 2/2] base-passwd: add shutdown group Saul Wold
  0 siblings, 2 replies; 4+ messages in thread
From: Saul Wold @ 2013-09-24 14:45 UTC (permalink / raw)
  To: openembedded-core

Recently sysvinit added the useradd bbclass to add a shutdown 
group, this caused shadow to be added to the core-image-minimal
increasing it's size by about 1.3M.

Saul Wold (2):
  sysvinit: don't use useradd
  base-passwd: add shutdown group

 .../base-passwd/base-passwd-3.5.26/add_shutdown.patch | 19 +++++++++++++++++++
 meta/recipes-core/base-passwd/base-passwd_3.5.26.bb   |  4 +++-
 meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb        |  7 ++-----
 3 files changed, 24 insertions(+), 6 deletions(-)
 create mode 100644 meta/recipes-core/base-passwd/base-passwd-3.5.26/add_shutdown.patch

-- 
1.8.3.1



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] sysvinit: don't use useradd
  2013-09-24 14:45 [PATCH 0/2] Add shutdown to group by default Saul Wold
@ 2013-09-24 14:45 ` Saul Wold
  2013-09-24 15:04   ` Saul Wold
  2013-09-24 14:45 ` [PATCH 2/2] base-passwd: add shutdown group Saul Wold
  1 sibling, 1 reply; 4+ messages in thread
From: Saul Wold @ 2013-09-24 14:45 UTC (permalink / raw)
  To: openembedded-core

It causes shadow to be used in core-image-minimal and increase the
size by 1.5M.  We will add the shutdown user to group via base-passwd
Ensure that sysvinit depends on base-passwd for the group chown.

[YOCTO #5230]

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb b/meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb
index 97ecc51..9ec92e2 100644
--- a/meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb
+++ b/meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb
@@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
                     file://COPYRIGHT;endline=15;md5=349c872e0066155e1818b786938876a4"
 PR = "r11"
 
-RDEPENDS_${PN} = "${PN}-inittab"
+RDEPENDS_${PN} = "${PN}-inittab base-passwd"
 
 SRC_URI = "http://download.savannah.gnu.org/releases-noredirect/sysvinit/sysvinit-${PV}.tar.bz2 \
            file://install.patch \
@@ -24,7 +24,7 @@ SRC_URI[sha256sum] = "60bbc8c1e1792056e23761d22960b30bb13eccc2cabff8c7310a01f4d5
 S = "${WORKDIR}/sysvinit-${PV}"
 B = "${S}/src"
 
-inherit update-alternatives useradd
+inherit update-alternatives
 DEPENDS_append = " update-rc.d-native"
 
 ALTERNATIVE_${PN} = "init mountpoint halt reboot runlevel shutdown poweroff last mesg utmpdump wall"
@@ -53,9 +53,6 @@ ALTERNATIVE_LINK_NAME[sulogin.8] = "${mandir}/man8/sulogin.8"
 ALTERNATIVE_LINK_NAME[utmpdump.1] = "${mandir}/man1/utmpdump.1"
 ALTERNATIVE_LINK_NAME[wall.1] = "${mandir}/man1/wall.1"
 
-USERADD_PACKAGES = "${PN}"
-GROUPADD_PARAM_${PN} = "--system shutdown"
-
 PACKAGES =+ "sysvinit-pidof sysvinit-sulogin"
 FILES_${PN} += "${base_sbindir}/* ${base_bindir}/*"
 FILES_sysvinit-pidof = "${base_bindir}/pidof.sysvinit ${base_sbindir}/killall5"
-- 
1.8.3.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] base-passwd: add shutdown group
  2013-09-24 14:45 [PATCH 0/2] Add shutdown to group by default Saul Wold
  2013-09-24 14:45 ` [PATCH 1/2] sysvinit: don't use useradd Saul Wold
@ 2013-09-24 14:45 ` Saul Wold
  1 sibling, 0 replies; 4+ messages in thread
From: Saul Wold @ 2013-09-24 14:45 UTC (permalink / raw)
  To: openembedded-core

Since using useradd in sysvinit causes core-image-minimal to
gain shadow utilites instead of using busybox, we add the
shutdown group directly.

[YOCTO #5230]

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 .../base-passwd/base-passwd-3.5.26/add_shutdown.patch | 19 +++++++++++++++++++
 meta/recipes-core/base-passwd/base-passwd_3.5.26.bb   |  4 +++-
 2 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-core/base-passwd/base-passwd-3.5.26/add_shutdown.patch

diff --git a/meta/recipes-core/base-passwd/base-passwd-3.5.26/add_shutdown.patch b/meta/recipes-core/base-passwd/base-passwd-3.5.26/add_shutdown.patch
new file mode 100644
index 0000000..eb75559
--- /dev/null
+++ b/meta/recipes-core/base-passwd/base-passwd-3.5.26/add_shutdown.patch
@@ -0,0 +1,19 @@
+
+We need to have a shutdown group to allow the shutdown icon
+to work correctly. Any users that want to use shutdown like
+the xuser should be added to this group.
+
+Upstream-Status: Inapporpriate [Embedded]
+
+Signed-off-by: Saul Wold <sgw@linux.intel.com>
+Index: base-passwd-3.5.26/group.master
+===================================================================
+--- base-passwd-3.5.26.orig/group.master
++++ base-passwd-3.5.26/group.master
+@@ -36,5 +36,6 @@ sasl:*:45:
+ plugdev:*:46:
+ staff:*:50:
+ games:*:60:
++shutdown:*:70:
+ users:*:100:
+ nogroup:*:65534:
diff --git a/meta/recipes-core/base-passwd/base-passwd_3.5.26.bb b/meta/recipes-core/base-passwd/base-passwd_3.5.26.bb
index 1c7e6b0..2181ac7 100644
--- a/meta/recipes-core/base-passwd/base-passwd_3.5.26.bb
+++ b/meta/recipes-core/base-passwd/base-passwd_3.5.26.bb
@@ -7,7 +7,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a"
 
 SRC_URI = "${DEBIAN_MIRROR}/main/b/base-passwd/base-passwd_${PV}.tar.gz \
            file://nobash.patch \
-           file://input.patch"
+           file://input.patch \
+           file://add_shutdown.patch \
+          "
 
 SRC_URI[md5sum] = "74245e5c21dc74d9675c77cd8dfa02e6"
 SRC_URI[sha256sum] = "258a78317aa563143d10375c6e1e63a60898e503887f00fffd70b6b297c1b429"
-- 
1.8.3.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] sysvinit: don't use useradd
  2013-09-24 14:45 ` [PATCH 1/2] sysvinit: don't use useradd Saul Wold
@ 2013-09-24 15:04   ` Saul Wold
  0 siblings, 0 replies; 4+ messages in thread
From: Saul Wold @ 2013-09-24 15:04 UTC (permalink / raw)
  To: Saul Wold; +Cc: openembedded-core

On 09/24/2013 07:45 AM, Saul Wold wrote:
> It causes shadow to be used in core-image-minimal and increase the
> size by 1.5M.  We will add the shutdown user to group via base-passwd
> Ensure that sysvinit depends on base-passwd for the group chown.
>
> [YOCTO #5230]
>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>   meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb b/meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb
> index 97ecc51..9ec92e2 100644
> --- a/meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb
> +++ b/meta/recipes-core/sysvinit/sysvinit_2.88dsf.bb
> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
>                       file://COPYRIGHT;endline=15;md5=349c872e0066155e1818b786938876a4"
>   PR = "r11"
>
> -RDEPENDS_${PN} = "${PN}-inittab"
> +RDEPENDS_${PN} = "${PN}-inittab base-passwd"
>
This should be in DEPENDS, RP has this already patched.

Thanks
	Sau!

>   SRC_URI = "http://download.savannah.gnu.org/releases-noredirect/sysvinit/sysvinit-${PV}.tar.bz2 \
>              file://install.patch \
> @@ -24,7 +24,7 @@ SRC_URI[sha256sum] = "60bbc8c1e1792056e23761d22960b30bb13eccc2cabff8c7310a01f4d5
>   S = "${WORKDIR}/sysvinit-${PV}"
>   B = "${S}/src"
>
> -inherit update-alternatives useradd
> +inherit update-alternatives
>   DEPENDS_append = " update-rc.d-native"
>
>   ALTERNATIVE_${PN} = "init mountpoint halt reboot runlevel shutdown poweroff last mesg utmpdump wall"
> @@ -53,9 +53,6 @@ ALTERNATIVE_LINK_NAME[sulogin.8] = "${mandir}/man8/sulogin.8"
>   ALTERNATIVE_LINK_NAME[utmpdump.1] = "${mandir}/man1/utmpdump.1"
>   ALTERNATIVE_LINK_NAME[wall.1] = "${mandir}/man1/wall.1"
>
> -USERADD_PACKAGES = "${PN}"
> -GROUPADD_PARAM_${PN} = "--system shutdown"
> -
>   PACKAGES =+ "sysvinit-pidof sysvinit-sulogin"
>   FILES_${PN} += "${base_sbindir}/* ${base_bindir}/*"
>   FILES_sysvinit-pidof = "${base_bindir}/pidof.sysvinit ${base_sbindir}/killall5"
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-09-24 15:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-24 14:45 [PATCH 0/2] Add shutdown to group by default Saul Wold
2013-09-24 14:45 ` [PATCH 1/2] sysvinit: don't use useradd Saul Wold
2013-09-24 15:04   ` Saul Wold
2013-09-24 14:45 ` [PATCH 2/2] base-passwd: add shutdown group Saul Wold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox