Re: [PATCH] runqemu: Use correct kvm CPU options for qemux86* with kvm

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2013-09-25 at 14:34 -0700, Khem Raj wrote:
> On Wed, Sep 25, 2013 at 1:59 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > The existing -cpu host option caused kernel panics when people attempted to use
> > the kvm option. After research and discussion, the best options appear to
> > be the kvm32/kvm64 cpu types so lets use these instead. These resolve
> > the kernel issues for me.
> >
> > [YOCTO #3908]
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> > diff --git a/scripts/runqemu b/scripts/runqemu
> > index efab1a2..12c58d9 100755
> > --- a/scripts/runqemu
> > +++ b/scripts/runqemu
> > @@ -265,7 +265,11 @@ if [ "x$KVM_ENABLED" = "xyes" ]; then
> >          exit 1;
> >      fi
> >      if [ -w /dev/kvm -a -r /dev/kvm ]; then
> > -        SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu host"
> > +        if [ "x$MACHINE" = "xqemux86" ]; then
> > +            SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm32"
> > +        elif [ "x$MACHINE" = "xqemux86-64" ]; then
> > +            SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm64"
> > +        fi
> 
> may be leave the original in the else clause at the end so it covers
> the non x86 cases too

There is no non x86 case for kvm. Its already guarded against by code
above here which errors if its not one of these two machines...

Cheers,

Richard