* [PATCH] runqemu: Use correct kvm CPU options for qemux86* with kvm
@ 2013-09-25 20:59 Richard Purdie
2013-09-25 21:05 ` Darren Hart
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Richard Purdie @ 2013-09-25 20:59 UTC (permalink / raw)
To: openembedded-core; +Cc: Hart, Darren
The existing -cpu host option caused kernel panics when people attempted to use
the kvm option. After research and discussion, the best options appear to
be the kvm32/kvm64 cpu types so lets use these instead. These resolve
the kernel issues for me.
[YOCTO #3908]
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/scripts/runqemu b/scripts/runqemu
index efab1a2..12c58d9 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -265,7 +265,11 @@ if [ "x$KVM_ENABLED" = "xyes" ]; then
exit 1;
fi
if [ -w /dev/kvm -a -r /dev/kvm ]; then
- SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu host"
+ if [ "x$MACHINE" = "xqemux86" ]; then
+ SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm32"
+ elif [ "x$MACHINE" = "xqemux86-64" ]; then
+ SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm64"
+ fi
KVM_ACTIVE="yes"
else
echo "You have no rights on /dev/kvm."
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] runqemu: Use correct kvm CPU options for qemux86* with kvm
2013-09-25 20:59 [PATCH] runqemu: Use correct kvm CPU options for qemux86* with kvm Richard Purdie
@ 2013-09-25 21:05 ` Darren Hart
2013-09-25 21:09 ` Richard Purdie
2013-09-25 21:34 ` Khem Raj
2013-09-26 4:26 ` Bruce Ashfield
2 siblings, 1 reply; 8+ messages in thread
From: Darren Hart @ 2013-09-25 21:05 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On Wed, 2013-09-25 at 21:59 +0100, Richard Purdie wrote:
> The existing -cpu host option caused kernel panics when people attempted to use
> the kvm option. After research and discussion, the best options appear to
> be the kvm32/kvm64 cpu types so lets use these instead. These resolve
> the kernel issues for me.
>
> [YOCTO #3908]
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Makes a lot of sense to me:
Acked-by: Darren Hart <dvhart@linux.intel.com>
> ---
> diff --git a/scripts/runqemu b/scripts/runqemu
> index efab1a2..12c58d9 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -265,7 +265,11 @@ if [ "x$KVM_ENABLED" = "xyes" ]; then
> exit 1;
> fi
> if [ -w /dev/kvm -a -r /dev/kvm ]; then
> - SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu host"
> + if [ "x$MACHINE" = "xqemux86" ]; then
> + SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm32"
> + elif [ "x$MACHINE" = "xqemux86-64" ]; then
> + SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm64"
> + fi
The above is fine, but it does raise the question of dealing with non
oe-core BSPs with runqemu. For instance, there would be value in testing
genericx86 and genericx86_64 in the same way. We can deal with that
separately though I think as this solves an immediate problem and
doesn't make it any worse for the case I mention.
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] runqemu: Use correct kvm CPU options for qemux86* with kvm
2013-09-25 21:05 ` Darren Hart
@ 2013-09-25 21:09 ` Richard Purdie
2013-09-25 21:32 ` Darren Hart
0 siblings, 1 reply; 8+ messages in thread
From: Richard Purdie @ 2013-09-25 21:09 UTC (permalink / raw)
To: Darren Hart; +Cc: openembedded-core
On Wed, 2013-09-25 at 14:05 -0700, Darren Hart wrote:
> On Wed, 2013-09-25 at 21:59 +0100, Richard Purdie wrote:
> > The existing -cpu host option caused kernel panics when people attempted to use
> > the kvm option. After research and discussion, the best options appear to
> > be the kvm32/kvm64 cpu types so lets use these instead. These resolve
> > the kernel issues for me.
> >
> > [YOCTO #3908]
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> Makes a lot of sense to me:
>
> Acked-by: Darren Hart <dvhart@linux.intel.com>
>
> > ---
> > diff --git a/scripts/runqemu b/scripts/runqemu
> > index efab1a2..12c58d9 100755
> > --- a/scripts/runqemu
> > +++ b/scripts/runqemu
> > @@ -265,7 +265,11 @@ if [ "x$KVM_ENABLED" = "xyes" ]; then
> > exit 1;
> > fi
> > if [ -w /dev/kvm -a -r /dev/kvm ]; then
> > - SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu host"
> > + if [ "x$MACHINE" = "xqemux86" ]; then
> > + SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm32"
> > + elif [ "x$MACHINE" = "xqemux86-64" ]; then
> > + SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm64"
> > + fi
>
> The above is fine, but it does raise the question of dealing with non
> oe-core BSPs with runqemu. For instance, there would be value in testing
> genericx86 and genericx86_64 in the same way. We can deal with that
> separately though I think as this solves an immediate problem and
> doesn't make it any worse for the case I mention.
There is an explicit check for qemux86* just above this block so whilst
I like the idea, its something for another patch and likely 1.6
material. Could be worth an enhancement bug though.
Cheers,
Richard
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] runqemu: Use correct kvm CPU options for qemux86* with kvm
2013-09-25 21:09 ` Richard Purdie
@ 2013-09-25 21:32 ` Darren Hart
0 siblings, 0 replies; 8+ messages in thread
From: Darren Hart @ 2013-09-25 21:32 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
On Wed, 2013-09-25 at 22:09 +0100, Richard Purdie wrote:
> On Wed, 2013-09-25 at 14:05 -0700, Darren Hart wrote:
> > On Wed, 2013-09-25 at 21:59 +0100, Richard Purdie wrote:
> > > The existing -cpu host option caused kernel panics when people attempted to use
> > > the kvm option. After research and discussion, the best options appear to
> > > be the kvm32/kvm64 cpu types so lets use these instead. These resolve
> > > the kernel issues for me.
> > >
> > > [YOCTO #3908]
> > >
> > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> >
> > Makes a lot of sense to me:
> >
> > Acked-by: Darren Hart <dvhart@linux.intel.com>
> >
> > > ---
> > > diff --git a/scripts/runqemu b/scripts/runqemu
> > > index efab1a2..12c58d9 100755
> > > --- a/scripts/runqemu
> > > +++ b/scripts/runqemu
> > > @@ -265,7 +265,11 @@ if [ "x$KVM_ENABLED" = "xyes" ]; then
> > > exit 1;
> > > fi
> > > if [ -w /dev/kvm -a -r /dev/kvm ]; then
> > > - SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu host"
> > > + if [ "x$MACHINE" = "xqemux86" ]; then
> > > + SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm32"
> > > + elif [ "x$MACHINE" = "xqemux86-64" ]; then
> > > + SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm64"
> > > + fi
> >
> > The above is fine, but it does raise the question of dealing with non
> > oe-core BSPs with runqemu. For instance, there would be value in testing
> > genericx86 and genericx86_64 in the same way. We can deal with that
> > separately though I think as this solves an immediate problem and
> > doesn't make it any worse for the case I mention.
>
> There is an explicit check for qemux86* just above this block so whilst
> I like the idea, its something for another patch and likely 1.6
> material. Could be worth an enhancement bug though.
Agreed, i think that is basically covered by:
Bug 2025 - runqemu scripts should attempt sane defaults for unkown machines
>
> Cheers,
>
> Richard
>
>
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] runqemu: Use correct kvm CPU options for qemux86* with kvm
2013-09-25 20:59 [PATCH] runqemu: Use correct kvm CPU options for qemux86* with kvm Richard Purdie
2013-09-25 21:05 ` Darren Hart
@ 2013-09-25 21:34 ` Khem Raj
2013-09-25 22:00 ` Richard Purdie
2013-09-26 4:26 ` Bruce Ashfield
2 siblings, 1 reply; 8+ messages in thread
From: Khem Raj @ 2013-09-25 21:34 UTC (permalink / raw)
To: Richard Purdie; +Cc: Hart, Darren, openembedded-core
On Wed, Sep 25, 2013 at 1:59 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> The existing -cpu host option caused kernel panics when people attempted to use
> the kvm option. After research and discussion, the best options appear to
> be the kvm32/kvm64 cpu types so lets use these instead. These resolve
> the kernel issues for me.
>
> [YOCTO #3908]
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/scripts/runqemu b/scripts/runqemu
> index efab1a2..12c58d9 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -265,7 +265,11 @@ if [ "x$KVM_ENABLED" = "xyes" ]; then
> exit 1;
> fi
> if [ -w /dev/kvm -a -r /dev/kvm ]; then
> - SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu host"
> + if [ "x$MACHINE" = "xqemux86" ]; then
> + SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm32"
> + elif [ "x$MACHINE" = "xqemux86-64" ]; then
> + SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm64"
> + fi
may be leave the original in the else clause at the end so it covers
the non x86 cases too
> KVM_ACTIVE="yes"
> else
> echo "You have no rights on /dev/kvm."
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] runqemu: Use correct kvm CPU options for qemux86* with kvm
2013-09-25 21:34 ` Khem Raj
@ 2013-09-25 22:00 ` Richard Purdie
2013-09-25 22:05 ` Khem Raj
0 siblings, 1 reply; 8+ messages in thread
From: Richard Purdie @ 2013-09-25 22:00 UTC (permalink / raw)
To: Khem Raj; +Cc: Hart, Darren, openembedded-core
On Wed, 2013-09-25 at 14:34 -0700, Khem Raj wrote:
> On Wed, Sep 25, 2013 at 1:59 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > The existing -cpu host option caused kernel panics when people attempted to use
> > the kvm option. After research and discussion, the best options appear to
> > be the kvm32/kvm64 cpu types so lets use these instead. These resolve
> > the kernel issues for me.
> >
> > [YOCTO #3908]
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> > diff --git a/scripts/runqemu b/scripts/runqemu
> > index efab1a2..12c58d9 100755
> > --- a/scripts/runqemu
> > +++ b/scripts/runqemu
> > @@ -265,7 +265,11 @@ if [ "x$KVM_ENABLED" = "xyes" ]; then
> > exit 1;
> > fi
> > if [ -w /dev/kvm -a -r /dev/kvm ]; then
> > - SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu host"
> > + if [ "x$MACHINE" = "xqemux86" ]; then
> > + SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm32"
> > + elif [ "x$MACHINE" = "xqemux86-64" ]; then
> > + SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm64"
> > + fi
>
> may be leave the original in the else clause at the end so it covers
> the non x86 cases too
There is no non x86 case for kvm. Its already guarded against by code
above here which errors if its not one of these two machines...
Cheers,
Richard
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] runqemu: Use correct kvm CPU options for qemux86* with kvm
2013-09-25 22:00 ` Richard Purdie
@ 2013-09-25 22:05 ` Khem Raj
0 siblings, 0 replies; 8+ messages in thread
From: Khem Raj @ 2013-09-25 22:05 UTC (permalink / raw)
To: Richard Purdie; +Cc: Hart, Darren, openembedded-core
On Wed, Sep 25, 2013 at 3:00 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Wed, 2013-09-25 at 14:34 -0700, Khem Raj wrote:
>> On Wed, Sep 25, 2013 at 1:59 PM, Richard Purdie
>> <richard.purdie@linuxfoundation.org> wrote:
>> > The existing -cpu host option caused kernel panics when people attempted to use
>> > the kvm option. After research and discussion, the best options appear to
>> > be the kvm32/kvm64 cpu types so lets use these instead. These resolve
>> > the kernel issues for me.
>> >
>> > [YOCTO #3908]
>> >
>> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>> > ---
>> > diff --git a/scripts/runqemu b/scripts/runqemu
>> > index efab1a2..12c58d9 100755
>> > --- a/scripts/runqemu
>> > +++ b/scripts/runqemu
>> > @@ -265,7 +265,11 @@ if [ "x$KVM_ENABLED" = "xyes" ]; then
>> > exit 1;
>> > fi
>> > if [ -w /dev/kvm -a -r /dev/kvm ]; then
>> > - SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu host"
>> > + if [ "x$MACHINE" = "xqemux86" ]; then
>> > + SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm32"
>> > + elif [ "x$MACHINE" = "xqemux86-64" ]; then
>> > + SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm64"
>> > + fi
>>
>> may be leave the original in the else clause at the end so it covers
>> the non x86 cases too
>
> There is no non x86 case for kvm. Its already guarded against by code
> above here which errors if its not one of these two machines...
>
thats fine then
> Cheers,
>
> Richard
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] runqemu: Use correct kvm CPU options for qemux86* with kvm
2013-09-25 20:59 [PATCH] runqemu: Use correct kvm CPU options for qemux86* with kvm Richard Purdie
2013-09-25 21:05 ` Darren Hart
2013-09-25 21:34 ` Khem Raj
@ 2013-09-26 4:26 ` Bruce Ashfield
2 siblings, 0 replies; 8+ messages in thread
From: Bruce Ashfield @ 2013-09-26 4:26 UTC (permalink / raw)
To: Richard Purdie; +Cc: Hart, Darren, openembedded-core
On 13-09-25 4:59 PM, Richard Purdie wrote:
> The existing -cpu host option caused kernel panics when people attempted to use
> the kvm option. After research and discussion, the best options appear to
> be the kvm32/kvm64 cpu types so lets use these instead. These resolve
> the kernel issues for me.
Late to the party, and discussion, but agreed. This change looks good
for this point in 1.5.
Cheers,
Bruce
>
> [YOCTO #3908]
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/scripts/runqemu b/scripts/runqemu
> index efab1a2..12c58d9 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -265,7 +265,11 @@ if [ "x$KVM_ENABLED" = "xyes" ]; then
> exit 1;
> fi
> if [ -w /dev/kvm -a -r /dev/kvm ]; then
> - SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu host"
> + if [ "x$MACHINE" = "xqemux86" ]; then
> + SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm32"
> + elif [ "x$MACHINE" = "xqemux86-64" ]; then
> + SCRIPT_QEMU_OPT="$SCRIPT_QEMU_OPT -enable-kvm -cpu kvm64"
> + fi
> KVM_ACTIVE="yes"
> else
> echo "You have no rights on /dev/kvm."
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-09-26 4:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-25 20:59 [PATCH] runqemu: Use correct kvm CPU options for qemux86* with kvm Richard Purdie
2013-09-25 21:05 ` Darren Hart
2013-09-25 21:09 ` Richard Purdie
2013-09-25 21:32 ` Darren Hart
2013-09-25 21:34 ` Khem Raj
2013-09-25 22:00 ` Richard Purdie
2013-09-25 22:05 ` Khem Raj
2013-09-26 4:26 ` Bruce Ashfield
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox