* [PATCH 1/4] libarchive: replace += with _append for appending to OVERRIDES variables
@ 2013-10-20 10:48 Ming Liu
2013-10-20 10:48 ` [PATCH 2/4] bzip2: " Ming Liu
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Ming Liu @ 2013-10-20 10:48 UTC (permalink / raw)
To: openembedded-core
In some cases, it's unfit to use "+=" in a conditional appending, we would
end up with the variable being set rather than being appended, which is not
it mean to.
Signed-off-by: Ming Liu <ming.liu@windriver.com>
---
meta/recipes-extended/libarchive/libarchive_2.8.5.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-extended/libarchive/libarchive_2.8.5.bb b/meta/recipes-extended/libarchive/libarchive_2.8.5.bb
index 1842bf7..3bcb7fb 100644
--- a/meta/recipes-extended/libarchive/libarchive_2.8.5.bb
+++ b/meta/recipes-extended/libarchive/libarchive_2.8.5.bb
@@ -7,13 +7,13 @@ PR = "r0"
PACKAGECONFIG ?= "libxml2 zlib bz2"
-PACKAGECONFIG_class-target += "\
+PACKAGECONFIG_append_class-target = "\
${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)} \
${@base_contains('DISTRO_FEATURES', 'xattr', 'xattr', '', d)} \
${@base_contains('DISTRO_FEATURES', 'largefile', 'largefile', '', d)} \
"
-PACKAGECONFIG_class-nativesdk += "largefile"
+PACKAGECONFIG_append_class-nativesdk = " largefile"
PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl,"
PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr,"
--
1.8.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/4] bzip2: replace += with _append for appending to OVERRIDES variables
2013-10-20 10:48 [PATCH 1/4] libarchive: replace += with _append for appending to OVERRIDES variables Ming Liu
@ 2013-10-20 10:48 ` Ming Liu
2013-10-20 10:48 ` [PATCH 3/4] strace: " Ming Liu
2013-10-20 10:48 ` [PATCH 4/4] nss: don't need set SRC_URI with both += and _append Ming Liu
2 siblings, 0 replies; 6+ messages in thread
From: Ming Liu @ 2013-10-20 10:48 UTC (permalink / raw)
To: openembedded-core
In some cases, it's unfit to use "+=" in a conditional appending, we would
end up with the variable being set rather than being appended, which is not
it mean to.
Signed-off-by: Ming Liu <ming.liu@windriver.com>
---
meta/recipes-extended/bzip2/bzip2_1.0.6.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-extended/bzip2/bzip2_1.0.6.bb b/meta/recipes-extended/bzip2/bzip2_1.0.6.bb
index 4189f78..c7c5d68 100644
--- a/meta/recipes-extended/bzip2/bzip2_1.0.6.bb
+++ b/meta/recipes-extended/bzip2/bzip2_1.0.6.bb
@@ -26,7 +26,7 @@ ALTERNATIVE_PRIORITY = "100"
ALTERNATIVE_${PN} = "bunzip2 bzcat"
#install binaries to bzip2-native under sysroot for replacement-native
-EXTRA_OECONF_class-native += "--bindir=${STAGING_BINDIR_NATIVE}/${PN}"
+EXTRA_OECONF_append_class-native = " --bindir=${STAGING_BINDIR_NATIVE}/${PN}"
do_configure_prepend () {
cp ${WORKDIR}/configure.ac ${S}/
cp ${WORKDIR}/Makefile.am ${S}/
--
1.8.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/4] strace: replace += with _append for appending to OVERRIDES variables
2013-10-20 10:48 [PATCH 1/4] libarchive: replace += with _append for appending to OVERRIDES variables Ming Liu
2013-10-20 10:48 ` [PATCH 2/4] bzip2: " Ming Liu
@ 2013-10-20 10:48 ` Ming Liu
2013-10-20 10:59 ` Martin Jansa
2013-10-20 10:48 ` [PATCH 4/4] nss: don't need set SRC_URI with both += and _append Ming Liu
2 siblings, 1 reply; 6+ messages in thread
From: Ming Liu @ 2013-10-20 10:48 UTC (permalink / raw)
To: openembedded-core
In some cases, it's unfit to use "+=" in a conditional appending, we would
end up with the variable being set rather than being appended, which is not
it mean to.
Signed-off-by: Ming Liu <ming.liu@windriver.com>
---
meta/recipes-devtools/strace/strace_4.8.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/strace/strace_4.8.bb b/meta/recipes-devtools/strace/strace_4.8.bb
index 79a4ad7..aad53b7 100644
--- a/meta/recipes-devtools/strace/strace_4.8.bb
+++ b/meta/recipes-devtools/strace/strace_4.8.bb
@@ -19,7 +19,7 @@ inherit autotools ptest
RDEPENDS_${PN}-ptest += "make"
PACKAGECONFIG_class-target ?= "libaio"
-PACKAGECONFIG_class-target += "${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
+PACKAGECONFIG_append_class-target = " ${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
PACKAGECONFIG[libaio] = "--enable-aio,--disable-aio,libaio"
PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl"
--
1.8.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/4] nss: don't need set SRC_URI with both += and _append
2013-10-20 10:48 [PATCH 1/4] libarchive: replace += with _append for appending to OVERRIDES variables Ming Liu
2013-10-20 10:48 ` [PATCH 2/4] bzip2: " Ming Liu
2013-10-20 10:48 ` [PATCH 3/4] strace: " Ming Liu
@ 2013-10-20 10:48 ` Ming Liu
2 siblings, 0 replies; 6+ messages in thread
From: Ming Liu @ 2013-10-20 10:48 UTC (permalink / raw)
To: openembedded-core
Signed-off-by: Ming Liu <ming.liu@windriver.com>
---
meta/recipes-support/nss/nss.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-support/nss/nss.inc b/meta/recipes-support/nss/nss.inc
index 2b2b668..9a21976 100644
--- a/meta/recipes-support/nss/nss.inc
+++ b/meta/recipes-support/nss/nss.inc
@@ -17,7 +17,7 @@ SRC_URI = "\
file://nss-no-rpath-for-cross-compiling.patch \
file://nss-fix-incorrect-shebang-of-perl.patch \
"
-SRC_URI_append_class-target += "\
+SRC_URI_append_class-target = "\
file://nss.pc.in \
file://signlibs.sh \
"
--
1.8.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3/4] strace: replace += with _append for appending to OVERRIDES variables
2013-10-20 10:48 ` [PATCH 3/4] strace: " Ming Liu
@ 2013-10-20 10:59 ` Martin Jansa
2013-10-20 11:08 ` Ming Liu
0 siblings, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2013-10-20 10:59 UTC (permalink / raw)
To: Ming Liu; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]
On Sun, Oct 20, 2013 at 06:48:31PM +0800, Ming Liu wrote:
> In some cases, it's unfit to use "+=" in a conditional appending, we would
> end up with the variable being set rather than being appended, which is not
> it mean to.
>
> Signed-off-by: Ming Liu <ming.liu@windriver.com>
> ---
> meta/recipes-devtools/strace/strace_4.8.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/strace/strace_4.8.bb b/meta/recipes-devtools/strace/strace_4.8.bb
> index 79a4ad7..aad53b7 100644
> --- a/meta/recipes-devtools/strace/strace_4.8.bb
> +++ b/meta/recipes-devtools/strace/strace_4.8.bb
> @@ -19,7 +19,7 @@ inherit autotools ptest
> RDEPENDS_${PN}-ptest += "make"
>
> PACKAGECONFIG_class-target ?= "libaio"
> -PACKAGECONFIG_class-target += "${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
> +PACKAGECONFIG_append_class-target = " ${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
Doesn't using _append make it unnecessary harder to changed default value
in .bbappend?
Why not use
PACKAGECONFIG_class-target ?= "libaio ${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
at least in this case?
Thanks
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/4] strace: replace += with _append for appending to OVERRIDES variables
2013-10-20 10:59 ` Martin Jansa
@ 2013-10-20 11:08 ` Ming Liu
0 siblings, 0 replies; 6+ messages in thread
From: Ming Liu @ 2013-10-20 11:08 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-core
On 10/20/2013 06:59 PM, Martin Jansa wrote:
> On Sun, Oct 20, 2013 at 06:48:31PM +0800, Ming Liu wrote:
>> In some cases, it's unfit to use "+=" in a conditional appending, we would
>> end up with the variable being set rather than being appended, which is not
>> it mean to.
>>
>> Signed-off-by: Ming Liu <ming.liu@windriver.com>
>> ---
>> meta/recipes-devtools/strace/strace_4.8.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/strace/strace_4.8.bb b/meta/recipes-devtools/strace/strace_4.8.bb
>> index 79a4ad7..aad53b7 100644
>> --- a/meta/recipes-devtools/strace/strace_4.8.bb
>> +++ b/meta/recipes-devtools/strace/strace_4.8.bb
>> @@ -19,7 +19,7 @@ inherit autotools ptest
>> RDEPENDS_${PN}-ptest += "make"
>>
>> PACKAGECONFIG_class-target ?= "libaio"
>> -PACKAGECONFIG_class-target += "${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
>> +PACKAGECONFIG_append_class-target = " ${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
> Doesn't using _append make it unnecessary harder to changed default value
> in .bbappend?
>
> Why not use
> PACKAGECONFIG_class-target ?= "libaio ${@base_contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}"
> at least in this case?
Yes, it's reasonable and make things easy, I will do what you suggest in V1.
//Ming Liu
>
> Thanks
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-20 11:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-20 10:48 [PATCH 1/4] libarchive: replace += with _append for appending to OVERRIDES variables Ming Liu
2013-10-20 10:48 ` [PATCH 2/4] bzip2: " Ming Liu
2013-10-20 10:48 ` [PATCH 3/4] strace: " Ming Liu
2013-10-20 10:59 ` Martin Jansa
2013-10-20 11:08 ` Ming Liu
2013-10-20 10:48 ` [PATCH 4/4] nss: don't need set SRC_URI with both += and _append Ming Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox