From: Christopher Larson <kergoth@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH] base.bbclass: fix nondeterministic PACKAGECONFIG processing order
Date: Wed, 23 Oct 2013 13:47:27 -0700 [thread overview]
Message-ID: <1382561247-30349-1-git-send-email-kergoth@gmail.com> (raw)
The PACKAGECONFIG flags were iterated over using dict.items(), but this
returns the items in an undefined order. As this order determines the
EXTRA_OECONF append order, we can get EXTRA_OECONF which are functionally
equivalent, but whose contents differ, resulting in not using shared state
archives we should be using.
Signed-off-by: Christopher Larson <kergoth@gmail.com>
---
meta/classes/base.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index dfa580c..93bc700 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -433,7 +433,7 @@ python () {
extradeps = []
extrardeps = []
extraconf = []
- for flag, flagval in pkgconfigflags.items():
+ for flag, flagval in sorted(pkgconfigflags.items()):
if flag == "defaultval":
continue
items = flagval.split(",")
--
1.8.3.4
next reply other threads:[~2013-10-23 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 20:47 Christopher Larson [this message]
2013-12-02 21:18 ` [PATCH] base.bbclass: fix nondeterministic PACKAGECONFIG processing order Randy MacLeod
2013-12-02 22:08 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382561247-30349-1-git-send-email-kergoth@gmail.com \
--to=kergoth@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox