Re: [PATCH] base.bbclass: fix nondeterministic PACKAGECONFIG processing order

[Randy MacLeod <randy.macleod@windriver.com>]

On 13-10-23 04:47 PM, Christopher Larson wrote:
> The PACKAGECONFIG flags were iterated over using dict.items(), but this
> returns the items in an undefined order. As this order determines the
> EXTRA_OECONF append order, we can get EXTRA_OECONF which are functionally
> equivalent, but whose contents differ, resulting in not using shared state
> archives we should be using.
>
> Signed-off-by: Christopher Larson <kergoth@gmail.com>

Robert,

Can this commit be pulled into dora?
More deterministic behaviour is more supportable behaviour!

It's:
    843a5dd
    base.bbclass: fix nondeterministic PACKAGECONFIG processing order
on master.

../Randy

> ---
>   meta/classes/base.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index dfa580c..93bc700 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -433,7 +433,7 @@ python () {
>           extradeps = []
>           extrardeps = []
>           extraconf = []
> -        for flag, flagval in pkgconfigflags.items():
> +        for flag, flagval in sorted(pkgconfigflags.items()):
>               if flag == "defaultval":
>                   continue
>               items = flagval.split(",")
>


-- 
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350