* [PATCH] base.bbclass: fix nondeterministic PACKAGECONFIG processing order
@ 2013-10-23 20:47 Christopher Larson
2013-12-02 21:18 ` Randy MacLeod
0 siblings, 1 reply; 3+ messages in thread
From: Christopher Larson @ 2013-10-23 20:47 UTC (permalink / raw)
To: openembedded-core
The PACKAGECONFIG flags were iterated over using dict.items(), but this
returns the items in an undefined order. As this order determines the
EXTRA_OECONF append order, we can get EXTRA_OECONF which are functionally
equivalent, but whose contents differ, resulting in not using shared state
archives we should be using.
Signed-off-by: Christopher Larson <kergoth@gmail.com>
---
meta/classes/base.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index dfa580c..93bc700 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -433,7 +433,7 @@ python () {
extradeps = []
extrardeps = []
extraconf = []
- for flag, flagval in pkgconfigflags.items():
+ for flag, flagval in sorted(pkgconfigflags.items()):
if flag == "defaultval":
continue
items = flagval.split(",")
--
1.8.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] base.bbclass: fix nondeterministic PACKAGECONFIG processing order
2013-10-23 20:47 [PATCH] base.bbclass: fix nondeterministic PACKAGECONFIG processing order Christopher Larson
@ 2013-12-02 21:18 ` Randy MacLeod
2013-12-02 22:08 ` Otavio Salvador
0 siblings, 1 reply; 3+ messages in thread
From: Randy MacLeod @ 2013-12-02 21:18 UTC (permalink / raw)
To: openembedded-core, Robert Yang
On 13-10-23 04:47 PM, Christopher Larson wrote:
> The PACKAGECONFIG flags were iterated over using dict.items(), but this
> returns the items in an undefined order. As this order determines the
> EXTRA_OECONF append order, we can get EXTRA_OECONF which are functionally
> equivalent, but whose contents differ, resulting in not using shared state
> archives we should be using.
>
> Signed-off-by: Christopher Larson <kergoth@gmail.com>
Robert,
Can this commit be pulled into dora?
More deterministic behaviour is more supportable behaviour!
It's:
843a5dd
base.bbclass: fix nondeterministic PACKAGECONFIG processing order
on master.
../Randy
> ---
> meta/classes/base.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index dfa580c..93bc700 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -433,7 +433,7 @@ python () {
> extradeps = []
> extrardeps = []
> extraconf = []
> - for flag, flagval in pkgconfigflags.items():
> + for flag, flagval in sorted(pkgconfigflags.items()):
> if flag == "defaultval":
> continue
> items = flagval.split(",")
>
--
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] base.bbclass: fix nondeterministic PACKAGECONFIG processing order
2013-12-02 21:18 ` Randy MacLeod
@ 2013-12-02 22:08 ` Otavio Salvador
0 siblings, 0 replies; 3+ messages in thread
From: Otavio Salvador @ 2013-12-02 22:08 UTC (permalink / raw)
To: Randy MacLeod; +Cc: Patches and discussions about the oe-core layer
On Mon, Dec 2, 2013 at 7:18 PM, Randy MacLeod
<randy.macleod@windriver.com> wrote:
> On 13-10-23 04:47 PM, Christopher Larson wrote:
>>
>> The PACKAGECONFIG flags were iterated over using dict.items(), but this
>> returns the items in an undefined order. As this order determines the
>> EXTRA_OECONF append order, we can get EXTRA_OECONF which are functionally
>> equivalent, but whose contents differ, resulting in not using shared state
>> archives we should be using.
>>
>> Signed-off-by: Christopher Larson <kergoth@gmail.com>
>
>
> Robert,
>
> Can this commit be pulled into dora?
> More deterministic behaviour is more supportable behaviour!
>
> It's:
> 843a5dd
> base.bbclass: fix nondeterministic PACKAGECONFIG processing order
> on master.
I agree; this is a very good bugfix and improve sstate-cache reuse.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-02 22:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-23 20:47 [PATCH] base.bbclass: fix nondeterministic PACKAGECONFIG processing order Christopher Larson
2013-12-02 21:18 ` Randy MacLeod
2013-12-02 22:08 ` Otavio Salvador
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox