* [PATCH 2/3] ltp: Fix aarch64 build
2013-10-21 8:16 [PATCH 1/3] ltp: cleanup recipe Riku Voipio
@ 2013-10-21 8:16 ` Riku Voipio
2013-10-21 8:16 ` [PATCH 3/3] ltp: enable power management and realtime tests Riku Voipio
2013-10-21 22:42 ` [PATCH 1/3] ltp: cleanup recipe Khem Raj
2 siblings, 0 replies; 7+ messages in thread
From: Riku Voipio @ 2013-10-21 8:16 UTC (permalink / raw)
To: openembedded-core; +Cc: patches
Add backported patch from upstream to allow building on ltp Aarch64.
---
meta/recipes-extended/ltp/files/fix-arm64.patch | 59 +++++++++++++++++++++++++
meta/recipes-extended/ltp/ltp_20130904.bb | 1 +
2 files changed, 60 insertions(+)
create mode 100644 meta/recipes-extended/ltp/files/fix-arm64.patch
diff --git a/meta/recipes-extended/ltp/files/fix-arm64.patch b/meta/recipes-extended/ltp/files/fix-arm64.patch
new file mode 100644
index 0000000..383467d
--- /dev/null
+++ b/meta/recipes-extended/ltp/files/fix-arm64.patch
@@ -0,0 +1,59 @@
+Upstream-Status: Backport
+
+commit e5c18eaa4b8f9f73516eaf68213d6beee80cf3b5
+Author: Riku Voipio <riku.voipio@linaro.org>
+Date: Fri Oct 11 12:09:08 2013 +0300
+
+ Remove bogus Aarch64 system call numbers
+
+ Aarch64 build fails with:
+
+ cacheflush01.c:52:26: fatal error: asm/cachectl.h: No such file or directory
+ #include <asm/cachectl.h>
+
+ This is caused by bogus definitions of cacheflush and set_tls, which are
+ private 32bit ARM system calls. These should not be used on native
+ Aarch64 binaries. If they need to be tested, it is better done using ltp
+ compiled for 32bit ARM.
+
+ Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
+ Signed-off-by: Mike Frysinger <vapier@gentoo.org>
+
+
+Index: ltp-full-20130904/testcases/kernel/include/aarch64.in
+===================================================================
+--- ltp-full-20130904.orig/testcases/kernel/include/aarch64.in 2013-09-04 10:18:22.000000000 +0300
++++ ltp-full-20130904/testcases/kernel/include/aarch64.in 2013-10-11 11:20:47.565921406 +0300
+@@ -253,5 +253,3 @@
+ syncfs 267
+ setns 268
+ sendmmsg 269
+-cacheflush 0x1002
+-set_tls 0x1005
+Index: ltp-full-20130904/testcases/kernel/include/linux_syscall_numbers.h
+===================================================================
+--- ltp-full-20130904.orig/testcases/kernel/include/linux_syscall_numbers.h 2013-09-04 10:18:22.000000000 +0300
++++ ltp-full-20130904/testcases/kernel/include/linux_syscall_numbers.h 2013-10-11 11:22:20.013925880 +0300
+@@ -801,12 +801,6 @@
+ # ifndef __NR_sendmmsg
+ # define __NR_sendmmsg 269
+ # endif
+-# ifndef __NR_cacheflush
+-# define __NR_cacheflush 0x1002
+-# endif
+-# ifndef __NR_set_tls
+-# define __NR_set_tls 0x1005
+-# endif
+ #endif
+
+
+@@ -12754,9 +12748,6 @@
+ # ifndef __NR_settimeofday
+ # define __NR_settimeofday __LTP__NR_INVALID_SYSCALL
+ # endif
+-# ifndef __NR_set_tls
+-# define __NR_set_tls __LTP__NR_INVALID_SYSCALL
+-# endif
+ # ifndef __NR_setuid
+ # define __NR_setuid __LTP__NR_INVALID_SYSCALL
+ # endif
diff --git a/meta/recipes-extended/ltp/ltp_20130904.bb b/meta/recipes-extended/ltp/ltp_20130904.bb
index 43fe780..cf016f9 100644
--- a/meta/recipes-extended/ltp/ltp_20130904.bb
+++ b/meta/recipes-extended/ltp/ltp_20130904.bb
@@ -22,6 +22,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
DEPENDS = "attr libaio libcap acl openssl"
SRC_URI = "${SOURCEFORGE_MIRROR}/project/ltp/LTP%20Source/ltp-${PV}/ltp-full-${PV}.tar.bz2 \
+ file://fix-arm64.patch \
"
SRC_URI[md5sum] = "0cf2ccb7199f8318d413c62a085629f0"
--
1.8.3.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 3/3] ltp: enable power management and realtime tests
2013-10-21 8:16 [PATCH 1/3] ltp: cleanup recipe Riku Voipio
2013-10-21 8:16 ` [PATCH 2/3] ltp: Fix aarch64 build Riku Voipio
@ 2013-10-21 8:16 ` Riku Voipio
2013-10-21 22:42 ` [PATCH 1/3] ltp: cleanup recipe Khem Raj
2 siblings, 0 replies; 7+ messages in thread
From: Riku Voipio @ 2013-10-21 8:16 UTC (permalink / raw)
To: openembedded-core; +Cc: patches
ltp includes realtime and power management tests,
that are somewhat experimental and not enabled by default.
Add the configuration options to enable them, and a backported
patch that allows compilation with more pedantic toolchains.
You will still need to run the realtime tests explicitly,
so this should have no impact on people not interested in
testing realtime features.
---
meta/recipes-extended/ltp/files/fix-pm-tests.patch | 30 ++++++++++++++++++++++
meta/recipes-extended/ltp/ltp_20130904.bb | 2 ++
2 files changed, 32 insertions(+)
create mode 100644 meta/recipes-extended/ltp/files/fix-pm-tests.patch
diff --git a/meta/recipes-extended/ltp/files/fix-pm-tests.patch b/meta/recipes-extended/ltp/files/fix-pm-tests.patch
new file mode 100644
index 0000000..e8f80de
--- /dev/null
+++ b/meta/recipes-extended/ltp/files/fix-pm-tests.patch
@@ -0,0 +1,30 @@
+Upstream-Status: Backport
+
+commit 6f3147f01229f3bb953202cde828d35e0d2bcb8a
+Author: Riku Voipio <riku.voipio@linaro.org>
+Date: Mon Oct 14 11:50:28 2013 +0300
+
+ power_management: add TCID
+
+ get_sched_values.c uses interfaces provided by -lltp which need
+ TCID defined. Not sure how this built successfully before.
+
+ [v2] correct TCID to an unique one
+
+ Cc: Wanlong Gao <gaowanlong@cn.fujitsu.com>
+ Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
+ Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
+
+Index: ltp-full-20130904/testcases/kernel/power_management/get_sched_values.c
+===================================================================
+--- ltp-full-20130904.orig/testcases/kernel/power_management/get_sched_values.c 2013-09-04 10:18:22.000000000 +0300
++++ ltp-full-20130904/testcases/kernel/power_management/get_sched_values.c 2013-10-11 14:57:40.890551214 +0300
+@@ -17,6 +17,8 @@
+ #include <stdio.h>
+ #include "test.h"
+
++const char *TCID = "Power_Management";
++
+ int get_supp_sched_mc(void)
+ {
+ if (tst_kvercmp(2, 6, 29) < 0)
diff --git a/meta/recipes-extended/ltp/ltp_20130904.bb b/meta/recipes-extended/ltp/ltp_20130904.bb
index cf016f9..be553df 100644
--- a/meta/recipes-extended/ltp/ltp_20130904.bb
+++ b/meta/recipes-extended/ltp/ltp_20130904.bb
@@ -23,6 +23,7 @@ DEPENDS = "attr libaio libcap acl openssl"
SRC_URI = "${SOURCEFORGE_MIRROR}/project/ltp/LTP%20Source/ltp-${PV}/ltp-full-${PV}.tar.bz2 \
file://fix-arm64.patch \
+ file://fix-pm-tests.patch \
"
SRC_URI[md5sum] = "0cf2ccb7199f8318d413c62a085629f0"
@@ -36,6 +37,7 @@ inherit autotools
S = "${WORKDIR}/ltp-full-${PV}"
TARGET_CC_ARCH += "${LDFLAGS}"
+EXTRA_OECONF = " --with-power-management-testsuite --with-realtime-testsuite "
do_install(){
install -d ${D}/opt/ltp/
--
1.8.3.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/3] ltp: cleanup recipe
2013-10-21 8:16 [PATCH 1/3] ltp: cleanup recipe Riku Voipio
2013-10-21 8:16 ` [PATCH 2/3] ltp: Fix aarch64 build Riku Voipio
2013-10-21 8:16 ` [PATCH 3/3] ltp: enable power management and realtime tests Riku Voipio
@ 2013-10-21 22:42 ` Khem Raj
2013-10-22 7:37 ` Riku Voipio
2 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2013-10-21 22:42 UTC (permalink / raw)
To: Riku Voipio; +Cc: patches@linaro.org, openembedded-core@lists.openembedded.org
[-- Attachment #1: Type: text/plain, Size: 5145 bytes --]
On Monday, October 21, 2013, Riku Voipio <riku.voipio@linaro.org> wrote:
> Cleanups for ltp:
>
> 1. Instead of using giturl like in Anders's patch use the sourceforge
mirror URL.
whats wrong with git url ?
> 2. remove to the manual unpack rule and just set S variable to source
directory.
> 3. Follow the OE style guide for variable order.
> ---
> meta/recipes-extended/ltp/ltp_20130904.bb | 50
+++++++++++++------------------
> 1 file changed, 21 insertions(+), 29 deletions(-)
>
> diff --git a/meta/recipes-extended/ltp/ltp_20130904.bbb/meta/recipes-extended/ltp/
ltp_20130904.bb
> index 5e10448..43fe780 100644
> --- a/meta/recipes-extended/ltp/ltp_20130904.bb
> +++ b/meta/recipes-extended/ltp/ltp_20130904.bb
> @@ -21,44 +21,21 @@ LIC_FILES_CHKSUM =
"file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
>
> DEPENDS = "attr libaio libcap acl openssl"
>
> -SRC_URI = "git://github.com/linux-test-project/ltp.git"
> +SRC_URI =
"${SOURCEFORGE_MIRROR}/project/ltp/LTP%20Source/ltp-${PV}/ltp-full-${PV}.tar.bz2
\
> + "
>
> -SRCREV = "a8c42db5f9314211811c36275a21f83902830dc5"
> -S = "${WORKDIR}/git"
> +SRC_URI[md5sum] = "0cf2ccb7199f8318d413c62a085629f0"
> +SRC_URI[sha256sum] =
"662c3661a4d1bfbf3187d0835f35e613b43eedc35a840e3283e378a19606ee0b"
>
> export prefix = "/opt/ltp"
> export exec_prefix = "/opt/ltp"
>
> inherit autotools
>
> -RDEPENDS_${PN} = "perl e2fsprogs-mke2fs"
> -
> -FILES_${PN}-dbg += "/opt/ltp/runtest/.debug"
> -FILES_${PN}-dbg += "/opt/ltp/testcases/bin/.debug"
> -FILES_${PN}-dbg += "/opt/ltp/testcases/bin/*/bin/.debug"
> -FILES_${PN}-dbg += "/opt/ltp/testcases/bin/*/test/.debug"
> -FILES_${PN}-dbg += "/opt/ltp/scenario_groups/.debug"
> -FILES_${PN}-dbg += "/opt/ltp/testscripts/.debug"
> -FILES_${PN}-dbg += "/opt/ltp/testscripts/open_posix_testsuite/.debug"
> -
> -FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a"
> -
> -FILES_${PN} += "/opt/ltp/* /opt/ltp/runtest/* /opt/ltp/scenario_groups/*
/opt/ltp/testcases/bin/* /opt/ltp/testcases/bin/*/bin/*
/opt/ltp/testscripts/* /opt/ltp/testcases/open_posix_testsuite/*
/opt/ltp/testcases/open_posix_testsuite/conformance/*
/opt/ltp/testcases/open_posix_testsuite/Documentation/*
/opt/ltp/testcases/open_posix_testsuite/functional/*
/opt/ltp/testcases/open_posix_testsuite/include/*
/opt/ltp/testcases/open_posix_testsuite/scripts/*
/opt/ltp/testcases/open_posix_testsuite/stress/*
/opt/ltp/testcases/open_posix_testsuite/tools/*"
> +S = "${WORKDIR}/ltp-full-${PV}"
>
> TARGET_CC_ARCH += "${LDFLAGS}"
>
> -do_unpack_append() {
> - bb.build.exec_func('do_extract_tarball', d)
> -}
> -
> -do_extract_tarball() {
> - if test -f ${WORKDIR}/ltp-full-${PV} ; then
> - tar x --no-same-owner -f ${WORKDIR}/ltp-full-${PV} -C
${WORKDIR}
> - rm -rf ${WORKDIR}/ltp-${PV}
> - mv ${WORKDIR}/ltp-full-${PV} ${WORKDIR}/ltp-${PV}
> - fi
> -}
> -
> do_install(){
> install -d ${D}/opt/ltp/
> oe_runmake DESTDIR=${D} SKIP_IDCHECK=1 install
> @@ -66,10 +43,25 @@ do_install(){
> # Copy POSIX test suite into ${D}/opt/ltp/testcases by manual
> cp -r testcases/open_posix_testsuite ${D}/opt/ltp/testcases
>
> - # We need to remove all scripts which depend on /usr/bin/expect,
since expect is not supported in poky
> + # We need to remove all scripts which depend on /usr/bin/expect,
since expect is not supported in oe-core
> # We will add expect for enhancement in future
> find ${D} -type f -print | xargs grep "\!.*\/usr\/bin\/expect" |
awk -F":" '{print $1}' | xargs rm -f
> }
>
> +FILES_${PN}-dbg += "/opt/ltp/runtest/.debug \
> + /opt/ltp/testcases/bin/.debug \
> + /opt/ltp/testcases/bin/*/bin/.debug \
> + /opt/ltp/testcases/bin/*/test/.debug \
> + /opt/ltp/scenario_groups/.debug \
> + /opt/ltp/testscripts/.debug \
> + /opt/ltp/testscripts/open_posix_testsuite/.debug \
> + "
> +
> +FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a"
> +
> +FILES_${PN} += "/opt/ltp/* /opt/ltp/runtest/* /opt/ltp/scenario_groups/*
/opt/ltp/testcases/bin/* /opt/ltp/testcases/bin/*/bin/*
/opt/ltp/testscripts/* /opt/ltp/testcases/open_posix_testsuite/*
/opt/ltp/testcases/open_posix_testsuite/conformance/*
/opt/ltp/testcases/open_posix_testsuite/Documentation/*
/opt/ltp/testcases/open_posix_testsuite/functional/*
/opt/ltp/testcases/open_posix_testsuite/include/*
/opt/ltp/testcases/open_posix_testsuite/scripts/*
/opt/ltp/testcases/open_posix_testsuite/stress/*
/opt/ltp/testcases/open_posix_testsuite/tools/*"
> +
> +RDEPENDS_${PN} = "perl e2fsprogs-mke2fs"
> +
> # Avoid generated binaries stripping. Otherwise some of the ltp tests
such as ldd01 & nm01 fails
> INHIBIT_PACKAGE_STRIP = "1"
> --
> 1.8.3.1
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 6543 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/3] ltp: cleanup recipe
2013-10-21 22:42 ` [PATCH 1/3] ltp: cleanup recipe Khem Raj
@ 2013-10-22 7:37 ` Riku Voipio
2013-10-22 9:34 ` Khem Raj
2013-10-24 7:36 ` Richard Purdie
0 siblings, 2 replies; 7+ messages in thread
From: Riku Voipio @ 2013-10-22 7:37 UTC (permalink / raw)
To: Khem Raj; +Cc: patches@linaro.org, openembedded-core@lists.openembedded.org
On 22 October 2013 01:42, Khem Raj <raj.khem@gmail.com> wrote:
> On Monday, October 21, 2013, Riku Voipio <riku.voipio@linaro.org> wrote:
>> Cleanups for ltp:
>>
>> 1. Instead of using giturl like in Anders's patch use the sourceforge
>> mirror URL.
>
> whats wrong with git url ?
The previous LTP version in OE used to have tarball url, so I was just
changing it back. I guess the main functional difference is that git
url won't have checksums for downloads? Using tarball downloads over
git checkouts is being more kind to upstream hosting. Mostly a matter
of taste, or does OE-core have some preferred policy?
Riku
>> 2. remove to the manual unpack rule and just set S variable to source
>> directory.
>> 3. Follow the OE style guide for variable order.
>> ---
>> meta/recipes-extended/ltp/ltp_20130904.bb | 50
>> +++++++++++++------------------
>> 1 file changed, 21 insertions(+), 29 deletions(-)
>>
>> diff --git a/meta/recipes-extended/ltp/ltp_20130904.bb
>> b/meta/recipes-extended/ltp/ltp_20130904.bb
>> index 5e10448..43fe780 100644
>> --- a/meta/recipes-extended/ltp/ltp_20130904.bb
>> +++ b/meta/recipes-extended/ltp/ltp_20130904.bb
>> @@ -21,44 +21,21 @@ LIC_FILES_CHKSUM =
>> "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
>>
>> DEPENDS = "attr libaio libcap acl openssl"
>>
>> -SRC_URI = "git://github.com/linux-test-project/ltp.git"
>> +SRC_URI =
>> "${SOURCEFORGE_MIRROR}/project/ltp/LTP%20Source/ltp-${PV}/ltp-full-${PV}.tar.bz2
>> \
>> + "
>>
>> -SRCREV = "a8c42db5f9314211811c36275a21f83902830dc5"
>> -S = "${WORKDIR}/git"
>> +SRC_URI[md5sum] = "0cf2ccb7199f8318d413c62a085629f0"
>> +SRC_URI[sha256sum] =
>> "662c3661a4d1bfbf3187d0835f35e613b43eedc35a840e3283e378a19606ee0b"
>>
>> export prefix = "/opt/ltp"
>> export exec_prefix = "/opt/ltp"
>>
>> inherit autotools
>>
>> -RDEPENDS_${PN} = "perl e2fsprogs-mke2fs"
>> -
>> -FILES_${PN}-dbg += "/opt/ltp/runtest/.debug"
>> -FILES_${PN}-dbg += "/opt/ltp/testcases/bin/.debug"
>> -FILES_${PN}-dbg += "/opt/ltp/testcases/bin/*/bin/.debug"
>> -FILES_${PN}-dbg += "/opt/ltp/testcases/bin/*/test/.debug"
>> -FILES_${PN}-dbg += "/opt/ltp/scenario_groups/.debug"
>> -FILES_${PN}-dbg += "/opt/ltp/testscripts/.debug"
>> -FILES_${PN}-dbg += "/opt/ltp/testscripts/open_posix_testsuite/.debug"
>> -
>> -FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a"
>> -
>> -FILES_${PN} += "/opt/ltp/* /opt/ltp/runtest/* /opt/ltp/scenario_groups/*
>> /opt/ltp/testcases/bin/* /opt/ltp/testcases/bin/*/bin/*
>> /opt/ltp/testscripts/* /opt/ltp/testcases/open_posix_testsuite/*
>> /opt/ltp/testcases/open_posix_testsuite/conformance/*
>> /opt/ltp/testcases/open_posix_testsuite/Documentation/*
>> /opt/ltp/testcases/open_posix_testsuite/functional/*
>> /opt/ltp/testcases/open_posix_testsuite/include/*
>> /opt/ltp/testcases/open_posix_testsuite/scripts/*
>> /opt/ltp/testcases/open_posix_testsuite/stress/*
>> /opt/ltp/testcases/open_posix_testsuite/tools/*"
>> +S = "${WORKDIR}/ltp-full-${PV}"
>>
>> TARGET_CC_ARCH += "${LDFLAGS}"
>>
>> -do_unpack_append() {
>> - bb.build.exec_func('do_extract_tarball', d)
>> -}
>> -
>> -do_extract_tarball() {
>> - if test -f ${WORKDIR}/ltp-full-${PV} ; then
>> - tar x --no-same-owner -f ${WORKDIR}/ltp-full-${PV} -C
>> ${WORKDIR}
>> - rm -rf ${WORKDIR}/ltp-${PV}
>> - mv ${WORKDIR}/ltp-full-${PV} ${WORKDIR}/ltp-${PV}
>> - fi
>> -}
>> -
>> do_install(){
>> install -d ${D}/opt/ltp/
>> oe_runmake DESTDIR=${D} SKIP_IDCHECK=1 install
>> @@ -66,10 +43,25 @@ do_install(){
>> # Copy POSIX test suite into ${D}/opt/ltp/testcases by manual
>> cp -r testcases/open_posix_testsuite ${D}/opt/ltp/testcases
>>
>> - # We need to remove all scripts which depend on /usr/bin/expect,
>> since expect is not supported in poky
>> + # We need to remove all scripts which depend on /usr/bin/expect,
>> since expect is not supported in oe-core
>> # We will add expect for enhancement in future
>> find ${D} -type f -print | xargs grep "\!.*\/usr\/bin\/expect" |
>> awk -F":" '{print $1}' | xargs rm -f
>> }
>>
>> +FILES_${PN}-dbg += "/opt/ltp/runtest/.debug \
>> + /opt/ltp/testcases/bin/.debug \
>> + /opt/ltp/testcases/bin/*/bin/.debug \
>> + /opt/ltp/testcases/bin/*/test/.debug \
>> + /opt/ltp/scenario_groups/.debug \
>> + /opt/ltp/testscripts/.debug \
>> + /opt/ltp/testscripts/open_posix_testsuite/.debug \
>> + "
>> +
>> +FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a"
>> +
>> +FILES_${PN} += "/opt/ltp/* /opt/ltp/runtest/* /opt/ltp/scenario_groups/*
>> /opt/ltp/testcases/bin/* /opt/ltp/testcases/bin/*/bin/*
>> /opt/ltp/testscripts/* /opt/ltp/testcases/open_posix_testsuite/*
>> /opt/ltp/testcases/open_posix_testsuite/conformance/*
>> /opt/ltp/testcases/open_posix_testsuite/Documentation/*
>> /opt/ltp/testcases/open_posix_testsuite/functional/*
>> /opt/ltp/testcases/open_posix_testsuite/include/*
>> /opt/ltp/testcases/open_posix_testsuite/scripts/*
>> /opt/ltp/testcases/open_posix_testsuite/stress/*
>> /opt/ltp/testcases/open_posix_testsuite/tools/*"
>> +
>> +RDEPENDS_${PN} = "perl e2fsprogs-mke2fs"
>> +
>> # Avoid generated binaries stripping. Otherwise some of the ltp tests
>> such as ldd01 & nm01 fails
>> INHIBIT_PACKAGE_STRIP = "1"
>> --
>> 1.8.3.1
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/3] ltp: cleanup recipe
2013-10-22 7:37 ` Riku Voipio
@ 2013-10-22 9:34 ` Khem Raj
2013-10-24 7:36 ` Richard Purdie
1 sibling, 0 replies; 7+ messages in thread
From: Khem Raj @ 2013-10-22 9:34 UTC (permalink / raw)
To: Riku Voipio; +Cc: patches@linaro.org, openembedded-core@lists.openembedded.org
[-- Attachment #1: Type: text/plain, Size: 4060 bytes --]
On Tuesday, October 22, 2013, Riku Voipio <riku.voipio@linaro.org> wrote:
> On 22 October 2013 01:42, Khem Raj <raj.khem@gmail.com> wrote:
>> On Monday, October 21, 2013, Riku Voipio <riku.voipio@linaro.org> wrote:
>>> Cleanups for ltp:
>>>
>>> 1. Instead of using giturl like in Anders's patch use the sourceforge
>>> mirror URL.
>>
>> whats wrong with git url ?
>
> The previous LTP version in OE used to have tarball url, so I was just
> changing it back. I guess the main functional difference is that git
> url won't have checksums for downloads? Using tarball downloads over
> git checkouts is being more kind to upstream hosting. Mostly a matter
> of taste, or does OE-core have some preferred policy?
i dont think there is any preference i was thinking if git had issues
>
> Riku
>
>>> 2. remove to the manual unpack rule and just set S variable to source
>>> directory.
>>> 3. Follow the OE style guide for variable order.
>>> ---
>>> meta/recipes-extended/ltp/ltp_20130904.bb | 50
>>> +++++++++++++------------------
>>> 1 file changed, 21 insertions(+), 29 deletions(-)
>>>
>>> diff --git a/meta/recipes-extended/ltp/ltp_20130904.bb
>>> b/meta/recipes-extended/ltp/ltp_20130904.bb
>>> index 5e10448..43fe780 100644
>>> --- a/meta/recipes-extended/ltp/ltp_20130904.bb
>>> +++ b/meta/recipes-extended/ltp/ltp_20130904.bb
>>> @@ -21,44 +21,21 @@ LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
>>>
>>> DEPENDS = "attr libaio libcap acl openssl"
>>>
>>> -SRC_URI = "git://github.com/linux-test-project/ltp.git"
>>> +SRC_URI =
>>>
"${SOURCEFORGE_MIRROR}/project/ltp/LTP%20Source/ltp-${PV}/ltp-full-${PV}.tar.bz2
>>> \
>>> + "
>>>
>>> -SRCREV = "a8c42db5f9314211811c36275a21f83902830dc5"
>>> -S = "${WORKDIR}/git"
>>> +SRC_URI[md5sum] = "0cf2ccb7199f8318d413c62a085629f0"
>>> +SRC_URI[sha256sum] =
>>> "662c3661a4d1bfbf3187d0835f35e613b43eedc35a840e3283e378a19606ee0b"
>>>
>>> export prefix = "/opt/ltp"
>>> export exec_prefix = "/opt/ltp"
>>>
>>> inherit autotools
>>>
>>> -RDEPENDS_${PN} = "perl e2fsprogs-mke2fs"
>>> -
>>> -FILES_${PN}-dbg += "/opt/ltp/runtest/.debug"
>>> -FILES_${PN}-dbg += "/opt/ltp/testcases/bin/.debug"
>>> -FILES_${PN}-dbg += "/opt/ltp/testcases/bin/*/bin/.debug"
>>> -FILES_${PN}-dbg += "/opt/ltp/testcases/bin/*/test/.debug"
>>> -FILES_${PN}-dbg += "/opt/ltp/scenario_groups/.debug"
>>> -FILES_${PN}-dbg += "/opt/ltp/testscripts/.debug"
>>> -FILES_${PN}-dbg += "/opt/ltp/testscripts/open_posix_testsuite/.debug"
>>> -
>>> -FILES_${PN}-staticdev += "/opt/ltp/lib/libmem.a"
>>> -
>>> -FILES_${PN} += "/opt/ltp/* /opt/ltp/runtest/*
/opt/ltp/scenario_groups/*
>>> /opt/ltp/testcases/bin/* /opt/ltp/testcases/bin/*/bin/*
>>> /opt/ltp/testscripts/* /opt/ltp/testcases/open_posix_testsuite/*
>>> /opt/ltp/testcases/open_posix_testsuite/conformance/*
>>> /opt/ltp/testcases/open_posix_testsuite/Documentation/*
>>> /opt/ltp/testcases/open_posix_testsuite/functional/*
>>> /opt/ltp/testcases/open_posix_testsuite/include/*
>>> /opt/ltp/testcases/open_posix_testsuite/scripts/*
>>> /opt/ltp/testcases/open_posix_testsuite/stress/*
>>> /opt/ltp/testcases/open_posix_testsuite/tools/*"
>>> +S = "${WORKDIR}/ltp-full-${PV}"
>>>
>>> TARGET_CC_ARCH += "${LDFLAGS}"
>>>
>>> -do_unpack_append() {
>>> - bb.build.exec_func('do_extract_tarball', d)
>>> -}
>>> -
>>> -do_extract_tarball() {
>>> - if test -f ${WORKDIR}/ltp-full-${PV} ; then
>>> - tar x --no-same-owner -f ${WORKDIR}/ltp-full-${PV} -C
>>> ${WORKDIR}
>>> - rm -rf ${WORKDIR}/ltp-${PV}
>>> - mv ${WORKDIR}/ltp-full-${PV} ${WORKDIR}/ltp-${PV}
>>> - fi
>>> -}
>>> -
>>> do_install(){
>>> install -d ${D}/opt/ltp/
>>> oe_runmake DESTDIR=${D} SKIP_IDCHECK=1 install
>>> @@ -66,10 +43,25 @@ do_install(){
>>> # Copy POSIX test suite into ${D}/opt/ltp/testcases by manual
>>> cp -r testcases/open_posix_testsuite ${D}/opt/ltp/testcases
>>>
>>> - # We
[-- Attachment #2: Type: text/html, Size: 5812 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/3] ltp: cleanup recipe
2013-10-22 7:37 ` Riku Voipio
2013-10-22 9:34 ` Khem Raj
@ 2013-10-24 7:36 ` Richard Purdie
1 sibling, 0 replies; 7+ messages in thread
From: Richard Purdie @ 2013-10-24 7:36 UTC (permalink / raw)
To: Riku Voipio; +Cc: openembedded-core@lists.openembedded.org, patches@linaro.org
On Tue, 2013-10-22 at 10:37 +0300, Riku Voipio wrote:
> On 22 October 2013 01:42, Khem Raj <raj.khem@gmail.com> wrote:
> > On Monday, October 21, 2013, Riku Voipio <riku.voipio@linaro.org> wrote:
> >> Cleanups for ltp:
> >>
> >> 1. Instead of using giturl like in Anders's patch use the sourceforge
> >> mirror URL.
> >
> > whats wrong with git url ?
>
> The previous LTP version in OE used to have tarball url, so I was just
> changing it back. I guess the main functional difference is that git
> url won't have checksums for downloads? Using tarball downloads over
> git checkouts is being more kind to upstream hosting. Mostly a matter
> of taste, or does OE-core have some preferred policy?
The recipe recently changed from using tarballs to using git. There was
a reason for it although offhand, I don't remember what it was. I think
it was mentioned on the list. I just looked at the commit and sadly it
wasn't mentioned there (it should have been). It would be good to decide
which approach the recipe should be using and stick with that...
Cheers,
Richard
^ permalink raw reply [flat|nested] 7+ messages in thread