[PATCH 1/5] gnome: set UNKNOWN_CONFIGURE_WHITELIST

[PATCH 1/5] gnome: set UNKNOWN_CONFIGURE_WHITELIST

[Ross Burton]

This class passes --disable-introspection to everything that inherits it but not
all GNOME modules support introspection, so add that option to the
unknown-configure-options sanity test whitelist.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/classes/gnome.bbclass |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/classes/gnome.bbclass b/meta/classes/gnome.bbclass
index a19dd17..0de22dd 100644
--- a/meta/classes/gnome.bbclass
+++ b/meta/classes/gnome.bbclass
@@ -1,3 +1,5 @@
 inherit gnomebase gtk-icon-cache gconf mime
 
-EXTRA_OECONF += "--enable-introspection=no"
+EXTRA_OECONF += "--disable-introspection"
+
+UNKNOWN_CONFIGURE_WHITELIST += "--disable-introspection"
-- 
1.7.10.4

[PATCH 2/5] xorg-lib-common: set UNKNOWN_CONFIGURE_WHITELIST

[Ross Burton]

This include adds configure options globally but not all X libraries support
them, so to avoid unknown-configure-option warnings add them to the whitelist.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-graphics/xorg-lib/xorg-lib-common.inc |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc b/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc
index 98e1416..07b0373 100644
--- a/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc
+++ b/meta/recipes-graphics/xorg-lib/xorg-lib-common.inc
@@ -17,6 +17,9 @@ EXTRA_OECONF = "--disable-specs --without-groff --without-ps2pdf --without-fop -
 EXTRA_OECONF_append_libc-glibc = " --disable-malloc0returnsnull"
 EXTRA_OECONF_append_libc-uclibc = " --enable-malloc0returnsnull"
 
+UNKNOWN_CONFIGURE_WHITELIST += "--enable-malloc0returnsnull --disable-malloc0returnsnull \
+                                --disable-specs --without-groff --without-ps2pdf --without-fop --without-xmlto"
+
 python () {
         whitelist = [ "pixman", "libpciaccess" ]
         if not d.getVar('BPN', True) in whitelist and not oe.utils.contains ('DISTRO_FEATURES', 'x11', True, False, d):
-- 
1.7.10.4

[PATCH 3/5] xorg-proto-common: set UNKNOWN_CONFIGURE_WHITELIST

[Ross Burton]

This include adds configure options globally but not all X libraries support
them, so to avoid unknown-configure-option warnings add them to the whitelist.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-graphics/xorg-proto/xorg-proto-common.inc |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/xorg-proto/xorg-proto-common.inc b/meta/recipes-graphics/xorg-proto/xorg-proto-common.inc
index 856f4d8..4680d0e 100644
--- a/meta/recipes-graphics/xorg-proto/xorg-proto-common.inc
+++ b/meta/recipes-graphics/xorg-proto/xorg-proto-common.inc
@@ -14,7 +14,9 @@ S = "${WORKDIR}/${XORG_PN}-${PV}"
 DEPENDS = "util-macros"
 
 inherit autotools pkgconfig
-EXTRA_OECONF = "--with-fop=no --without-xmlto"
+EXTRA_OECONF = "--without-fop --without-xmlto"
+
+UNKNOWN_CONFIGURE_WHITELIST += "--without-fop --without-xmlto"
 
 # ${PN} is empty so we need to tweak -dev and -dbg package dependencies
 RDEPENDS_${PN}-dev = ""
-- 
1.7.10.4

Re: [PATCH 3/5] xorg-proto-common: set UNKNOWN_CONFIGURE_WHITELIST

[Otavio Salvador]

On Mon, Oct 28, 2013 at 12:33 PM, Ross Burton <ross.burton@intel.com> wrote:
> This include adds configure options globally but not all X libraries support
> them, so to avoid unknown-configure-option warnings add them to the whitelist.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>

Does not match with the commit log.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

[PATCH 4/5] gnome-common: inhert gnomebase not gnome

[Ross Burton]

This recipe doesn't need any of the helpers that come with gnome (GConf, icons,
MIME, etc), so just inherit gnomebase.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-gnome/gnome/gnome-common_3.7.4.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-gnome/gnome/gnome-common_3.7.4.bb b/meta/recipes-gnome/gnome/gnome-common_3.7.4.bb
index ebf343e..af5d340 100644
--- a/meta/recipes-gnome/gnome/gnome-common_3.7.4.bb
+++ b/meta/recipes-gnome/gnome/gnome-common_3.7.4.bb
@@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
 SECTION = "x11/gnome"
 PR = "r0"
-inherit gnome allarch
+inherit gnomebase allarch
 
 GNOME_COMPRESS_TYPE = "xz"
 
-- 
1.7.10.4

[PATCH 5/5] libgcrypt: remove --without-pth

[Ross Burton]

This isn't recognised by configure, and the random number daemon that requires
Pth isn't enabled.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-support/libgcrypt/libgcrypt.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-support/libgcrypt/libgcrypt.inc b/meta/recipes-support/libgcrypt/libgcrypt.inc
index 6a0e0cf..e0dfec2 100644
--- a/meta/recipes-support/libgcrypt/libgcrypt.inc
+++ b/meta/recipes-support/libgcrypt/libgcrypt.inc
@@ -15,7 +15,7 @@ SRC_URI = "ftp://ftp.gnupg.org/gcrypt/libgcrypt/libgcrypt-${PV}.tar.gz \
 
 inherit autotools binconfig pkgconfig
 
-EXTRA_OECONF = "--without-pth --disable-asm --with-capabilities"
+EXTRA_OECONF = "--disable-asm --with-capabilities"
 
 # libgcrypt.pc is added locally and thus installed here
 do_install_append() {
-- 
1.7.10.4

Re: [PATCH 5/5] libgcrypt: remove --without-pth

[Khem Raj]

On Mon, Oct 28, 2013 at 7:33 AM, Ross Burton <ross.burton@intel.com> wrote:
> This isn't recognised by configure, and the random number daemon that requires
> Pth isn't enabled.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-support/libgcrypt/libgcrypt.inc |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-support/libgcrypt/libgcrypt.inc b/meta/recipes-support/libgcrypt/libgcrypt.inc
> index 6a0e0cf..e0dfec2 100644
> --- a/meta/recipes-support/libgcrypt/libgcrypt.inc
> +++ b/meta/recipes-support/libgcrypt/libgcrypt.inc
> @@ -15,7 +15,7 @@ SRC_URI = "ftp://ftp.gnupg.org/gcrypt/libgcrypt/libgcrypt-${PV}.tar.gz \
>
>  inherit autotools binconfig pkgconfig
>
> -EXTRA_OECONF = "--without-pth --disable-asm --with-capabilities"
> +EXTRA_OECONF = "--disable-asm --with-capabilities"

should it now depend on pth as well for deterministic builds.

>
>  # libgcrypt.pc is added locally and thus installed here
>  do_install_append() {
> --
> 1.7.10.4
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH 5/5] libgcrypt: remove --without-pth

[Burton, Ross]

On 31 October 2013 03:44, Khem Raj <raj.khem@gmail.com> wrote:
> should it now depend on pth as well for deterministic builds.

No, because the random daemon (the only piece that needs Pth) is
disabled by default.

Ross

Re: [PATCH 1/5] gnome: set UNKNOWN_CONFIGURE_WHITELIST

[Otavio Salvador]

On Mon, Oct 28, 2013 at 12:33 PM, Ross Burton <ross.burton@intel.com> wrote:
> This class passes --disable-introspection to everything that inherits it but not
> all GNOME modules support introspection, so add that option to the
> unknown-configure-options sanity test whitelist.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>

I understand the change but it does not match with the commit log.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH 1/5] gnome: set UNKNOWN_CONFIGURE_WHITELIST

[Burton, Ross]

On 28 October 2013 15:59, Otavio Salvador <otavio@ossystems.com.br> wrote:
> On Mon, Oct 28, 2013 at 12:33 PM, Ross Burton <ross.burton@intel.com> wrote:
>> This class passes --disable-introspection to everything that inherits it but not
>> all GNOME modules support introspection, so add that option to the
>> unknown-configure-options sanity test whitelist.
>>
>> Signed-off-by: Ross Burton <ross.burton@intel.com>
>
> I understand the change but it does not match with the commit log.

How so?

-EXTRA_OECONF += "--enable-introspection=no"
+EXTRA_OECONF += "--disable-introspection"

This is a semantically identical change as far as autoconf is
concerned, that makes the whitelist clearer.

+UNKNOWN_CONFIGURE_WHITELIST += "--disable-introspection"

This is the unknown configure options whitelist.

Ross

Re: [PATCH 1/5] gnome: set UNKNOWN_CONFIGURE_WHITELIST

[Otavio Salvador]

On Mon, Oct 28, 2013 at 3:08 PM, Burton, Ross <ross.burton@intel.com> wrote:
> On 28 October 2013 15:59, Otavio Salvador <otavio@ossystems.com.br> wrote:
>> On Mon, Oct 28, 2013 at 12:33 PM, Ross Burton <ross.burton@intel.com> wrote:
>>> This class passes --disable-introspection to everything that inherits it but not
>>> all GNOME modules support introspection, so add that option to the
>>> unknown-configure-options sanity test whitelist.
>>>
>>> Signed-off-by: Ross Burton <ross.burton@intel.com>
>>
>> I understand the change but it does not match with the commit log.
>
> How so?
>
> -EXTRA_OECONF += "--enable-introspection=no"
> +EXTRA_OECONF += "--disable-introspection"
>
> This is a semantically identical change as far as autoconf is
> concerned, that makes the whitelist clearer.

For autoconf it is but for a human it is not. Please add this to the commit log.

> +UNKNOWN_CONFIGURE_WHITELIST += "--disable-introspection"
>
> This is the unknown configure options whitelist.
>
> Ross



-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750