Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Chong.Lu@windriver.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] util-linux: Fix QA warnings about ALTERNATIVES
Date: Wed, 13 Nov 2013 09:10:44 +0000	[thread overview]
Message-ID: <1384333844.6460.79.camel@ted> (raw)
In-Reply-To: <1384330318-14702-1-git-send-email-Chong.Lu@windriver.com>

On Wed, 2013-11-13 at 16:11 +0800, Chong.Lu@windriver.com wrote:
> From: Lu Chong <Chong.Lu@windriver.com>
> 
> Previously, EXTRA_OECONF would be overwritten by EXTRA_OECONF_class-native
> and EXTRA_OECONF_class-nativesdk when we executed `make export-sdk' command.

We don't have an export-sdk command do we?

> As a result, some applications such as `last', `mesg' and `reset' didn't get
> compiled.
> 
> The patch rewrote EXTRA_OECONF_class-native and EXTRA_OECONF_class-nativesdk
> variables to fix QA warnings.
> 
> usr/share/man/man1/last.1.util-linux does not exist
> usr/share/man/man1/mesg.1.util-linux does not exist
> usr/bin/last.util-linux does not exist
> usr/bin/mesg.util-linux does not exist
> bin/reset does not exist
> 
> Signed-off-by: Lu Chong <Chong.Lu@windriver.com>
> ---
>  meta/recipes-core/util-linux/util-linux_2.23.2.bb |   22 +++++++++++++++++++--
>  1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/util-linux/util-linux_2.23.2.bb b/meta/recipes-core/util-linux/util-linux_2.23.2.bb
> index b5c221b..b9cdc61 100644
> --- a/meta/recipes-core/util-linux/util-linux_2.23.2.bb
> +++ b/meta/recipes-core/util-linux/util-linux_2.23.2.bb
> @@ -18,5 +18,23 @@ SRC_URI[md5sum] = "39a02ad0b3b37824c394f40930b7aa38"
>  SRC_URI[sha256sum] = "6c5be3f7beec91b4893de14bbd722886fa2521be5bfa0fc079b749d0018633b1"
>  
>  CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
> -EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
> -EXTRA_OECONF_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
> +EXTRA_OECONF_class-native = "--disable-use-tty-group \
> +                             --disable-makeinstall-chown --enable-elvtune --enable-init \
> +                             --enable-kill --enable-last --enable-mesg --enable-partx \
> +                             --enable-raw --enable-rdev --enable-reset --disable-login \
> +                             --disable-vipw --disable-newgrp --disable-chfn-chsh \
> +                             --enable-write --enable-arch --enable-mount --with-fsprobe=builtin \
> +                             --enable-libuuid --enable-libblkid --enable-fsck --without-udev \
> +                             usrsbin_execdir='${sbindir}' \
> +                             --disable-fallocate --disable-use-tty-group \
> +"
> +EXTRA_OECONF_class-nativesdk = "--disable-use-tty-group \
> +                                --disable-makeinstall-chown --enable-elvtune --enable-init \
> +                                --enable-kill --enable-last --enable-mesg --enable-partx \
> +                                --enable-raw --enable-rdev --enable-reset --disable-login \
> +                                --disable-vipw --disable-newgrp --disable-chfn-chsh \
> +                                --enable-write --enable-arch --enable-mount --with-fsprobe=builtin \
> +                                --enable-libuuid --enable-libblkid --enable-fsck --without-udev \
> +                                usrsbin_execdir='${sbindir}' \
> +                                --disable-fallocate --disable-use-tty-group \
> +"

We are not duplicating EXTRA_OECONF like that, its horrible. How about
something like:

EXTRA_OECONF = "xxxx ${SOMEVAR}"
SOMEVAR = "z"
SOMEVAR_class-native = "x"
SOMEVAR_class-nativesdk = "y"

? I'm having to guess at what your real problem is though as the commit
message doesn't contain the right information.

Cheers,

Richard




  reply	other threads:[~2013-11-13  9:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13  8:11 [PATCH] util-linux: Fix QA warnings about ALTERNATIVES Chong.Lu
2013-11-13  9:10 ` Richard Purdie [this message]
2013-11-13 10:10   ` Robert Yang
2013-11-13 10:19     ` Lu Chong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384333844.6460.79.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Chong.Lu@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox