Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] sysvinit: unmount the psplash lazyily
@ 2013-11-15  1:52 Saul Wold
  2013-11-15 13:29 ` Otavio Salvador
  0 siblings, 1 reply; 3+ messages in thread
From: Saul Wold @ 2013-11-15  1:52 UTC (permalink / raw)
  To: openembedded-core

There is an race condition where psplash is not quite exited before the unmount occurs
causing a umount: /mnt/.psplash: target is busy message to appear, it's ok to lazyily
unmount and not get this message

[YOCTO #5244]

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-core/sysvinit/sysvinit/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/sysvinit/sysvinit/rc b/meta/recipes-core/sysvinit/sysvinit/rc
index 655a0b0..1f400d9 100755
--- a/meta/recipes-core/sysvinit/sysvinit/rc
+++ b/meta/recipes-core/sysvinit/sysvinit/rc
@@ -174,6 +174,6 @@ startup() {
 if [ "x$runlevel" != "xS" ] && [ ! -x /etc/rc${runlevel}.d/S??xserver-nodm ]; then
     if type psplash-write >/dev/null 2>&1; then
         TMPDIR=/mnt/.psplash psplash-write "QUIT" || true
-    	umount /mnt/.psplash
+    	umount -l /mnt/.psplash
     fi
 fi
-- 
1.8.3.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] sysvinit: unmount the psplash lazyily
  2013-11-15  1:52 [PATCH] sysvinit: unmount the psplash lazyily Saul Wold
@ 2013-11-15 13:29 ` Otavio Salvador
  2013-11-18 12:59   ` Robert Yang
  0 siblings, 1 reply; 3+ messages in thread
From: Otavio Salvador @ 2013-11-15 13:29 UTC (permalink / raw)
  To: Saul Wold, Robert Yang; +Cc: Patches and discussions about the oe-core layer

On Thu, Nov 14, 2013 at 11:52 PM, Saul Wold <sgw@linux.intel.com> wrote:
> There is an race condition where psplash is not quite exited before the unmount occurs
> causing a umount: /mnt/.psplash: target is busy message to appear, it's ok to lazyily
> unmount and not get this message
>
> [YOCTO #5244]
>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>

Agreed.

Acked-by: Otavio Salvador <otavio@ossystems.com.br>

Robert, please consider it to be included in dora. This is a simple
and nice bugfix.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sysvinit: unmount the psplash lazyily
  2013-11-15 13:29 ` Otavio Salvador
@ 2013-11-18 12:59   ` Robert Yang
  0 siblings, 0 replies; 3+ messages in thread
From: Robert Yang @ 2013-11-18 12:59 UTC (permalink / raw)
  To: Otavio Salvador, Saul Wold
  Cc: Patches and discussions about the oe-core layer



On 11/15/2013 09:29 PM, Otavio Salvador wrote:
> On Thu, Nov 14, 2013 at 11:52 PM, Saul Wold <sgw@linux.intel.com> wrote:
>> There is an race condition where psplash is not quite exited before the unmount occurs
>> causing a umount: /mnt/.psplash: target is busy message to appear, it's ok to lazyily
>> unmount and not get this message
>>
>> [YOCTO #5244]
>>
>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>
> Agreed.
>
> Acked-by: Otavio Salvador <otavio@ossystems.com.br>
>
> Robert, please consider it to be included in dora. This is a simple
> and nice bugfix.
>

Hi Otavio,

Thanks, I will try to add it in dora.

// Robert


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-11-18 12:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-15  1:52 [PATCH] sysvinit: unmount the psplash lazyily Saul Wold
2013-11-15 13:29 ` Otavio Salvador
2013-11-18 12:59   ` Robert Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox