* [PATCH] module-base: Fix misleading comment
@ 2013-11-27 13:45 Richard Purdie
2013-11-27 13:46 ` Bruce Ashfield
0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2013-11-27 13:45 UTC (permalink / raw)
To: openembedded-core
The comment was originally written for module.bbclass and is now
slightly misleading. This updates it to match the current code.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/meta/classes/module-base.bbclass b/meta/classes/module-base.bbclass
index 9dbb4b4..1589a90 100644
--- a/meta/classes/module-base.bbclass
+++ b/meta/classes/module-base.bbclass
@@ -11,11 +11,8 @@ KERNEL_OBJECT_SUFFIX = ".ko"
# kernel modules are generally machine specific
PACKAGE_ARCH = "${MACHINE_ARCH}"
-#
-# Ensure the hostprogs are available for module compilation. Modules that
-# inherit this recipe and override do_compile() should be sure to call
-# do_make_scripts() or ensure the scripts are built independently.
-#
+# Function to ensure the kernel scripts are created. Expected to
+# be called before do_compile. See module.bbclass for an exmaple.
do_make_scripts() {
unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
make CC="${KERNEL_CC}" LD="${KERNEL_LD}" AR="${KERNEL_AR}" \
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] module-base: Fix misleading comment
2013-11-27 13:45 [PATCH] module-base: Fix misleading comment Richard Purdie
@ 2013-11-27 13:46 ` Bruce Ashfield
2013-11-27 15:44 ` Khem Raj
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Ashfield @ 2013-11-27 13:46 UTC (permalink / raw)
To: Richard Purdie, openembedded-core
On 13-11-27 08:45 AM, Richard Purdie wrote:
> The comment was originally written for module.bbclass and is now
> slightly misleading. This updates it to match the current code.
Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/classes/module-base.bbclass b/meta/classes/module-base.bbclass
> index 9dbb4b4..1589a90 100644
> --- a/meta/classes/module-base.bbclass
> +++ b/meta/classes/module-base.bbclass
> @@ -11,11 +11,8 @@ KERNEL_OBJECT_SUFFIX = ".ko"
> # kernel modules are generally machine specific
> PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> -#
> -# Ensure the hostprogs are available for module compilation. Modules that
> -# inherit this recipe and override do_compile() should be sure to call
> -# do_make_scripts() or ensure the scripts are built independently.
> -#
> +# Function to ensure the kernel scripts are created. Expected to
> +# be called before do_compile. See module.bbclass for an exmaple.
> do_make_scripts() {
> unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
> make CC="${KERNEL_CC}" LD="${KERNEL_LD}" AR="${KERNEL_AR}" \
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] module-base: Fix misleading comment
2013-11-27 13:46 ` Bruce Ashfield
@ 2013-11-27 15:44 ` Khem Raj
0 siblings, 0 replies; 3+ messages in thread
From: Khem Raj @ 2013-11-27 15:44 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]
On Wednesday, November 27, 2013, Bruce Ashfield wrote:
> On 13-11-27 08:45 AM, Richard Purdie wrote:
>
>> The comment was originally written for module.bbclass and is now
>> slightly misleading. This updates it to match the current code.
>>
>
> Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
Looks ok
>
>
>> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>> ---
>> diff --git a/meta/classes/module-base.bbclass b/meta/classes/module-base.
>> bbclass
>> index 9dbb4b4..1589a90 100644
>> --- a/meta/classes/module-base.bbclass
>> +++ b/meta/classes/module-base.bbclass
>> @@ -11,11 +11,8 @@ KERNEL_OBJECT_SUFFIX = ".ko"
>> # kernel modules are generally machine specific
>> PACKAGE_ARCH = "${MACHINE_ARCH}"
>>
>> -#
>> -# Ensure the hostprogs are available for module compilation. Modules that
>> -# inherit this recipe and override do_compile() should be sure to call
>> -# do_make_scripts() or ensure the scripts are built independently.
>> -#
>> +# Function to ensure the kernel scripts are created. Expected to
>> +# be called before do_compile. See module.bbclass for an exmaple.
>> do_make_scripts() {
>> unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
>> make CC="${KERNEL_CC}" LD="${KERNEL_LD}" AR="${KERNEL_AR}" \
>>
>>
>>
>
[-- Attachment #2: Type: text/html, Size: 1955 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-27 15:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-27 13:45 [PATCH] module-base: Fix misleading comment Richard Purdie
2013-11-27 13:46 ` Bruce Ashfield
2013-11-27 15:44 ` Khem Raj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox