* [PATCH] systemd-compat-units: drop machineid.service
@ 2013-12-12 10:04 Ross Burton
2013-12-12 11:33 ` Koen Kooi
0 siblings, 1 reply; 6+ messages in thread
From: Ross Burton @ 2013-12-12 10:04 UTC (permalink / raw)
To: openembedded-core
systemd will create the machine ID automatically if it isn't set, so this unit
doesn't serve any purpose.
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
meta/recipes-core/systemd/systemd-compat-units.bb | 4 ----
.../systemd/systemd-compat-units/machineid.service | 16 ----------------
2 files changed, 20 deletions(-)
delete mode 100644 meta/recipes-core/systemd/systemd-compat-units/machineid.service
diff --git a/meta/recipes-core/systemd/systemd-compat-units.bb b/meta/recipes-core/systemd/systemd-compat-units.bb
index 6eb5ffd..e4d93d2 100644
--- a/meta/recipes-core/systemd/systemd-compat-units.bb
+++ b/meta/recipes-core/systemd/systemd-compat-units.bb
@@ -19,10 +19,6 @@ do_install() {
install -m 0644 ${WORKDIR}/run-postinsts.service ${D}${systemd_unitdir}/system
ln -sf ../run-postinsts.service ${D}${systemd_unitdir}/system/basic.target.wants/
ln -sf ../run-postinsts.service ${D}${systemd_unitdir}/system/sysinit.target.wants/
-
- install -m 0644 ${WORKDIR}/machineid.service ${D}${systemd_unitdir}/system
- ln -sf ../machineid.service ${D}${systemd_unitdir}/system/sysinit.target.wants/
- ln -sf ../machineid.service ${D}${systemd_unitdir}/system/basic.target.wants/
}
SYSTEMD_DISABLED_SYSV_SERVICES = " \
diff --git a/meta/recipes-core/systemd/systemd-compat-units/machineid.service b/meta/recipes-core/systemd/systemd-compat-units/machineid.service
deleted file mode 100644
index f586c6d..0000000
--- a/meta/recipes-core/systemd/systemd-compat-units/machineid.service
+++ /dev/null
@@ -1,16 +0,0 @@
-[Unit]
-Description=Machine ID first boot configure
-DefaultDependencies=no
-ConditionPathExists=|!/etc/machine-id
-After=systemd-remount-fs.service
-Before=sysinit.target
-
-[Service]
-ExecStart=/bin/systemd-machine-id-setup
-RemainAfterExit=No
-Type=oneshot
-StandardOutput=syslog
-
-[Install]
-WantedBy=basic.target
-WantedBy=sysinit.target
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] systemd-compat-units: drop machineid.service
2013-12-12 10:04 [PATCH] systemd-compat-units: drop machineid.service Ross Burton
@ 2013-12-12 11:33 ` Koen Kooi
2013-12-18 15:03 ` Burton, Ross
0 siblings, 1 reply; 6+ messages in thread
From: Koen Kooi @ 2013-12-12 11:33 UTC (permalink / raw)
To: Ross Burton; +Cc: Patches and discussions about the oe-core layer
Op 12 dec. 2013, om 11:04 heeft Ross Burton <ross.burton@intel.com> het volgende geschreven:
> systemd will create the machine ID automatically if it isn't set,
That's not the whole story, it will generate a new one every boot
> so this unit doesn't serve any purpose.
That's correct, you need to generate it offline, since /etc/machine-id is a bind mount after booting :(
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/recipes-core/systemd/systemd-compat-units.bb | 4 ----
> .../systemd/systemd-compat-units/machineid.service | 16 ----------------
> 2 files changed, 20 deletions(-)
> delete mode 100644 meta/recipes-core/systemd/systemd-compat-units/machineid.service
>
> diff --git a/meta/recipes-core/systemd/systemd-compat-units.bb b/meta/recipes-core/systemd/systemd-compat-units.bb
> index 6eb5ffd..e4d93d2 100644
> --- a/meta/recipes-core/systemd/systemd-compat-units.bb
> +++ b/meta/recipes-core/systemd/systemd-compat-units.bb
> @@ -19,10 +19,6 @@ do_install() {
> install -m 0644 ${WORKDIR}/run-postinsts.service ${D}${systemd_unitdir}/system
> ln -sf ../run-postinsts.service ${D}${systemd_unitdir}/system/basic.target.wants/
> ln -sf ../run-postinsts.service ${D}${systemd_unitdir}/system/sysinit.target.wants/
> -
> - install -m 0644 ${WORKDIR}/machineid.service ${D}${systemd_unitdir}/system
> - ln -sf ../machineid.service ${D}${systemd_unitdir}/system/sysinit.target.wants/
> - ln -sf ../machineid.service ${D}${systemd_unitdir}/system/basic.target.wants/
> }
>
> SYSTEMD_DISABLED_SYSV_SERVICES = " \
> diff --git a/meta/recipes-core/systemd/systemd-compat-units/machineid.service b/meta/recipes-core/systemd/systemd-compat-units/machineid.service
> deleted file mode 100644
> index f586c6d..0000000
> --- a/meta/recipes-core/systemd/systemd-compat-units/machineid.service
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -[Unit]
> -Description=Machine ID first boot configure
> -DefaultDependencies=no
> -ConditionPathExists=|!/etc/machine-id
> -After=systemd-remount-fs.service
> -Before=sysinit.target
> -
> -[Service]
> -ExecStart=/bin/systemd-machine-id-setup
> -RemainAfterExit=No
> -Type=oneshot
> -StandardOutput=syslog
> -
> -[Install]
> -WantedBy=basic.target
> -WantedBy=sysinit.target
> --
> 1.7.10.4
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] systemd-compat-units: drop machineid.service
2013-12-12 11:33 ` Koen Kooi
@ 2013-12-18 15:03 ` Burton, Ross
2013-12-18 15:42 ` Koen Kooi
0 siblings, 1 reply; 6+ messages in thread
From: Burton, Ross @ 2013-12-18 15:03 UTC (permalink / raw)
To: Koen Kooi; +Cc: Patches and discussions about the oe-core layer
On 12 December 2013 11:33, Koen Kooi <koen@dominion.thruhere.net> wrote:
> Op 12 dec. 2013, om 11:04 heeft Ross Burton <ross.burton@intel.com> het volgende geschreven:
>
>> systemd will create the machine ID automatically if it isn't set,
>
> That's not the whole story, it will generate a new one every boot
It will generate a new one on boot *if* /etc/machine-id doesn't
contain a valid ID. If /etc is read-write then this happens once on
first boot.
>> so this unit doesn't serve any purpose.
>
> That's correct, you need to generate it offline, since /etc/machine-id is a bind mount after booting :(
Why is that bad? In the read-only-rootfs case you can either pre-seed
the machine ID at image creation time (if a single machine ID across
all instances is reasonable) or let systemd create a fresh one on
every boot in /run/machine-id and bind-mount /etc/machine-id to it.
Ross
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] systemd-compat-units: drop machineid.service
2013-12-18 15:03 ` Burton, Ross
@ 2013-12-18 15:42 ` Koen Kooi
2013-12-18 16:00 ` Burton, Ross
2013-12-18 16:39 ` Burton, Ross
0 siblings, 2 replies; 6+ messages in thread
From: Koen Kooi @ 2013-12-18 15:42 UTC (permalink / raw)
To: Burton, Ross; +Cc: Patches and discussions about the oe-core layer
Op 18 dec. 2013, om 16:03 heeft Burton, Ross <ross.burton@intel.com> het volgende geschreven:
> On 12 December 2013 11:33, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> Op 12 dec. 2013, om 11:04 heeft Ross Burton <ross.burton@intel.com> het volgende geschreven:
>>
>>> systemd will create the machine ID automatically if it isn't set,
>>
>> That's not the whole story, it will generate a new one every boot
>
> It will generate a new one on boot *if* /etc/machine-id doesn't
> contain a valid ID. If /etc is read-write then this happens once on
> first boot.
Right, booting with 'ro' in the kernel cmdline will prevent that from happening, which means...
>
>>> so this unit doesn't serve any purpose.
>>
>> That's correct, you need to generate it offline, since /etc/machine-id is a bind mount after booting :(
>
> Why is that bad? In the read-only-rootfs case you can either pre-seed
> the machine ID at image creation time (if a single machine ID across
> all instances is reasonable) or let systemd create a fresh one on
> every boot in /run/machine-id and bind-mount /etc/machine-id to it.
... every boot you get a new machine ID and hence a new journal ID, which sucks. We can debate if that sucks more or less than having duplicate machine IDs across the boards on your desk :)
regards,
Koen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] systemd-compat-units: drop machineid.service
2013-12-18 15:42 ` Koen Kooi
@ 2013-12-18 16:00 ` Burton, Ross
2013-12-18 16:39 ` Burton, Ross
1 sibling, 0 replies; 6+ messages in thread
From: Burton, Ross @ 2013-12-18 16:00 UTC (permalink / raw)
To: Koen Kooi; +Cc: Patches and discussions about the oe-core layer
On 18 December 2013 15:42, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> Why is that bad? In the read-only-rootfs case you can either pre-seed
>> the machine ID at image creation time (if a single machine ID across
>> all instances is reasonable) or let systemd create a fresh one on
>> every boot in /run/machine-id and bind-mount /etc/machine-id to it.
>
> ... every boot you get a new machine ID and hence a new journal ID, which sucks. We can
> debate if that sucks more or less than having duplicate machine IDs across the boards on
> your desk :)
Out of the box, the journal is in a tmpfs, so it disappears anyway.
Either way, this service file isn't useful.
Ross
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] systemd-compat-units: drop machineid.service
2013-12-18 15:42 ` Koen Kooi
2013-12-18 16:00 ` Burton, Ross
@ 2013-12-18 16:39 ` Burton, Ross
1 sibling, 0 replies; 6+ messages in thread
From: Burton, Ross @ 2013-12-18 16:39 UTC (permalink / raw)
To: Koen Kooi; +Cc: Patches and discussions about the oe-core layer
On 18 December 2013 15:42, Koen Kooi <koen@dominion.thruhere.net> wrote:
> ... every boot you get a new machine ID and hence a new journal ID, which sucks. We can debate if that sucks more or less than having duplicate machine IDs across the boards on your desk :)
In the spirit of Linux we can make this a choice, though something
like a systemd postinst that can optionally write a machine ID to
/etc. If enabled, the rootfs will get a machine ID at construction
time.
Ross
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-12-18 16:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-12 10:04 [PATCH] systemd-compat-units: drop machineid.service Ross Burton
2013-12-12 11:33 ` Koen Kooi
2013-12-18 15:03 ` Burton, Ross
2013-12-18 15:42 ` Koen Kooi
2013-12-18 16:00 ` Burton, Ross
2013-12-18 16:39 ` Burton, Ross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox