From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH] conf/bitbake.conf: default HOMEPAGE to blank instead of unknown
Date: Tue, 21 Jan 2014 12:17:53 +0000 [thread overview]
Message-ID: <1390306673-9822-1-git-send-email-paul.eggleton@linux.intel.com> (raw)
The default value for HOMEPAGE of "unknown" has been in place since the
early OE-Classic days, but it doesn't really make sense - "unknown" is
not a valid URL and it just means we have to explicitly check for this
hardcoded string if we're displaying the value in some form of UI, such
as Toaster. There is some code in the unmaintained oelint.bbclass to
check for this value, presumably on the assumption that the recipe will
explicitly set it to "" if there really isn't a homepage, but looking at
recipes in OE-Core and meta-oe suggests that we haven't been using this
convention for some time (with one exception in the latter) and it's
rather uncommon these days to have no URL to associate with a recipe.
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
meta/conf/bitbake.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 57668e1..4fb6a1c 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -241,7 +241,7 @@ This package contains documentation."
LICENSE = "INVALID"
MAINTAINER = "OE-Core Developers <openembedded-core@lists.openembedded.org>"
-HOMEPAGE = "unknown"
+HOMEPAGE = ""
# Package dependencies and provides.
--
1.8.4.2
next reply other threads:[~2014-01-21 12:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 12:17 Paul Eggleton [this message]
2014-01-21 22:09 ` [PATCH] conf/bitbake.conf: default HOMEPAGE to blank instead of unknown Saul Wold
2014-01-21 22:12 ` Paul Eggleton
2014-01-21 22:22 ` Paul Eggleton
2014-01-21 22:41 ` Richard Purdie
2014-01-21 22:24 ` Saul Wold
2014-01-21 22:23 ` Richard Purdie
2014-01-21 22:39 ` Paul Eggleton
2014-01-21 22:42 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390306673-9822-1-git-send-email-paul.eggleton@linux.intel.com \
--to=paul.eggleton@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox