Re: [PATCH] conf/bitbake.conf: default HOMEPAGE to blank instead of unknown

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2014-01-21 at 22:22 +0000, Paul Eggleton wrote:
> On Tuesday 21 January 2014 22:12:13 Paul Eggleton wrote:
> > Hi Saul,
> > 
> > On Tuesday 21 January 2014 14:09:16 Saul Wold wrote:
> > > On 01/21/2014 04:17 AM, Paul Eggleton wrote:
> > > > The default value for HOMEPAGE of "unknown" has been in place since the
> > > > early OE-Classic days, but it doesn't really make sense - "unknown" is
> > > > not a valid URL and it just means we have to explicitly check for this
> > > > hardcoded string if we're displaying the value in some form of UI, such
> > > > as Toaster. There is some code in the unmaintained oelint.bbclass to
> > > > check for this value, presumably on the assumption that the recipe will
> > > > explicitly set it to "" if there really isn't a homepage, but looking at
> > > > recipes in OE-Core and meta-oe suggests that we haven't been using this
> > > > convention for some time (with one exception in the latter) and it's
> > > > rather uncommon these days to have no URL to associate with a recipe.
> > > > 
> > > > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> > > > ---
> > > > 
> > > >   meta/conf/bitbake.conf | 2 +-
> > > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > > > index 57668e1..4fb6a1c 100644
> > > > --- a/meta/conf/bitbake.conf
> > > > +++ b/meta/conf/bitbake.conf
> > > > @@ -241,7 +241,7 @@ This package contains documentation."
> > > > 
> > > >   LICENSE = "INVALID"
> > > >   MAINTAINER = "OE-Core Developers
> > > >   <openembedded-core@lists.openembedded.org>">
> > > > 
> > > > -HOMEPAGE = "unknown"
> > > > +HOMEPAGE = ""
> > > 
> > > This seems to have caused a couple of problems with shadow-securetty,
> > > updaterc and depmodwrapper.
> > > 
> > > There may be more.
> > 
> > Can you perhaps be more specific as to what the problem is?
> 
> Oh, I see, rpmbuild blows up with URL blank. Great :/
> 
> Let's hold off on this one for now because fixing one or two recipes isn't going 
> to cover it.

I'm perfectly fine with the rpm backend injecting something to deal with
this rather than cluttering bitbake.conf or the toaster code. I think
cleaning out bitbake.conf is something we need to do more of.

SRCREV ??= "INVALID" is on my hitlist (newer bitbake's shouldn't need
that).

Cheers,

Richard