* [PATCH] x264: SPE is not compatible with Altivec
@ 2014-02-21 13:56 David Nyström
2014-02-21 18:28 ` Saul Wold
2014-02-21 21:59 ` [PATCHv2] x246: Disable Altivec asm when SPE is enabled David Nyström
0 siblings, 2 replies; 6+ messages in thread
From: David Nyström @ 2014-02-21 13:56 UTC (permalink / raw)
To: openembedded-core
Signed-off-by: David Nyström <david.c.nystrom@gmail.com>
---
meta/recipes-multimedia/x264/x264_git.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-multimedia/x264/x264_git.bb b/meta/recipes-multimedia/x264/x264_git.bb
index 5ebf885..782c26e 100644
--- a/meta/recipes-multimedia/x264/x264_git.bb
+++ b/meta/recipes-multimedia/x264/x264_git.bb
@@ -23,6 +23,7 @@ inherit lib_package pkgconfig
X264_DISABLE_ASM = ""
X264_DISABLE_ASM_armv4 = "--disable-asm"
X264_DISABLE_ASM_armv5 = "--disable-asm"
+X264_DISABLE_ASM_e500v2 = "--disable-asm"
EXTRA_OECONF = '--prefix=${prefix} \
--host=${HOST_SYS} \
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] x264: SPE is not compatible with Altivec
2014-02-21 13:56 [PATCH] x264: SPE is not compatible with Altivec David Nyström
@ 2014-02-21 18:28 ` Saul Wold
2014-02-21 19:40 ` David Nystrom
2014-02-21 21:59 ` [PATCHv2] x246: Disable Altivec asm when SPE is enabled David Nyström
1 sibling, 1 reply; 6+ messages in thread
From: Saul Wold @ 2014-02-21 18:28 UTC (permalink / raw)
To: David Nyström, openembedded-core
On 02/21/2014 05:56 AM, David Nyström wrote:
> Signed-off-by: David Nyström <david.c.nystrom@gmail.com>
> ---
> meta/recipes-multimedia/x264/x264_git.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-multimedia/x264/x264_git.bb b/meta/recipes-multimedia/x264/x264_git.bb
> index 5ebf885..782c26e 100644
> --- a/meta/recipes-multimedia/x264/x264_git.bb
> +++ b/meta/recipes-multimedia/x264/x264_git.bb
> @@ -23,6 +23,7 @@ inherit lib_package pkgconfig
> X264_DISABLE_ASM = ""
> X264_DISABLE_ASM_armv4 = "--disable-asm"
> X264_DISABLE_ASM_armv5 = "--disable-asm"
> +X264_DISABLE_ASM_e500v2 = "--disable-asm"
>
I think that this change really belongs in the e500v2 BSP, it's not
generic enough to include in core.
Thanks
Sau!
> EXTRA_OECONF = '--prefix=${prefix} \
> --host=${HOST_SYS} \
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x264: SPE is not compatible with Altivec
2014-02-21 18:28 ` Saul Wold
@ 2014-02-21 19:40 ` David Nystrom
2014-02-21 21:20 ` Phil Blundell
0 siblings, 1 reply; 6+ messages in thread
From: David Nystrom @ 2014-02-21 19:40 UTC (permalink / raw)
To: Saul Wold; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 1176 bytes --]
On Feb 21, 2014 7:28 PM, "Saul Wold" <sgw@linux.intel.com> wrote:
>
> On 02/21/2014 05:56 AM, David Nyström wrote:
>>
>> Signed-off-by: David Nyström <david.c.nystrom@gmail.com>
>> ---
>> meta/recipes-multimedia/x264/x264_git.bb | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-multimedia/x264/x264_git.bbb/meta/recipes-multimedia/x264/
x264_git.bb
>> index 5ebf885..782c26e 100644
>> --- a/meta/recipes-multimedia/x264/x264_git.bb
>> +++ b/meta/recipes-multimedia/x264/x264_git.bb
>> @@ -23,6 +23,7 @@ inherit lib_package pkgconfig
>> X264_DISABLE_ASM = ""
>> X264_DISABLE_ASM_armv4 = "--disable-asm"
>> X264_DISABLE_ASM_armv5 = "--disable-asm"
>> +X264_DISABLE_ASM_e500v2 = "--disable-asm"
>>
> I think that this change really belongs in the e500v2 BSP, it's not
generic enough to include in core.
Perhaps you know this already, but e500v2 is a cpu arch, same as armv5.
For future reference, should all ppc related CPU-arch specific stuff be
directed to the FSL bsp ?
Br,
David
>
> Thanks
> Sau!
>
>
>
>> EXTRA_OECONF = '--prefix=${prefix} \
>> --host=${HOST_SYS} \
>>
[-- Attachment #2: Type: text/html, Size: 1839 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x264: SPE is not compatible with Altivec
2014-02-21 19:40 ` David Nystrom
@ 2014-02-21 21:20 ` Phil Blundell
2014-02-21 21:45 ` David Nyström
0 siblings, 1 reply; 6+ messages in thread
From: Phil Blundell @ 2014-02-21 21:20 UTC (permalink / raw)
To: David Nystrom; +Cc: Patches and discussions about the oe-core layer
On Fri, 2014-02-21 at 20:40 +0100, David Nystrom wrote:
> Perhaps you know this already, but e500v2 is a cpu arch, same as
> armv5.
Is that really true? I thought e500v2 was an actual core and the
equivalent architecture was Power v2.03 or something.
>For future reference, should all ppc related CPU-arch specific stuff
>be directed to the FSL bsp ?
Since we do ship tune-ppce500.inc in oe-core, I think it makes sense to
also include the overrides necessary to make compilation work with SPE
enabled. It doesn't seem unreasonable that users would expect that the
recipes in oe-core would work with a configuration that comes as
standard.
However, adding overrides for e500v2 specifically does seem like a bad
plan since we will then end up having to duplicate the thing for every
other non-altivec configuration. Can you come up with some override
that will apply to all SPE configurations, or failing that a patch for
the configure script that will disable the altivec assembler if it
notices that ${CC} is configured for SPE?
p.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] x264: SPE is not compatible with Altivec
2014-02-21 21:20 ` Phil Blundell
@ 2014-02-21 21:45 ` David Nyström
0 siblings, 0 replies; 6+ messages in thread
From: David Nyström @ 2014-02-21 21:45 UTC (permalink / raw)
To: Phil Blundell; +Cc: Patches and discussions about the oe-core layer
On 2014-02-21 22:20, Phil Blundell wrote:
> On Fri, 2014-02-21 at 20:40 +0100, David Nystrom wrote:
>> Perhaps you know this already, but e500v2 is a cpu arch, same as
>> armv5.
> Is that really true? I thought e500v2 was an actual core and the
> equivalent architecture was Power v2.03 or something.
Yes, good point.
I understand Sauls concern.
>
>> For future reference, should all ppc related CPU-arch specific stuff
>> be directed to the FSL bsp ?
> Since we do ship tune-ppce500.inc in oe-core, I think it makes sense to
> also include the overrides necessary to make compilation work with SPE
> enabled. It doesn't seem unreasonable that users would expect that the
> recipes in oe-core would work with a configuration that comes as
> standard.
>
> However, adding overrides for e500v2 specifically does seem like a bad
> plan since we will then end up having to duplicate the thing for every
> other non-altivec configuration. Can you come up with some override
> that will apply to all SPE configurations,
Yep, will return with V2.
> or failing that a patch for
> the configure script that will disable the altivec assembler if it
> notices that ${CC} is configured for SPE?
>
> p.
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCHv2] x246: Disable Altivec asm when SPE is enabled.
2014-02-21 13:56 [PATCH] x264: SPE is not compatible with Altivec David Nyström
2014-02-21 18:28 ` Saul Wold
@ 2014-02-21 21:59 ` David Nyström
1 sibling, 0 replies; 6+ messages in thread
From: David Nyström @ 2014-02-21 21:59 UTC (permalink / raw)
To: openembedded-core
asm code is written for Altivec, and should be disabled
for powerpc SPE enabled targets.
Signed-off-by: David Nyström <david.c.nystrom@gmail.com>
---
meta/recipes-multimedia/x264/x264_git.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-multimedia/x264/x264_git.bb b/meta/recipes-multimedia/x264/x264_git.bb
index 5ebf885..0e305ea 100644
--- a/meta/recipes-multimedia/x264/x264_git.bb
+++ b/meta/recipes-multimedia/x264/x264_git.bb
@@ -23,6 +23,7 @@ inherit lib_package pkgconfig
X264_DISABLE_ASM = ""
X264_DISABLE_ASM_armv4 = "--disable-asm"
X264_DISABLE_ASM_armv5 = "--disable-asm"
+X264_DISABLE_ASM_powerpc = "${@bb.utils.contains("TUNE_FEATURES", "spe", "--disable-asm", "", d)}"
EXTRA_OECONF = '--prefix=${prefix} \
--host=${HOST_SYS} \
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-21 21:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-21 13:56 [PATCH] x264: SPE is not compatible with Altivec David Nyström
2014-02-21 18:28 ` Saul Wold
2014-02-21 19:40 ` David Nystrom
2014-02-21 21:20 ` Phil Blundell
2014-02-21 21:45 ` David Nyström
2014-02-21 21:59 ` [PATCHv2] x246: Disable Altivec asm when SPE is enabled David Nyström
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox