* [PATCH] security-flags: Deal with powerpc build issues
@ 2014-02-26 11:35 Richard Purdie
2014-02-26 11:40 ` Gary Thomas
0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2014-02-26 11:35 UTC (permalink / raw)
To: openembedded-core
Building powerpc machines with the standard security flags generated numerous
build failures. Use a reduced set of flags for now to avoid linker issues
and other compile failures.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/meta/conf/distro/include/security_flags.inc b/meta/conf/distro/include/security_flags.inc
index e7d4933a..b5489d8 100644
--- a/meta/conf/distro/include/security_flags.inc
+++ b/meta/conf/distro/include/security_flags.inc
@@ -2,6 +2,14 @@ SECURITY_CFLAGS ?= "-fstack-protector-all -pie -fpie -D_FORTIFY_SOURCE=2"
SECURITY_NO_PIE_CFLAGS ?= "-fstack-protector-all -D_FORTIFY_SOURCE=2"
SECURITY_LDFLAGS ?= "-Wl,-z,relro,-z,now"
+# powerpc does not get on with pie for reasons not looked into as yet
+SECURITY_CFLAGS_powerpc = "-fstack-protector-all -D_FORTIFY_SOURCE=2"
+# Deal with ppc specific linker failures when using the cflags
+SECURITY_CFLAGS_pn-dbus_powerpc = ""
+SECURITY_CFLAGS_pn-dbus-ptest_powerpc = ""
+SECURITY_CFLAGS_pn-libmatchbox_powerpc = ""
+SECURITY_CFLAGS_pn-webkit-gtk = ""
+
SECURITY_CFLAGS_pn-aspell = "${SECURITY_NO_PIE_CFLAGS}"
SECURITY_CFLAGS_pn-beecrypt = "${SECURITY_NO_PIE_CFLAGS}"
# Curl seems to check for FORTIFY_SOURCE in CFLAGS, but even assigned
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] security-flags: Deal with powerpc build issues
2014-02-26 11:35 [PATCH] security-flags: Deal with powerpc build issues Richard Purdie
@ 2014-02-26 11:40 ` Gary Thomas
2014-02-26 12:00 ` Richard Purdie
0 siblings, 1 reply; 3+ messages in thread
From: Gary Thomas @ 2014-02-26 11:40 UTC (permalink / raw)
To: openembedded-core
On 2014-02-26 04:35, Richard Purdie wrote:
>
>
> Building powerpc machines with the standard security flags generated numerous
> build failures. Use a reduced set of flags for now to avoid linker issues
> and other compile failures.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/conf/distro/include/security_flags.inc b/meta/conf/distro/include/security_flags.inc
> index e7d4933a..b5489d8 100644
> --- a/meta/conf/distro/include/security_flags.inc
> +++ b/meta/conf/distro/include/security_flags.inc
> @@ -2,6 +2,14 @@ SECURITY_CFLAGS ?= "-fstack-protector-all -pie -fpie -D_FORTIFY_SOURCE=2"
> SECURITY_NO_PIE_CFLAGS ?= "-fstack-protector-all -D_FORTIFY_SOURCE=2"
> SECURITY_LDFLAGS ?= "-Wl,-z,relro,-z,now"
>
> +# powerpc does not get on with pie for reasons not looked into as yet
> +SECURITY_CFLAGS_powerpc = "-fstack-protector-all -D_FORTIFY_SOURCE=2"
> +# Deal with ppc specific linker failures when using the cflags
> +SECURITY_CFLAGS_pn-dbus_powerpc = ""
> +SECURITY_CFLAGS_pn-dbus-ptest_powerpc = ""
> +SECURITY_CFLAGS_pn-libmatchbox_powerpc = ""
> +SECURITY_CFLAGS_pn-webkit-gtk = ""
The change for webkit doesn't seem to be PowerPC specific? If it needs
to be here, shouldn't it be in a separate change, or at least documented
in the change log?
> +
> SECURITY_CFLAGS_pn-aspell = "${SECURITY_NO_PIE_CFLAGS}"
> SECURITY_CFLAGS_pn-beecrypt = "${SECURITY_NO_PIE_CFLAGS}"
> # Curl seems to check for FORTIFY_SOURCE in CFLAGS, but even assigned
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] security-flags: Deal with powerpc build issues
2014-02-26 11:40 ` Gary Thomas
@ 2014-02-26 12:00 ` Richard Purdie
0 siblings, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2014-02-26 12:00 UTC (permalink / raw)
To: Gary Thomas; +Cc: openembedded-core
On Wed, 2014-02-26 at 04:40 -0700, Gary Thomas wrote:
> On 2014-02-26 04:35, Richard Purdie wrote:
> >
> >
> > Building powerpc machines with the standard security flags generated numerous
> > build failures. Use a reduced set of flags for now to avoid linker issues
> > and other compile failures.
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> > diff --git a/meta/conf/distro/include/security_flags.inc b/meta/conf/distro/include/security_flags.inc
> > index e7d4933a..b5489d8 100644
> > --- a/meta/conf/distro/include/security_flags.inc
> > +++ b/meta/conf/distro/include/security_flags.inc
> > @@ -2,6 +2,14 @@ SECURITY_CFLAGS ?= "-fstack-protector-all -pie -fpie -D_FORTIFY_SOURCE=2"
> > SECURITY_NO_PIE_CFLAGS ?= "-fstack-protector-all -D_FORTIFY_SOURCE=2"
> > SECURITY_LDFLAGS ?= "-Wl,-z,relro,-z,now"
> >
> > +# powerpc does not get on with pie for reasons not looked into as yet
> > +SECURITY_CFLAGS_powerpc = "-fstack-protector-all -D_FORTIFY_SOURCE=2"
> > +# Deal with ppc specific linker failures when using the cflags
> > +SECURITY_CFLAGS_pn-dbus_powerpc = ""
> > +SECURITY_CFLAGS_pn-dbus-ptest_powerpc = ""
> > +SECURITY_CFLAGS_pn-libmatchbox_powerpc = ""
> > +SECURITY_CFLAGS_pn-webkit-gtk = ""
>
> The change for webkit doesn't seem to be PowerPC specific? If it needs
> to be here, shouldn't it be in a separate change, or at least documented
> in the change log?
Sorry, I'll make that powerpc specific, it was meant to be...
Cheers,
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-26 12:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-26 11:35 [PATCH] security-flags: Deal with powerpc build issues Richard Purdie
2014-02-26 11:40 ` Gary Thomas
2014-02-26 12:00 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox