* [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> @ 2014-03-04 20:40 Andrey Belous 2014-03-04 21:43 ` Phil Blundell 2014-03-04 23:05 ` Saul Wold 0 siblings, 2 replies; 10+ messages in thread From: Andrey Belous @ 2014-03-04 20:40 UTC (permalink / raw) To: openembedded-core Setting of a variable PREFERRED_PROVIDER_virtual/libc only if it doesn't have a value --- meta/conf/distro/include/tclibc-uclibc.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/conf/distro/include/tclibc-uclibc.inc b/meta/conf/distro/include/tclibc-uclibc.inc index 9245112..a4d8c39 100644 --- a/meta/conf/distro/include/tclibc-uclibc.inc +++ b/meta/conf/distro/include/tclibc-uclibc.inc @@ -8,7 +8,7 @@ LIBCEXTENSION = "-uclibc" LIBCOVERRIDE = ":libc-uclibc" OVERRIDES .= "${LIBCOVERRIDE}" -PREFERRED_PROVIDER_virtual/libc = "uclibc" +PREFERRED_PROVIDER_virtual/libc ?= "uclibc" PREFERRED_PROVIDER_virtual/libiconv ?= "libiconv" PREFERRED_PROVIDER_virtual/libintl ?= "gettext" PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-eglibc" -- 1.9.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> 2014-03-04 20:40 [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> Andrey Belous @ 2014-03-04 21:43 ` Phil Blundell 2014-03-04 21:55 ` Andrey Belous 2014-03-04 23:05 ` Saul Wold 1 sibling, 1 reply; 10+ messages in thread From: Phil Blundell @ 2014-03-04 21:43 UTC (permalink / raw) To: Andrey Belous; +Cc: openembedded-core On Tue, 2014-03-04 at 15:40 -0500, Andrey Belous wrote: > -PREFERRED_PROVIDER_virtual/libc = "uclibc" > +PREFERRED_PROVIDER_virtual/libc ?= "uclibc" Why would you be including tclibc-uclibc.inc if you don't want to use uclibc? p. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> 2014-03-04 21:43 ` Phil Blundell @ 2014-03-04 21:55 ` Andrey Belous 2014-03-06 22:43 ` Khem Raj 2014-03-07 18:26 ` Phil Blundell 0 siblings, 2 replies; 10+ messages in thread From: Andrey Belous @ 2014-03-04 21:55 UTC (permalink / raw) To: Phil Blundell; +Cc: openembedded-core@lists.openembedded.org Hi Phil, I have prebuild uclibc library that I would like to use, without that change I cannot force to use my prebuild library -Andrey -----Original Message----- From: Phil Blundell [mailto:pb@pbcl.net] Sent: Tuesday, March 04, 2014 4:43 PM To: Andrey Belous Cc: openembedded-core@lists.openembedded.org Subject: Re: [OE-core] [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> On Tue, 2014-03-04 at 15:40 -0500, Andrey Belous wrote: > -PREFERRED_PROVIDER_virtual/libc = "uclibc" > +PREFERRED_PROVIDER_virtual/libc ?= "uclibc" Why would you be including tclibc-uclibc.inc if you don't want to use uclibc? p. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> 2014-03-04 21:55 ` Andrey Belous @ 2014-03-06 22:43 ` Khem Raj 2014-03-07 10:33 ` Nicolas Dechesne 2014-03-07 18:26 ` Phil Blundell 1 sibling, 1 reply; 10+ messages in thread From: Khem Raj @ 2014-03-06 22:43 UTC (permalink / raw) To: Andrey Belous; +Cc: openembedded-core@lists.openembedded.org On Tue, Mar 4, 2014 at 1:55 PM, Andrey Belous <abelous@broadcom.com> wrote: > Hi Phil, > I have prebuild uclibc library that I would like to use, without that change I cannot force to use my prebuild library > OK so write a uclibc recipe for it and let it provide virtual/libc and, we can very well have multiple version of recipes, this is no different. Then use higher DEFAULT_PREFERENCE for your recipe. > -Andrey > > -----Original Message----- > From: Phil Blundell [mailto:pb@pbcl.net] > Sent: Tuesday, March 04, 2014 4:43 PM > To: Andrey Belous > Cc: openembedded-core@lists.openembedded.org > Subject: Re: [OE-core] [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> > > On Tue, 2014-03-04 at 15:40 -0500, Andrey Belous wrote: >> -PREFERRED_PROVIDER_virtual/libc = "uclibc" >> +PREFERRED_PROVIDER_virtual/libc ?= "uclibc" > > Why would you be including tclibc-uclibc.inc if you don't want to use > uclibc? > > p. > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> 2014-03-06 22:43 ` Khem Raj @ 2014-03-07 10:33 ` Nicolas Dechesne 2014-03-07 18:40 ` Khem Raj 0 siblings, 1 reply; 10+ messages in thread From: Nicolas Dechesne @ 2014-03-07 10:33 UTC (permalink / raw) To: Khem Raj; +Cc: openembedded-core@lists.openembedded.org Hi Khem, On Fri, Mar 7, 2014 at 6:43 AM, Khem Raj <raj.khem@gmail.com> wrote: > On Tue, Mar 4, 2014 at 1:55 PM, Andrey Belous <abelous@broadcom.com> wrote: >> Hi Phil, >> I have prebuild uclibc library that I would like to use, without that change I cannot force to use my prebuild library >> > > OK so write a uclibc recipe for it and let it provide virtual/libc > and, we can very well have multiple version of recipes, this is no > different. Then use higher DEFAULT_PREFERENCE for your recipe. I still don't get it why in distro/include/tclibc-uclibc.inc we have PREFERRED_PROVIDER_virtual/libc = "uclibc" PREFERRED_PROVIDER_virtual/libiconv ?= "libiconv" PREFERRED_PROVIDER_virtual/libintl ?= "gettext" PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-eglibc" PREFERRED_PROVIDER_virtual/nativesdk-libiconv ?= "nativesdk-eglibc" and in distro/include/tclibc-eglibc.inc, we have: PREFERRED_PROVIDER_virtual/libiconv ?= "eglibc" PREFERRED_PROVIDER_virtual/nativesdk-libiconv ?= "nativesdk-eglibc" PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-eglibc" PREFERRED_PROVIDER_virtual/libintl ?= "eglibc" PREFERRED_PROVIDER_virtual/libc ?= "eglibc" PREFERRED_PROVIDER_virtual/nativesdk-libc ?= "nativesdk-eglibc" PREFERRED_PROVIDER_virtual/libc-locale ?= "eglibc-locale" Is a specific reason why in the first case we use "=" and not "?=" like used everywhere else? This file is loaded last, so we have no chance to override the value. regardless of the actual reason, don't we need the change anyways? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> 2014-03-07 10:33 ` Nicolas Dechesne @ 2014-03-07 18:40 ` Khem Raj 0 siblings, 0 replies; 10+ messages in thread From: Khem Raj @ 2014-03-07 18:40 UTC (permalink / raw) To: Nicolas Dechesne; +Cc: openembedded-core@lists.openembedded.org On Fri, Mar 7, 2014 at 2:33 AM, Nicolas Dechesne <nicolas.dechesne@linaro.org> wrote: > Hi Khem, > > On Fri, Mar 7, 2014 at 6:43 AM, Khem Raj <raj.khem@gmail.com> wrote: >> On Tue, Mar 4, 2014 at 1:55 PM, Andrey Belous <abelous@broadcom.com> wrote: >>> Hi Phil, >>> I have prebuild uclibc library that I would like to use, without that change I cannot force to use my prebuild library >>> >> >> OK so write a uclibc recipe for it and let it provide virtual/libc >> and, we can very well have multiple version of recipes, this is no >> different. Then use higher DEFAULT_PREFERENCE for your recipe. > > I still don't get it why in distro/include/tclibc-uclibc.inc we have > > PREFERRED_PROVIDER_virtual/libc = "uclibc" > PREFERRED_PROVIDER_virtual/libiconv ?= "libiconv" > PREFERRED_PROVIDER_virtual/libintl ?= "gettext" > PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-eglibc" > PREFERRED_PROVIDER_virtual/nativesdk-libiconv ?= "nativesdk-eglibc" > > and in distro/include/tclibc-eglibc.inc, we have: > > PREFERRED_PROVIDER_virtual/libiconv ?= "eglibc" > PREFERRED_PROVIDER_virtual/nativesdk-libiconv ?= "nativesdk-eglibc" > PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-eglibc" > PREFERRED_PROVIDER_virtual/libintl ?= "eglibc" > PREFERRED_PROVIDER_virtual/libc ?= "eglibc" > PREFERRED_PROVIDER_virtual/nativesdk-libc ?= "nativesdk-eglibc" > PREFERRED_PROVIDER_virtual/libc-locale ?= "eglibc-locale" > > Is a specific reason why in the first case we use "=" and not "?=" > like used everywhere else? This file is loaded last, so we have no > chance to override the value. regardless of the actual reason, don't > we need the change anyways? I would think eglibc.inc should be fixed as well. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> 2014-03-04 21:55 ` Andrey Belous 2014-03-06 22:43 ` Khem Raj @ 2014-03-07 18:26 ` Phil Blundell 1 sibling, 0 replies; 10+ messages in thread From: Phil Blundell @ 2014-03-07 18:26 UTC (permalink / raw) To: Andrey Belous; +Cc: openembedded-core@lists.openembedded.org Fair enough. I also agree that these variables should at least be consistent, and if we're assigning everything else with ?= then there seems no reason for that one provider to be treated specially. So I think your patch is fine, though it might be a good idea to re-send it with a less messed up commit message if you didn't already do that. p. On Tue, 2014-03-04 at 21:55 +0000, Andrey Belous wrote: > Hi Phil, > I have prebuild uclibc library that I would like to use, without that change I cannot force to use my prebuild library > > -Andrey > > -----Original Message----- > From: Phil Blundell [mailto:pb@pbcl.net] > Sent: Tuesday, March 04, 2014 4:43 PM > To: Andrey Belous > Cc: openembedded-core@lists.openembedded.org > Subject: Re: [OE-core] [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> > > On Tue, 2014-03-04 at 15:40 -0500, Andrey Belous wrote: > > -PREFERRED_PROVIDER_virtual/libc = "uclibc" > > +PREFERRED_PROVIDER_virtual/libc ?= "uclibc" > > Why would you be including tclibc-uclibc.inc if you don't want to use > uclibc? > > p. > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> 2014-03-04 20:40 [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> Andrey Belous 2014-03-04 21:43 ` Phil Blundell @ 2014-03-04 23:05 ` Saul Wold 2014-03-04 23:11 ` Andrey Belous 1 sibling, 1 reply; 10+ messages in thread From: Saul Wold @ 2014-03-04 23:05 UTC (permalink / raw) To: Andrey Belous, openembedded-core On 03/04/2014 12:40 PM, Andrey Belous wrote: > Setting of a variable PREFERRED_PROVIDER_virtual/libc only if it doesn't have a value The format of your commit message is backwards, you need to have a short message with the filename: tclibc-uclibc: <short message> <long message> Signed-off-by: .... Also this kind of change is distro specific and could be in your distro specific information, don;'t you need to override more of what's in here if you are using a prebuilt library? Sau! > --- > meta/conf/distro/include/tclibc-uclibc.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/conf/distro/include/tclibc-uclibc.inc b/meta/conf/distro/include/tclibc-uclibc.inc > index 9245112..a4d8c39 100644 > --- a/meta/conf/distro/include/tclibc-uclibc.inc > +++ b/meta/conf/distro/include/tclibc-uclibc.inc > @@ -8,7 +8,7 @@ LIBCEXTENSION = "-uclibc" > LIBCOVERRIDE = ":libc-uclibc" > OVERRIDES .= "${LIBCOVERRIDE}" > > -PREFERRED_PROVIDER_virtual/libc = "uclibc" > +PREFERRED_PROVIDER_virtual/libc ?= "uclibc" > PREFERRED_PROVIDER_virtual/libiconv ?= "libiconv" > PREFERRED_PROVIDER_virtual/libintl ?= "gettext" > PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-eglibc" > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> 2014-03-04 23:05 ` Saul Wold @ 2014-03-04 23:11 ` Andrey Belous 2014-03-06 17:25 ` Nicolas Dechesne 0 siblings, 1 reply; 10+ messages in thread From: Andrey Belous @ 2014-03-04 23:11 UTC (permalink / raw) To: Saul Wold, openembedded-core@lists.openembedded.org Yes I overwriting more , but other variable already with ?= and allow to override them -Andrey -----Original Message----- From: Saul Wold [mailto:sgw@linux.intel.com] Sent: Tuesday, March 04, 2014 6:05 PM To: Andrey Belous; openembedded-core@lists.openembedded.org Subject: Re: [OE-core] [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> On 03/04/2014 12:40 PM, Andrey Belous wrote: > Setting of a variable PREFERRED_PROVIDER_virtual/libc only if it doesn't have a value The format of your commit message is backwards, you need to have a short message with the filename: tclibc-uclibc: <short message> <long message> Signed-off-by: .... Also this kind of change is distro specific and could be in your distro specific information, don;'t you need to override more of what's in here if you are using a prebuilt library? Sau! > --- > meta/conf/distro/include/tclibc-uclibc.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/conf/distro/include/tclibc-uclibc.inc b/meta/conf/distro/include/tclibc-uclibc.inc > index 9245112..a4d8c39 100644 > --- a/meta/conf/distro/include/tclibc-uclibc.inc > +++ b/meta/conf/distro/include/tclibc-uclibc.inc > @@ -8,7 +8,7 @@ LIBCEXTENSION = "-uclibc" > LIBCOVERRIDE = ":libc-uclibc" > OVERRIDES .= "${LIBCOVERRIDE}" > > -PREFERRED_PROVIDER_virtual/libc = "uclibc" > +PREFERRED_PROVIDER_virtual/libc ?= "uclibc" > PREFERRED_PROVIDER_virtual/libiconv ?= "libiconv" > PREFERRED_PROVIDER_virtual/libintl ?= "gettext" > PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-eglibc" > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> 2014-03-04 23:11 ` Andrey Belous @ 2014-03-06 17:25 ` Nicolas Dechesne 0 siblings, 0 replies; 10+ messages in thread From: Nicolas Dechesne @ 2014-03-06 17:25 UTC (permalink / raw) To: Andrey Belous; +Cc: openembedded-core@lists.openembedded.org Hi, On Wed, Mar 5, 2014 at 7:11 AM, Andrey Belous <abelous@broadcom.com> wrote: > Yes I overwriting more , but other variable already with ?= and allow to override them I think I am okay with the patch proposed here. i don't see why the late assignment is missing just for this specific variable while it's used for every other variables and in the eglibc include file we already use the ?= for virtual/libc. as far as I am concerned, assuming the commit log gets rewritten properly, you can add: Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org> cheers, nico ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-03-07 18:41 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-03-04 20:40 [PATCH] Signed-off-by: Andrey Belous <abelous@broadcom.com> Andrey Belous 2014-03-04 21:43 ` Phil Blundell 2014-03-04 21:55 ` Andrey Belous 2014-03-06 22:43 ` Khem Raj 2014-03-07 10:33 ` Nicolas Dechesne 2014-03-07 18:40 ` Khem Raj 2014-03-07 18:26 ` Phil Blundell 2014-03-04 23:05 ` Saul Wold 2014-03-04 23:11 ` Andrey Belous 2014-03-06 17:25 ` Nicolas Dechesne
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox