Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] nss: avoid to use the hardcode kernel version
Date: Mon, 31 Mar 2014 17:32:15 +0100	[thread overview]
Message-ID: <1396283535.14790.78.camel@ted> (raw)
In-Reply-To: <20140331151018.GG2425@jama>

On Mon, 2014-03-31 at 17:10 +0200, Martin Jansa wrote:
> On Mon, Mar 31, 2014 at 10:20:49PM +0800, Kai Kang wrote:
> > From: Roy Li <rongqing.li@windriver.com>
> > 
> > When native package is built, use the uname to return the kernel version.
> > 
> > When target is built, read kernel version from ${STAGING_KERNEL_DIR}/kernel-abiversion
> > to avoid to use the hardcode kernel version.
> 
> Doesn't it make nss MACHINE_ARCH like most virtual/kernel providers are?

Agreed. I rejected this patch a while ago due to this and I'll reject it
again.

Cheers,

Richard



  reply	other threads:[~2014-03-31 16:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31 14:20 [PATCH] nss: avoid to use the hardcode kernel version Kai Kang
2014-03-31 14:20 ` Kai Kang
2014-03-31 14:33   ` Otavio Salvador
2014-03-31 15:10   ` Martin Jansa
2014-03-31 16:32     ` Richard Purdie [this message]
2014-04-01  1:40       ` Kang Kai
2014-03-31 20:49     ` Otavio Salvador
2014-04-02  2:35   ` Kang Kai
2014-04-02  3:35     ` Khem Raj
2014-04-03 12:00     ` Richard Purdie
2014-04-03 13:13       ` Paul Eggleton
2014-04-03 13:49         ` Phil Blundell
2014-04-03 13:53           ` Paul Eggleton
2014-04-04  2:53       ` Kang Kai
2014-03-31 16:30 ` Richard Purdie
  -- strict thread matches above, loose matches on Subject: below --
2014-02-13  3:48 rongqing.li
2014-02-13 11:45 ` David Nyström
2014-02-13 12:04 ` Richard Purdie
2014-02-13  3:34 rongqing.li
2014-02-13  5:04 ` Rongqing Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396283535.14790.78.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox