* [PATCH] libtool: Add depends on binutils-cross
@ 2014-04-01 6:12 b40527
2014-04-01 6:15 ` Khem Raj
2014-04-01 10:52 ` Richard Purdie
0 siblings, 2 replies; 6+ messages in thread
From: b40527 @ 2014-04-01 6:12 UTC (permalink / raw)
To: openembedded-core; +Cc: Zongchun Yu
From: Zongchun Yu <Zongchun.Yu@freescale.com>
When use command bitbake -c populate_sdk <target-rootfs> to
generate toolchain. a race issue may occur. in this case need
to add binutils-cross to depends.
Signed-off-by: Zongchun Yu <Zongchun.Yu@freescale.com>
---
meta/recipes-devtools/libtool/libtool-2.4.2.inc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-devtools/libtool/libtool-2.4.2.inc b/meta/recipes-devtools/libtool/libtool-2.4.2.inc
index d26982d..0868dd7 100644
--- a/meta/recipes-devtools/libtool/libtool-2.4.2.inc
+++ b/meta/recipes-devtools/libtool/libtool-2.4.2.inc
@@ -36,7 +36,7 @@ do_compile_prepend () {
inherit autotools
EXTRA_AUTORECONF = "--exclude=libtoolize"
-DEPENDS = "libtool-native"
+DEPENDS = "libtool-native binutils-cross"
PACKAGES =+ "libltdl libltdl-dev libltdl-dbg libltdl-staticdev"
FILES_${PN} += "${datadir}/aclocal"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] libtool: Add depends on binutils-cross
2014-04-01 6:12 [PATCH] libtool: Add depends on binutils-cross b40527
@ 2014-04-01 6:15 ` Khem Raj
2014-04-01 6:37 ` Zongchun YU
2014-04-01 10:52 ` Richard Purdie
1 sibling, 1 reply; 6+ messages in thread
From: Khem Raj @ 2014-04-01 6:15 UTC (permalink / raw)
To: b40527; +Cc: Zongchun Yu, openembedded-core
[-- Attachment #1: Type: text/plain, Size: 355 bytes --]
On Mar 31, 2014, at 11:12 PM, <b40527@freescale.com> <b40527@freescale.com> wrote:
> From: Zongchun Yu <Zongchun.Yu@freescale.com>
>
> When use command bitbake -c populate_sdk <target-rootfs> to
> generate toolchain. a race issue may occur. in this case need
> to add binutils-cross to depends.
>
can you explain the race a bit here.
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 169 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libtool: Add depends on binutils-cross
2014-04-01 6:15 ` Khem Raj
@ 2014-04-01 6:37 ` Zongchun YU
2014-04-01 6:46 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Zongchun YU @ 2014-04-01 6:37 UTC (permalink / raw)
To: 'Khem Raj'; +Cc: openembedded-core
>can you explain the race a bit here.
Sorry to confuse you. Sometimes libtool have been built but the
binutils-cross have't been built yet.
It is required by libtool.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libtool: Add depends on binutils-cross
2014-04-01 6:37 ` Zongchun YU
@ 2014-04-01 6:46 ` Khem Raj
2014-04-01 7:22 ` Zongchun YU
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2014-04-01 6:46 UTC (permalink / raw)
To: Zongchun YU; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
On Mar 31, 2014, at 11:37 PM, Zongchun YU <b40527@freescale.com> wrote:
> Sorry to confuse you. Sometimes libtool have been built but the
> binutils-cross have't been built yet.
> It is required by libtool.
OK is it cross, native or target recipe which has the problem ?
wouldnt it need to also depend on gcc-cross ?
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 169 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libtool: Add depends on binutils-cross
2014-04-01 6:46 ` Khem Raj
@ 2014-04-01 7:22 ` Zongchun YU
0 siblings, 0 replies; 6+ messages in thread
From: Zongchun YU @ 2014-04-01 7:22 UTC (permalink / raw)
To: 'Khem Raj'; +Cc: openembedded-core
>OK is it cross, native or target recipe which has the problem ?
>wouldnt it need to also depend on gcc-cross ?
Only cross recipe has the problem. There is no need to gcc-cross.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] libtool: Add depends on binutils-cross
2014-04-01 6:12 [PATCH] libtool: Add depends on binutils-cross b40527
2014-04-01 6:15 ` Khem Raj
@ 2014-04-01 10:52 ` Richard Purdie
1 sibling, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2014-04-01 10:52 UTC (permalink / raw)
To: b40527; +Cc: Zongchun Yu, openembedded-core
On Tue, 2014-04-01 at 14:12 +0800, b40527@freescale.com wrote:
> From: Zongchun Yu <Zongchun.Yu@freescale.com>
>
> When use command bitbake -c populate_sdk <target-rootfs> to
> generate toolchain. a race issue may occur. in this case need
> to add binutils-cross to depends.
>
> Signed-off-by: Zongchun Yu <Zongchun.Yu@freescale.com>
> ---
> meta/recipes-devtools/libtool/libtool-2.4.2.inc | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-devtools/libtool/libtool-2.4.2.inc b/meta/recipes-devtools/libtool/libtool-2.4.2.inc
> index d26982d..0868dd7 100644
> --- a/meta/recipes-devtools/libtool/libtool-2.4.2.inc
> +++ b/meta/recipes-devtools/libtool/libtool-2.4.2.inc
> @@ -36,7 +36,7 @@ do_compile_prepend () {
> inherit autotools
> EXTRA_AUTORECONF = "--exclude=libtoolize"
>
> -DEPENDS = "libtool-native"
> +DEPENDS = "libtool-native binutils-cross"
>
> PACKAGES =+ "libltdl libltdl-dev libltdl-dbg libltdl-staticdev"
> FILES_${PN} += "${datadir}/aclocal"
You're patching the .inc file here so this dependency is being applied
to multiple different libtools. Can you perhaps explain the problem you
were seeing with a step by step how to reproduce the problem?
I'd like to understand the real problem here, I don't doubt it exists
but I'm not sure this is the correct fix.
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-04-01 10:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-01 6:12 [PATCH] libtool: Add depends on binutils-cross b40527
2014-04-01 6:15 ` Khem Raj
2014-04-01 6:37 ` Zongchun YU
2014-04-01 6:46 ` Khem Raj
2014-04-01 7:22 ` Zongchun YU
2014-04-01 10:52 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox