Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] attr: Fix uclibc builds
@ 2014-05-06 13:49 Richard Purdie
  2014-05-06 17:43 ` Khem Raj
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2014-05-06 13:49 UTC (permalink / raw)
  To: openembedded-core

attr needs libintl headers and libs. Add in the missing dependency and
the missing linker flag.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/meta/recipes-support/attr/attr.inc b/meta/recipes-support/attr/attr.inc
index 873c1ff..63964e75 100644
--- a/meta/recipes-support/attr/attr.inc
+++ b/meta/recipes-support/attr/attr.inc
@@ -2,7 +2,7 @@ SUMMARY = "Utilities for manipulating filesystem extended attributes"
 HOMEPAGE = "http://savannah.nongnu.org/projects/attr/"
 SECTION = "libs"
 
-DEPENDS = "ncurses"
+DEPENDS = "ncurses virtual/libintl"
 
 LICENSE = "LGPLv2.1+ & GPLv2+"
 LICENSE_${PN} = "GPLv2+"
@@ -17,6 +17,8 @@ SRC_URI = "http://download.savannah.gnu.org/releases/attr/${BP}.src.tar.gz \
 
 require ea-acl.inc
 
+LDFLAGS_append_libc-uclibc = " -lintl"
+
 # libdir should point to .la
 do_install_append() {
 	sed -i ${D}${libdir}/libattr.la -e \




^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] attr: Fix uclibc builds
  2014-05-06 13:49 Richard Purdie
@ 2014-05-06 17:43 ` Khem Raj
  2014-05-06 20:37   ` Richard Purdie
  0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2014-05-06 17:43 UTC (permalink / raw)
  To: Richard Purdie; +Cc: openembedded-core

Richard


On Tue, May 6, 2014 at 6:49 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> attr needs libintl headers and libs. Add in the missing dependency and
> the missing linker flag.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/recipes-support/attr/attr.inc b/meta/recipes-support/attr/attr.inc
> index 873c1ff..63964e75 100644
> --- a/meta/recipes-support/attr/attr.inc
> +++ b/meta/recipes-support/attr/attr.inc
> @@ -2,7 +2,7 @@ SUMMARY = "Utilities for manipulating filesystem extended attributes"
>  HOMEPAGE = "http://savannah.nongnu.org/projects/attr/"
>  SECTION = "libs"
>
> -DEPENDS = "ncurses"
> +DEPENDS = "ncurses virtual/libintl"
>

may be something like
http://git.openembedded.org/openembedded-core-contrib/commit/?h=kraj/musl&id=6c67b40e4784e12ed6a71ab4696710b913e55455

is needed here.

Secondly we already have

LDFLAGS_append_libc-uclibc = "${@['', ' -lintl '][(d.getVar('PN',
True) == d.getVar('BPN', True)) and (d.getVar('USE_NLS', True) ==
'yes')]}"

in ea-acl.inc




>  LICENSE = "LGPLv2.1+ & GPLv2+"
>  LICENSE_${PN} = "GPLv2+"
> @@ -17,6 +17,8 @@ SRC_URI = "http://download.savannah.gnu.org/releases/attr/${BP}.src.tar.gz \
>
>  require ea-acl.inc
>
> +LDFLAGS_append_libc-uclibc = " -lintl"
> +
>  # libdir should point to .la
>  do_install_append() {
>         sed -i ${D}${libdir}/libattr.la -e \
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] attr: Fix uclibc builds
  2014-05-06 17:43 ` Khem Raj
@ 2014-05-06 20:37   ` Richard Purdie
  2014-05-06 20:48     ` Khem Raj
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2014-05-06 20:37 UTC (permalink / raw)
  To: Khem Raj; +Cc: openembedded-core

On Tue, 2014-05-06 at 10:43 -0700, Khem Raj wrote:
> Richard
> 
> 
> On Tue, May 6, 2014 at 6:49 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > attr needs libintl headers and libs. Add in the missing dependency and
> > the missing linker flag.
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> > diff --git a/meta/recipes-support/attr/attr.inc b/meta/recipes-support/attr/attr.inc
> > index 873c1ff..63964e75 100644
> > --- a/meta/recipes-support/attr/attr.inc
> > +++ b/meta/recipes-support/attr/attr.inc
> > @@ -2,7 +2,7 @@ SUMMARY = "Utilities for manipulating filesystem extended attributes"
> >  HOMEPAGE = "http://savannah.nongnu.org/projects/attr/"
> >  SECTION = "libs"
> >
> > -DEPENDS = "ncurses"
> > +DEPENDS = "ncurses virtual/libintl"
> >
> 
> may be something like
> http://git.openembedded.org/openembedded-core-contrib/commit/?h=kraj/musl&id=6c67b40e4784e12ed6a71ab4696710b913e55455
> 
> is needed here.
> 
> Secondly we already have
> 
> LDFLAGS_append_libc-uclibc = "${@['', ' -lintl '][(d.getVar('PN',
> True) == d.getVar('BPN', True)) and (d.getVar('USE_NLS', True) ==
> 'yes')]}"
> 
> in ea-acl.inc

Hmm, I hadn't seen that. The trouble is that I'm setting up uclibc as a
multilib and this conditional may be wrong, we may need to rethink the
PN == BPN as it isn't in the multilib case.

Cheers,

Richard



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] attr: Fix uclibc builds
  2014-05-06 20:37   ` Richard Purdie
@ 2014-05-06 20:48     ` Khem Raj
  0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2014-05-06 20:48 UTC (permalink / raw)
  To: Richard Purdie; +Cc: openembedded-core

On Tue, May 6, 2014 at 1:37 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> PN == BPN as it isn't in the multilib case.

we may not need that any more since back than we did not differentiate
between native and target recipes.


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] attr: Fix uclibc builds
@ 2014-05-08 12:11 Richard Purdie
  2014-05-08 19:17 ` Khem Raj
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2014-05-08 12:11 UTC (permalink / raw)
  To: openembedded-core

attr needs libintl headers and libs. Add in the missing dependency and
ensure the linker flag gets passed in multilib builds by replacing the
PN == BPN check with a class-target override instead.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/meta/recipes-support/attr/attr.inc b/meta/recipes-support/attr/attr.inc
index 873c1ff..01ad59c 100644
--- a/meta/recipes-support/attr/attr.inc
+++ b/meta/recipes-support/attr/attr.inc
@@ -2,7 +2,7 @@ SUMMARY = "Utilities for manipulating filesystem extended attributes"
 HOMEPAGE = "http://savannah.nongnu.org/projects/attr/"
 SECTION = "libs"
 
-DEPENDS = "ncurses"
+DEPENDS = "ncurses virtual/libintl"
 
 LICENSE = "LGPLv2.1+ & GPLv2+"
 LICENSE_${PN} = "GPLv2+"
diff --git a/meta/recipes-support/attr/ea-acl.inc b/meta/recipes-support/attr/ea-acl.inc
index 785ce0c..72f623e 100644
--- a/meta/recipes-support/attr/ea-acl.inc
+++ b/meta/recipes-support/attr/ea-acl.inc
@@ -34,8 +34,8 @@ FILES_lib${BPN}-doc = "${mandir}/man2 \
 
 BBCLASSEXTEND = "native"
 # Only append ldflags for target recipe and if USE_NLS is enabled
-LDFLAGS_append_libc-uclibc = "${@['', ' -lintl '][(d.getVar('PN', True) == d.getVar('BPN', True)) and (d.getVar('USE_NLS', True) == 'yes')]}"
-EXTRA_OECONF_append_libc-uclibc = "${@['', ' --disable-gettext '][(d.getVar('PN', True) == d.getVar('BPN', True)) and (d.getVar('USE_NLS', True) == 'no')]}"
+LDFLAGS_append_libc-uclibc_class-target = "${@['', ' -lintl '][(d.getVar('USE_NLS', True) == 'yes')]}"
+EXTRA_OECONF_append_libc-uclibc_class-target = "${@['', ' --disable-gettext '][(d.getVar('USE_NLS', True) == 'no')]}"
 
 fix_symlink () {
 	if test "${libdir}" = "${base_libdir}" ; then




^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] attr: Fix uclibc builds
  2014-05-08 12:11 [PATCH] attr: Fix uclibc builds Richard Purdie
@ 2014-05-08 19:17 ` Khem Raj
  0 siblings, 0 replies; 6+ messages in thread
From: Khem Raj @ 2014-05-08 19:17 UTC (permalink / raw)
  To: Richard Purdie; +Cc: openembedded-core

On Thu, May 8, 2014 at 5:11 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> +LDFLAGS_append_libc-uclibc_class-target = "${@['', ' -lintl '][(d.getVar('USE_NLS', True) == 'yes')]}"
> +EXTRA_OECONF_append_libc-uclibc_class-target = "${@['', ' --disable-gettext '][(d.getVar('USE_NLS', True) == 'no')]}"

I think we can drop class-target override. this was needed when libc
override arched into native recipes as well and
we would get attr-native compiled differently for uclibc and glibc but
thats been fixed


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-08 19:25 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-08 12:11 [PATCH] attr: Fix uclibc builds Richard Purdie
2014-05-08 19:17 ` Khem Raj
  -- strict thread matches above, loose matches on Subject: below --
2014-05-06 13:49 Richard Purdie
2014-05-06 17:43 ` Khem Raj
2014-05-06 20:37   ` Richard Purdie
2014-05-06 20:48     ` Khem Raj

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox