Openembedded Core Discussions
 help / color / mirror / Atom feed
* [OE-core][PATCH] lib: sbom30: Prefix aliases with "http://spdx.org/spdxdocs/"
@ 2024-11-22 20:15 Joshua Watt
  2024-11-23  1:57 ` [PATCH] " hongxu
  0 siblings, 1 reply; 2+ messages in thread
From: Joshua Watt @ 2024-11-22 20:15 UTC (permalink / raw)
  To: openembedded-core; +Cc: Joshua Watt

While the SPDX ID aliases are primarily intended for internal use by the
SPDX code, they are used in places where a valid SPDX ID is expected. In
order to make sure that they still conform to this, prefix them with
"http://spdx.org/spdxdocs/openembedded-alias"

Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
 meta/lib/oe/sbom30.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/lib/oe/sbom30.py b/meta/lib/oe/sbom30.py
index 56cdd7ba4c6..7acb5234db2 100644
--- a/meta/lib/oe/sbom30.py
+++ b/meta/lib/oe/sbom30.py
@@ -344,7 +344,9 @@ class ObjectSet(oe.spdx30.SHACLObjectSet):
                 alias_ext = set_alias(
                     e,
                     e._id.replace(unihash, "UNIHASH").replace(
-                        namespace, self.d.getVar("PN")
+                        namespace,
+                        "http://spdx.org/spdxdocs/openembedded-alias/"
+                        + self.d.getVar("PN"),
                     ),
                 )
 
-- 
2.47.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] lib: sbom30: Prefix aliases with "http://spdx.org/spdxdocs/"
  2024-11-22 20:15 [OE-core][PATCH] lib: sbom30: Prefix aliases with "http://spdx.org/spdxdocs/" Joshua Watt
@ 2024-11-23  1:57 ` hongxu
  0 siblings, 0 replies; 2+ messages in thread
From: hongxu @ 2024-11-23  1:57 UTC (permalink / raw)
  To: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

Hi Joshua,

This patch conflicts with '[PATCH V2 1/3] sbom30/spdx30: add link prefix and name to namespace of spdxId and alias '[1],
would you have suggestions about review '[RR V2][NULL][0/3] SPDX 3.0: Reduce redundant spdxid-hash symlinks to save inode on host '[2]?
Should I rebase my review along with your patch?

[1]https://lists.openembedded.org/g/openembedded-core/message/207412?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2C%2C20%2C2%2C0%2C109680229%2Cd%253D4&d=4
[2]https://lists.openembedded.org/g/openembedded-core/topic/109680228#msg207411

//Hongxu

[-- Attachment #2: Type: text/html, Size: 704 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-23  1:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-22 20:15 [OE-core][PATCH] lib: sbom30: Prefix aliases with "http://spdx.org/spdxdocs/" Joshua Watt
2024-11-23  1:57 ` [PATCH] " hongxu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox