From: Tom Rini <tom.rini@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH] image.bbclass: Ensure IMAGE_FSTYPES is fully evaluated before live/live logic
Date: Thu, 26 Jun 2014 08:27:32 -0400 [thread overview]
Message-ID: <1403785652-17065-1-git-send-email-tom.rini@gmail.com> (raw)
Incase we have overrides applied to IMAGE_FSTYPES we need to make sure
that we evaluate it fully before performing the live and vmdk logic
checks.
Signed-off-by: Tom Rini <tom.rini@gmail.com>
---
meta/classes/image.bbclass | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 79de5a2..ccfa1b1 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -78,10 +78,11 @@ do_rootfs[vardeps] += "BAD_RECOMMENDATIONS NO_RECOMMENDATIONS"
do_build[depends] += "virtual/kernel:do_deploy"
+EVALED_IMAGE_FSTYPES := "${IMAGE_FSTYPES}"
def build_live(d):
- if base_contains("IMAGE_FSTYPES", "live", "live", "0", d) == "0": # live is not set but hob might set iso or hddimg
- d.setVar('NOISO', base_contains('IMAGE_FSTYPES', "iso", "0", "1", d))
- d.setVar('NOHDD', base_contains('IMAGE_FSTYPES', "hddimg", "0", "1", d))
+ if base_contains("EVALED_IMAGE_FSTYPES", "live", "live", "0", d) == "0": # live is not set but hob might set iso or hddimg
+ d.setVar('NOISO', base_contains('EVALED_IMAGE_FSTYPES', "iso", "0", "1", d))
+ d.setVar('NOHDD', base_contains('EVALED_IMAGE_FSTYPES', "hddimg", "0", "1", d))
if d.getVar('NOISO', True) == "0" or d.getVar('NOHDD', True) == "0":
return "image-live"
return ""
@@ -90,7 +91,7 @@ def build_live(d):
IMAGE_TYPE_live = "${@build_live(d)}"
inherit ${IMAGE_TYPE_live}
-IMAGE_TYPE_vmdk = '${@base_contains("IMAGE_FSTYPES", "vmdk", "image-vmdk", "", d)}'
+IMAGE_TYPE_vmdk = '${@base_contains("EVALED_IMAGE_FSTYPES", "vmdk", "image-vmdk", "", d)}'
inherit ${IMAGE_TYPE_vmdk}
python () {
--
1.9.3
next reply other threads:[~2014-06-26 12:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 12:27 Tom Rini [this message]
2014-06-26 17:25 ` [PATCH] image.bbclass: Ensure IMAGE_FSTYPES is fully evaluated before live/live logic Otavio Salvador
2014-06-27 12:42 ` Tom Rini
2014-06-27 13:11 ` Otavio Salvador
2014-06-27 13:40 ` Richard Purdie
2014-06-27 14:16 ` Tom Rini
2014-06-27 14:54 ` Richard Purdie
2014-06-27 15:17 ` Tom Rini
2014-06-28 8:35 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403785652-17065-1-git-send-email-tom.rini@gmail.com \
--to=tom.rini@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox