From: Tom Rini <tom.rini@gmail.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] image.bbclass: Ensure IMAGE_FSTYPES is fully evaluated before live/live logic
Date: Fri, 27 Jun 2014 08:42:09 -0400 [thread overview]
Message-ID: <20140627124209.GS9006@bill-the-cat> (raw)
In-Reply-To: <CAP9ODKopjX4Jg5rTDLunZnV4xioqP7dCP09o-GB0t4yJxE-L3Q@mail.gmail.com>
On Thu, Jun 26, 2014 at 02:25:34PM -0300, Otavio Salvador wrote:
> On Thu, Jun 26, 2014 at 9:27 AM, Tom Rini <tom.rini@gmail.com> wrote:
> > Incase we have overrides applied to IMAGE_FSTYPES we need to make sure
> > that we evaluate it fully before performing the live and vmdk logic
> > checks.
> >
> > Signed-off-by: Tom Rini <tom.rini@gmail.com>
>
> Do you have an example how it used to fail?
Sure:
diff --git a/meta/recipes-core/images/build-appliance-image_8.0.bb b/meta/recipes-core/images/build-appliance-image_8.0.bb
index 7b70025..23bb02e 100644
--- a/meta/recipes-core/images/build-appliance-image_8.0.bb
+++ b/meta/recipes-core/images/build-appliance-image_8.0.bb
@@ -17,7 +17,7 @@ IMAGE_ROOTFS_EXTRA_SPACE = "41943040"
APPEND += "quiet"
DEPENDS = "zip-native"
-IMAGE_FSTYPES = "vmdk"
+IMAGE_FSTYPES_x86-64 = "vmdk"
inherit core-image
And now you won't get vmdk images on qemux86-64 (same for live, did the
same proof-of-concept there when working up the patch).
--
Tom
next prev parent reply other threads:[~2014-06-27 12:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 12:27 [PATCH] image.bbclass: Ensure IMAGE_FSTYPES is fully evaluated before live/live logic Tom Rini
2014-06-26 17:25 ` Otavio Salvador
2014-06-27 12:42 ` Tom Rini [this message]
2014-06-27 13:11 ` Otavio Salvador
2014-06-27 13:40 ` Richard Purdie
2014-06-27 14:16 ` Tom Rini
2014-06-27 14:54 ` Richard Purdie
2014-06-27 15:17 ` Tom Rini
2014-06-28 8:35 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140627124209.GS9006@bill-the-cat \
--to=tom.rini@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox