Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] useradd: Add setscene dep on pseudo-native
@ 2014-08-10 21:00 Jate Sujjavanich
  2014-08-15 15:41 ` Jate Sujjavanich
  2014-08-29 15:40 ` Jate Sujjavanich
  0 siblings, 2 replies; 4+ messages in thread
From: Jate Sujjavanich @ 2014-08-10 21:00 UTC (permalink / raw)
  To: openembedded-core

A recipe will sometimes be rebuilt unnecessarily if it adds users via
useradd and the pseudo-native task has not been populated.

This patch adds the correct dependency.

Signed-off-by: Jate Sujjavanich <jatedev@gmail.com>
---
 meta/classes/useradd.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
index ea15dab..3b70e80 100644
--- a/meta/classes/useradd.bbclass
+++ b/meta/classes/useradd.bbclass
@@ -126,7 +126,7 @@ SYSROOTPOSTFUNC_class-cross = ""
 SYSROOTPOSTFUNC_class-native = ""
 SYSROOTPOSTFUNC_class-nativesdk = ""
 
-USERADDSETSCENEDEPS = "${MLPREFIX}base-passwd:do_populate_sysroot_setscene shadow-native:do_populate_sysroot_setscene ${MLPREFIX}shadow-sysroot:do_populate_sysroot_setscene"
+USERADDSETSCENEDEPS = "${MLPREFIX}base-passwd:do_populate_sysroot_setscene pseudo-native:do_populate_sysroot_setscene shadow-native:do_populate_sysroot_setscene ${MLPREFIX}shadow-sysroot:do_populate_sysroot_setscene"
 USERADDSETSCENEDEPS_class-cross = ""
 USERADDSETSCENEDEPS_class-native = ""
 USERADDSETSCENEDEPS_class-nativesdk = ""
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] useradd: Add setscene dep on pseudo-native
  2014-08-10 21:00 [PATCH] useradd: Add setscene dep on pseudo-native Jate Sujjavanich
@ 2014-08-15 15:41 ` Jate Sujjavanich
  2014-08-29 15:40 ` Jate Sujjavanich
  1 sibling, 0 replies; 4+ messages in thread
From: Jate Sujjavanich @ 2014-08-15 15:41 UTC (permalink / raw)
  To: Richard Purdie; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]

Ping


On Sun, Aug 10, 2014 at 5:00 PM, Jate Sujjavanich <jatedev@gmail.com> wrote:

> A recipe will sometimes be rebuilt unnecessarily if it adds users via
> useradd and the pseudo-native task has not been populated.
>
> This patch adds the correct dependency.
>
> Signed-off-by: Jate Sujjavanich <jatedev@gmail.com>
> ---
>  meta/classes/useradd.bbclass |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
> index ea15dab..3b70e80 100644
> --- a/meta/classes/useradd.bbclass
> +++ b/meta/classes/useradd.bbclass
> @@ -126,7 +126,7 @@ SYSROOTPOSTFUNC_class-cross = ""
>  SYSROOTPOSTFUNC_class-native = ""
>  SYSROOTPOSTFUNC_class-nativesdk = ""
>
> -USERADDSETSCENEDEPS =
> "${MLPREFIX}base-passwd:do_populate_sysroot_setscene
> shadow-native:do_populate_sysroot_setscene
> ${MLPREFIX}shadow-sysroot:do_populate_sysroot_setscene"
> +USERADDSETSCENEDEPS =
> "${MLPREFIX}base-passwd:do_populate_sysroot_setscene
> pseudo-native:do_populate_sysroot_setscene
> shadow-native:do_populate_sysroot_setscene
> ${MLPREFIX}shadow-sysroot:do_populate_sysroot_setscene"
>  USERADDSETSCENEDEPS_class-cross = ""
>  USERADDSETSCENEDEPS_class-native = ""
>  USERADDSETSCENEDEPS_class-nativesdk = ""
> --
> 1.7.9.5
>
>

[-- Attachment #2: Type: text/html, Size: 1848 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] useradd: Add setscene dep on pseudo-native
  2014-08-10 21:00 [PATCH] useradd: Add setscene dep on pseudo-native Jate Sujjavanich
  2014-08-15 15:41 ` Jate Sujjavanich
@ 2014-08-29 15:40 ` Jate Sujjavanich
  2014-08-30  7:59   ` Richard Purdie
  1 sibling, 1 reply; 4+ messages in thread
From: Jate Sujjavanich @ 2014-08-29 15:40 UTC (permalink / raw)
  To: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1507 bytes --]

There's a commit in poky's master-next with the message "bitbake: runqueue:
Fix setscene tasks not running".

Should it fix the problem fixed by my patch?


Thanks,

- Jate S.



On Sun, Aug 10, 2014 at 5:00 PM, Jate Sujjavanich <jatedev@gmail.com> wrote:

> A recipe will sometimes be rebuilt unnecessarily if it adds users via
> useradd and the pseudo-native task has not been populated.
>
> This patch adds the correct dependency.
>
> Signed-off-by: Jate Sujjavanich <jatedev@gmail.com>
> ---
>  meta/classes/useradd.bbclass |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
> index ea15dab..3b70e80 100644
> --- a/meta/classes/useradd.bbclass
> +++ b/meta/classes/useradd.bbclass
> @@ -126,7 +126,7 @@ SYSROOTPOSTFUNC_class-cross = ""
>  SYSROOTPOSTFUNC_class-native = ""
>  SYSROOTPOSTFUNC_class-nativesdk = ""
>
> -USERADDSETSCENEDEPS =
> "${MLPREFIX}base-passwd:do_populate_sysroot_setscene
> shadow-native:do_populate_sysroot_setscene
> ${MLPREFIX}shadow-sysroot:do_populate_sysroot_setscene"
> +USERADDSETSCENEDEPS =
> "${MLPREFIX}base-passwd:do_populate_sysroot_setscene
> pseudo-native:do_populate_sysroot_setscene
> shadow-native:do_populate_sysroot_setscene
> ${MLPREFIX}shadow-sysroot:do_populate_sysroot_setscene"
>  USERADDSETSCENEDEPS_class-cross = ""
>  USERADDSETSCENEDEPS_class-native = ""
>  USERADDSETSCENEDEPS_class-nativesdk = ""
> --
> 1.7.9.5
>
>

[-- Attachment #2: Type: text/html, Size: 2097 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] useradd: Add setscene dep on pseudo-native
  2014-08-29 15:40 ` Jate Sujjavanich
@ 2014-08-30  7:59   ` Richard Purdie
  0 siblings, 0 replies; 4+ messages in thread
From: Richard Purdie @ 2014-08-30  7:59 UTC (permalink / raw)
  To: Jate Sujjavanich; +Cc: openembedded-core

On Fri, 2014-08-29 at 11:40 -0400, Jate Sujjavanich wrote:
> There's a commit in poky's master-next with the message "bitbake:
> runqueue: Fix setscene tasks not running".
>
> Should it fix the problem fixed by my patch?

No, your patch does need to merge, I've done that.

Cheers,

Richard




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-08-30  7:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-10 21:00 [PATCH] useradd: Add setscene dep on pseudo-native Jate Sujjavanich
2014-08-15 15:41 ` Jate Sujjavanich
2014-08-29 15:40 ` Jate Sujjavanich
2014-08-30  7:59   ` Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox