[PATCH 0/1] i2c-tools: create i2c-tools-misc package for perl scripts

[PATCH 0/1] i2c-tools: create i2c-tools-misc package for perl scripts

[Chong Lu]

The following changes since commit 83ebcb1f0c6ec48c526d14324b3b2037f0f4fe43:

  bitbake: process: Ensure abnormal exits set an error level (2014-09-02 18:10:37 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib chonglu/i2c-tools
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/i2c-tools

Chong Lu (1):
  i2c-tools: create i2c-tools-misc package for perl scripts

 meta/recipes-devtools/i2c-tools/i2c-tools_3.1.1.bb | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

-- 
1.9.1

[PATCH 1/1] i2c-tools: create i2c-tools-misc package for perl scripts

[Chong Lu]

We don't want to install perl on small file systems by default.

The solution is to split those perl scripts from the main package, installing
them only when perl is available. We use PACKAGECONFIG to create and enable a
new feature "misc".

Add perl to RDEPENDS_i2c-tools-misc.

Signed-off-by: Michel Thebeau <michel.thebeau@windriver.com>
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
---
 meta/recipes-devtools/i2c-tools/i2c-tools_3.1.1.bb | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/i2c-tools/i2c-tools_3.1.1.bb b/meta/recipes-devtools/i2c-tools/i2c-tools_3.1.1.bb
index 4605414..854d180 100644
--- a/meta/recipes-devtools/i2c-tools/i2c-tools_3.1.1.bb
+++ b/meta/recipes-devtools/i2c-tools/i2c-tools_3.1.1.bb
@@ -3,8 +3,6 @@ SECTION = "base"
 LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
 
-RDEPENDS_${PN} += "perl"
-
 SRC_URI = "http://dl.lm-sensors.org/i2c-tools/releases/${BP}.tar.bz2 \
            file://Module.mk \
 "
@@ -24,3 +22,15 @@ do_install_append() {
     install -m 0644 include/linux/i2c-dev.h ${D}${includedir}/linux/i2c-dev-user.h
     rm -f ${D}${includedir}/linux/i2c-dev.h
 }
+
+PACKAGES =+ "${PN}-misc"
+RDEPENDS_${PN}-misc += "perl"
+FILES_${PN}-misc = "${sbindir}/i2c-stub-from-dump \
+                        ${bindir}/ddcmon \
+                        ${bindir}/decode-edid \
+                        ${bindir}/decode-dimms \
+                        ${bindir}/decode-vaio \
+                       "
+
+PACKAGECONFIG ??= "misc"
+PACKAGECONFIG[misc] = ",,, ${PN}-misc perl"
-- 
1.9.1

Re: [PATCH 1/1] i2c-tools: create i2c-tools-misc package for perl scripts

[Richard Purdie]

On Wed, 2014-09-03 at 17:36 +0800, Chong Lu wrote:
> We don't want to install perl on small file systems by default.
> 
> The solution is to split those perl scripts from the main package, installing
> them only when perl is available. We use PACKAGECONFIG to create and enable a
> new feature "misc".
> 
> Add perl to RDEPENDS_i2c-tools-misc.
> 
> Signed-off-by: Michel Thebeau <michel.thebeau@windriver.com>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
> ---
>  meta/recipes-devtools/i2c-tools/i2c-tools_3.1.1.bb | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/i2c-tools/i2c-tools_3.1.1.bb b/meta/recipes-devtools/i2c-tools/i2c-tools_3.1.1.bb
> index 4605414..854d180 100644
> --- a/meta/recipes-devtools/i2c-tools/i2c-tools_3.1.1.bb
> +++ b/meta/recipes-devtools/i2c-tools/i2c-tools_3.1.1.bb
> @@ -3,8 +3,6 @@ SECTION = "base"
>  LICENSE = "GPLv2+"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
>  
> -RDEPENDS_${PN} += "perl"
> -
>  SRC_URI = "http://dl.lm-sensors.org/i2c-tools/releases/${BP}.tar.bz2 \
>             file://Module.mk \
>  "
> @@ -24,3 +22,15 @@ do_install_append() {
>      install -m 0644 include/linux/i2c-dev.h ${D}${includedir}/linux/i2c-dev-user.h
>      rm -f ${D}${includedir}/linux/i2c-dev.h
>  }
> +
> +PACKAGES =+ "${PN}-misc"
> +RDEPENDS_${PN}-misc += "perl"
> +FILES_${PN}-misc = "${sbindir}/i2c-stub-from-dump \
> +                        ${bindir}/ddcmon \
> +                        ${bindir}/decode-edid \
> +                        ${bindir}/decode-dimms \
> +                        ${bindir}/decode-vaio \
> +                       "
> +
> +PACKAGECONFIG ??= "misc"
> +PACKAGECONFIG[misc] = ",,, ${PN}-misc perl"

As far as I can tell, these PACKAGECONFIG lines do nothing. Putting the
perl utils into a separate package is fine but the PACKAGECONFIG does
nothing...

Cheers,

Richard