* [PATCH V2 0/1] perf: fix issue about package splitting @ 2014-09-03 9:05 Chong Lu 2014-09-03 9:05 ` [PATCH V2 1/1] " Chong Lu 0 siblings, 1 reply; 9+ messages in thread From: Chong Lu @ 2014-09-03 9:05 UTC (permalink / raw) To: openembedded-core The following changes since commit 83ebcb1f0c6ec48c526d14324b3b2037f0f4fe43: bitbake: process: Ensure abnormal exits set an error level (2014-09-02 18:10:37 +0100) are available in the git repository at: git://git.pokylinux.org/poky-contrib chonglu/perf http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/perf Chong Lu (1): perf: fix issue about package splitting meta/recipes-kernel/perf/perf.bb | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) -- 1.9.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH V2 1/1] perf: fix issue about package splitting 2014-09-03 9:05 [PATCH V2 0/1] perf: fix issue about package splitting Chong Lu @ 2014-09-03 9:05 ` Chong Lu 2014-09-03 10:42 ` Richard Purdie 0 siblings, 1 reply; 9+ messages in thread From: Chong Lu @ 2014-09-03 9:05 UTC (permalink / raw) To: openembedded-core Currently, perf can't split to perf-archive, perf-tests, perf-python and perf-perl. All files are included in perf package. Change the files paths to make split successfully and add PACKAGECONFIG to make main pkg depends on sub pkgs as default. Signed-off-by: Chong Lu <Chong.Lu@windriver.com> --- meta/recipes-kernel/perf/perf.bb | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb index bfd210c..baf0077 100644 --- a/meta/recipes-kernel/perf/perf.bb +++ b/meta/recipes-kernel/perf/perf.bb @@ -149,20 +149,27 @@ PACKAGE_ARCH = "${MACHINE_ARCH}" PACKAGES =+ "${PN}-archive ${PN}-tests ${PN}-perl ${PN}-python" +PACKAGECONFIG ??= "archive perl python tests" +PACKAGECONFIG[archive] = ",,, ${PN}-archive" +PACKAGECONFIG[perl] = ",,, ${PN}-perl" +PACKAGECONFIG[python] = ",,, ${PN}-python" +PACKAGECONFIG[tests] = ",,, ${PN}-tests" + RDEPENDS_${PN} += "elfutils" RDEPENDS_${PN}-archive =+ "bash" RDEPENDS_${PN}-python =+ "bash python" RDEPENDS_${PN}-perl =+ "bash perl perl-modules" +RDEPENDS_${PN}-tests =+ "python" RSUGGESTS_SCRIPTING = "${@perf_feature_enabled('perf-scripting', '${PN}-perl ${PN}-python', '',d)}" RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests ${RSUGGESTS_SCRIPTING}" -FILES_${PN} += "${libexecdir}/perf-core ${exec_prefix}/libexec/perf-core ${libdir}/traceevent" +FILES_${PN} += "${libdir}/traceevent" FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug" -FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive" -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests" -FILES_${PN}-python = "${libdir}/python*/site-packages ${libdir}/perf/perf-core/scripts/python" -FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl" +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive" +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests" +FILES_${PN}-python = "${exec_prefix}/libexec/perf-core/scripts/python" +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl" INHIBIT_PACKAGE_DEBUG_SPLIT="1" -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH V2 1/1] perf: fix issue about package splitting 2014-09-03 9:05 ` [PATCH V2 1/1] " Chong Lu @ 2014-09-03 10:42 ` Richard Purdie 2014-09-04 7:27 ` Chong Lu 0 siblings, 1 reply; 9+ messages in thread From: Richard Purdie @ 2014-09-03 10:42 UTC (permalink / raw) To: Chong Lu; +Cc: openembedded-core On Wed, 2014-09-03 at 17:05 +0800, Chong Lu wrote: > Currently, perf can't split to perf-archive, perf-tests, perf-python and > perf-perl. All files are included in perf package. Change the files paths to > make split successfully and add PACKAGECONFIG to make main pkg depends on sub > pkgs as default. > > Signed-off-by: Chong Lu <Chong.Lu@windriver.com> > --- > meta/recipes-kernel/perf/perf.bb | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb > index bfd210c..baf0077 100644 > --- a/meta/recipes-kernel/perf/perf.bb > +++ b/meta/recipes-kernel/perf/perf.bb > @@ -149,20 +149,27 @@ PACKAGE_ARCH = "${MACHINE_ARCH}" > > PACKAGES =+ "${PN}-archive ${PN}-tests ${PN}-perl ${PN}-python" > > +PACKAGECONFIG ??= "archive perl python tests" > +PACKAGECONFIG[archive] = ",,, ${PN}-archive" > +PACKAGECONFIG[perl] = ",,, ${PN}-perl" > +PACKAGECONFIG[python] = ",,, ${PN}-python" > +PACKAGECONFIG[tests] = ",,, ${PN}-tests" > + > RDEPENDS_${PN} += "elfutils" > RDEPENDS_${PN}-archive =+ "bash" > RDEPENDS_${PN}-python =+ "bash python" > RDEPENDS_${PN}-perl =+ "bash perl perl-modules" > +RDEPENDS_${PN}-tests =+ "python" I now realise the trick you're playing with PACKAGECONFIG here. Instead can we just define a package (say ${PN}-all but I'll accept a better name) which has dependencies on archive perl python tests so then the user can choose ${PN}, ${PN}-all or some other combination depending on their needs? > RSUGGESTS_SCRIPTING = "${@perf_feature_enabled('perf-scripting', '${PN}-perl ${PN}-python', '',d)}" > RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests ${RSUGGESTS_SCRIPTING}" > > -FILES_${PN} += "${libexecdir}/perf-core ${exec_prefix}/libexec/perf-core ${libdir}/traceevent" > +FILES_${PN} += "${libdir}/traceevent" > FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug" > -FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive" > -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests" > -FILES_${PN}-python = "${libdir}/python*/site-packages ${libdir}/perf/perf-core/scripts/python" > -FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl" > +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive" > +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests" > +FILES_${PN}-python = "${exec_prefix}/libexec/perf-core/scripts/python" > +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl" Can we use ${libexecdir} here please rather than hardcode it? Cheers, Richard ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V2 1/1] perf: fix issue about package splitting 2014-09-03 10:42 ` Richard Purdie @ 2014-09-04 7:27 ` Chong Lu 2014-09-04 8:06 ` Chong Lu 2014-09-04 8:07 ` Richard Purdie 0 siblings, 2 replies; 9+ messages in thread From: Chong Lu @ 2014-09-04 7:27 UTC (permalink / raw) To: Richard Purdie; +Cc: openembedded-core On 09/03/2014 06:42 PM, Richard Purdie wrote: > On Wed, 2014-09-03 at 17:05 +0800, Chong Lu wrote: >> Currently, perf can't split to perf-archive, perf-tests, perf-python and >> perf-perl. All files are included in perf package. Change the files paths to >> make split successfully and add PACKAGECONFIG to make main pkg depends on sub >> pkgs as default. >> >> Signed-off-by: Chong Lu <Chong.Lu@windriver.com> >> --- >> meta/recipes-kernel/perf/perf.bb | 17 ++++++++++++----- >> 1 file changed, 12 insertions(+), 5 deletions(-) >> >> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb >> index bfd210c..baf0077 100644 >> --- a/meta/recipes-kernel/perf/perf.bb >> +++ b/meta/recipes-kernel/perf/perf.bb >> @@ -149,20 +149,27 @@ PACKAGE_ARCH = "${MACHINE_ARCH}" >> >> PACKAGES =+ "${PN}-archive ${PN}-tests ${PN}-perl ${PN}-python" >> >> +PACKAGECONFIG ??= "archive perl python tests" >> +PACKAGECONFIG[archive] = ",,, ${PN}-archive" >> +PACKAGECONFIG[perl] = ",,, ${PN}-perl" >> +PACKAGECONFIG[python] = ",,, ${PN}-python" >> +PACKAGECONFIG[tests] = ",,, ${PN}-tests" >> + >> RDEPENDS_${PN} += "elfutils" >> RDEPENDS_${PN}-archive =+ "bash" >> RDEPENDS_${PN}-python =+ "bash python" >> RDEPENDS_${PN}-perl =+ "bash perl perl-modules" >> +RDEPENDS_${PN}-tests =+ "python" > I now realise the trick you're playing with PACKAGECONFIG here. Instead > can we just define a package (say ${PN}-all but I'll accept a better > name) which has dependencies on archive perl python tests so then the > user can choose ${PN}, ${PN}-all or some other combination depending on > their needs? OK, I will put archive perl python and tests in ${PN}-full. > >> RSUGGESTS_SCRIPTING = "${@perf_feature_enabled('perf-scripting', '${PN}-perl ${PN}-python', '',d)}" >> RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests ${RSUGGESTS_SCRIPTING}" >> >> -FILES_${PN} += "${libexecdir}/perf-core ${exec_prefix}/libexec/perf-core ${libdir}/traceevent" >> +FILES_${PN} += "${libdir}/traceevent" >> FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug" >> -FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive" >> -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests" >> -FILES_${PN}-python = "${libdir}/python*/site-packages ${libdir}/perf/perf-core/scripts/python" >> -FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl" >> +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive" >> +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests" >> +FILES_${PN}-python = "${exec_prefix}/libexec/perf-core/scripts/python" >> +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl" > Can we use ${libexecdir} here please rather than hardcode it? I checked environment, the variable libexecdir is "/usr/lib/perf". If I use this variable, package can't be split successfully. Best Regards Chong > > Cheers, > > Richard > > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V2 1/1] perf: fix issue about package splitting 2014-09-04 7:27 ` Chong Lu @ 2014-09-04 8:06 ` Chong Lu 2014-09-04 8:10 ` Richard Purdie 2014-09-04 8:07 ` Richard Purdie 1 sibling, 1 reply; 9+ messages in thread From: Chong Lu @ 2014-09-04 8:06 UTC (permalink / raw) To: Richard Purdie; +Cc: openembedded-core On 09/04/2014 03:27 PM, Chong Lu wrote: > > On 09/03/2014 06:42 PM, Richard Purdie wrote: >> On Wed, 2014-09-03 at 17:05 +0800, Chong Lu wrote: >>> Currently, perf can't split to perf-archive, perf-tests, perf-python >>> and >>> perf-perl. All files are included in perf package. Change the files >>> paths to >>> make split successfully and add PACKAGECONFIG to make main pkg >>> depends on sub >>> pkgs as default. >>> >>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com> >>> --- >>> meta/recipes-kernel/perf/perf.bb | 17 ++++++++++++----- >>> 1 file changed, 12 insertions(+), 5 deletions(-) >>> >>> diff --git a/meta/recipes-kernel/perf/perf.bb >>> b/meta/recipes-kernel/perf/perf.bb >>> index bfd210c..baf0077 100644 >>> --- a/meta/recipes-kernel/perf/perf.bb >>> +++ b/meta/recipes-kernel/perf/perf.bb >>> @@ -149,20 +149,27 @@ PACKAGE_ARCH = "${MACHINE_ARCH}" >>> PACKAGES =+ "${PN}-archive ${PN}-tests ${PN}-perl ${PN}-python" >>> +PACKAGECONFIG ??= "archive perl python tests" >>> +PACKAGECONFIG[archive] = ",,, ${PN}-archive" >>> +PACKAGECONFIG[perl] = ",,, ${PN}-perl" >>> +PACKAGECONFIG[python] = ",,, ${PN}-python" >>> +PACKAGECONFIG[tests] = ",,, ${PN}-tests" >>> + >>> RDEPENDS_${PN} += "elfutils" >>> RDEPENDS_${PN}-archive =+ "bash" >>> RDEPENDS_${PN}-python =+ "bash python" >>> RDEPENDS_${PN}-perl =+ "bash perl perl-modules" >>> +RDEPENDS_${PN}-tests =+ "python" >> I now realise the trick you're playing with PACKAGECONFIG here. Instead >> can we just define a package (say ${PN}-all but I'll accept a better >> name) which has dependencies on archive perl python tests so then the >> user can choose ${PN}, ${PN}-all or some other combination depending on >> their needs? > > OK, I will put archive perl python and tests in ${PN}-full. Sorry, I don't think we should use a pkg include four sub pkgs. We have perf_feature_enabled to control whether enable perl and python, so it is hard to use feature if we put four sub pkgs in one pkg. Best Regards Chong > >>> RSUGGESTS_SCRIPTING = "${@perf_feature_enabled('perf-scripting', >>> '${PN}-perl ${PN}-python', '',d)}" >>> RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests ${RSUGGESTS_SCRIPTING}" >>> -FILES_${PN} += "${libexecdir}/perf-core >>> ${exec_prefix}/libexec/perf-core ${libdir}/traceevent" >>> +FILES_${PN} += "${libdir}/traceevent" >>> FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug" >>> -FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive" >>> -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests" >>> -FILES_${PN}-python = "${libdir}/python*/site-packages >>> ${libdir}/perf/perf-core/scripts/python" >>> -FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl" >>> +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive" >>> +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests" >>> +FILES_${PN}-python = "${exec_prefix}/libexec/perf-core/scripts/python" >>> +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl" >> Can we use ${libexecdir} here please rather than hardcode it? > > I checked environment, the variable libexecdir is "/usr/lib/perf". If > I use this variable, package can't be split successfully. > > Best Regards > Chong > >> >> Cheers, >> >> Richard >> >> >> >> > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V2 1/1] perf: fix issue about package splitting 2014-09-04 8:06 ` Chong Lu @ 2014-09-04 8:10 ` Richard Purdie 2014-09-04 8:17 ` Chong Lu 0 siblings, 1 reply; 9+ messages in thread From: Richard Purdie @ 2014-09-04 8:10 UTC (permalink / raw) To: Chong Lu; +Cc: openembedded-core On Thu, 2014-09-04 at 16:06 +0800, Chong Lu wrote: > On 09/04/2014 03:27 PM, Chong Lu wrote: > > > > On 09/03/2014 06:42 PM, Richard Purdie wrote: > >> On Wed, 2014-09-03 at 17:05 +0800, Chong Lu wrote: > >>> Currently, perf can't split to perf-archive, perf-tests, perf-python > >>> and > >>> perf-perl. All files are included in perf package. Change the files > >>> paths to > >>> make split successfully and add PACKAGECONFIG to make main pkg > >>> depends on sub > >>> pkgs as default. > >>> > >>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com> > >>> --- > >>> meta/recipes-kernel/perf/perf.bb | 17 ++++++++++++----- > >>> 1 file changed, 12 insertions(+), 5 deletions(-) > >>> > >>> diff --git a/meta/recipes-kernel/perf/perf.bb > >>> b/meta/recipes-kernel/perf/perf.bb > >>> index bfd210c..baf0077 100644 > >>> --- a/meta/recipes-kernel/perf/perf.bb > >>> +++ b/meta/recipes-kernel/perf/perf.bb > >>> @@ -149,20 +149,27 @@ PACKAGE_ARCH = "${MACHINE_ARCH}" > >>> PACKAGES =+ "${PN}-archive ${PN}-tests ${PN}-perl ${PN}-python" > >>> +PACKAGECONFIG ??= "archive perl python tests" > >>> +PACKAGECONFIG[archive] = ",,, ${PN}-archive" > >>> +PACKAGECONFIG[perl] = ",,, ${PN}-perl" > >>> +PACKAGECONFIG[python] = ",,, ${PN}-python" > >>> +PACKAGECONFIG[tests] = ",,, ${PN}-tests" > >>> + > >>> RDEPENDS_${PN} += "elfutils" > >>> RDEPENDS_${PN}-archive =+ "bash" > >>> RDEPENDS_${PN}-python =+ "bash python" > >>> RDEPENDS_${PN}-perl =+ "bash perl perl-modules" > >>> +RDEPENDS_${PN}-tests =+ "python" > >> I now realise the trick you're playing with PACKAGECONFIG here. Instead > >> can we just define a package (say ${PN}-all but I'll accept a better > >> name) which has dependencies on archive perl python tests so then the > >> user can choose ${PN}, ${PN}-all or some other combination depending on > >> their needs? > > > > OK, I will put archive perl python and tests in ${PN}-full. > > Sorry, I don't think we should use a pkg include four sub pkgs. > We have perf_feature_enabled to control whether enable perl and python, > so it is hard to use feature if we put four sub pkgs in one pkg. This isn't what I meant. I meant add a ${PN}-full package which RDEPENDS_${PN}-full = "${PN}-archive ${PN}-python ${PN}-perl ${PN}-tests" Cheers, Richard ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V2 1/1] perf: fix issue about package splitting 2014-09-04 8:10 ` Richard Purdie @ 2014-09-04 8:17 ` Chong Lu 2014-09-04 8:24 ` Richard Purdie 0 siblings, 1 reply; 9+ messages in thread From: Chong Lu @ 2014-09-04 8:17 UTC (permalink / raw) To: Richard Purdie; +Cc: openembedded-core On 09/04/2014 04:10 PM, Richard Purdie wrote: > On Thu, 2014-09-04 at 16:06 +0800, Chong Lu wrote: >> On 09/04/2014 03:27 PM, Chong Lu wrote: >>> On 09/03/2014 06:42 PM, Richard Purdie wrote: >>>> On Wed, 2014-09-03 at 17:05 +0800, Chong Lu wrote: >>>>> Currently, perf can't split to perf-archive, perf-tests, perf-python >>>>> and >>>>> perf-perl. All files are included in perf package. Change the files >>>>> paths to >>>>> make split successfully and add PACKAGECONFIG to make main pkg >>>>> depends on sub >>>>> pkgs as default. >>>>> >>>>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com> >>>>> --- >>>>> meta/recipes-kernel/perf/perf.bb | 17 ++++++++++++----- >>>>> 1 file changed, 12 insertions(+), 5 deletions(-) >>>>> >>>>> diff --git a/meta/recipes-kernel/perf/perf.bb >>>>> b/meta/recipes-kernel/perf/perf.bb >>>>> index bfd210c..baf0077 100644 >>>>> --- a/meta/recipes-kernel/perf/perf.bb >>>>> +++ b/meta/recipes-kernel/perf/perf.bb >>>>> @@ -149,20 +149,27 @@ PACKAGE_ARCH = "${MACHINE_ARCH}" >>>>> PACKAGES =+ "${PN}-archive ${PN}-tests ${PN}-perl ${PN}-python" >>>>> +PACKAGECONFIG ??= "archive perl python tests" >>>>> +PACKAGECONFIG[archive] = ",,, ${PN}-archive" >>>>> +PACKAGECONFIG[perl] = ",,, ${PN}-perl" >>>>> +PACKAGECONFIG[python] = ",,, ${PN}-python" >>>>> +PACKAGECONFIG[tests] = ",,, ${PN}-tests" >>>>> + >>>>> RDEPENDS_${PN} += "elfutils" >>>>> RDEPENDS_${PN}-archive =+ "bash" >>>>> RDEPENDS_${PN}-python =+ "bash python" >>>>> RDEPENDS_${PN}-perl =+ "bash perl perl-modules" >>>>> +RDEPENDS_${PN}-tests =+ "python" >>>> I now realise the trick you're playing with PACKAGECONFIG here. Instead >>>> can we just define a package (say ${PN}-all but I'll accept a better >>>> name) which has dependencies on archive perl python tests so then the >>>> user can choose ${PN}, ${PN}-all or some other combination depending on >>>> their needs? >>> OK, I will put archive perl python and tests in ${PN}-full. >> Sorry, I don't think we should use a pkg include four sub pkgs. >> We have perf_feature_enabled to control whether enable perl and python, >> so it is hard to use feature if we put four sub pkgs in one pkg. > This isn't what I meant. I meant add a ${PN}-full package which > RDEPENDS_${PN}-full = "${PN}-archive ${PN}-python ${PN}-perl > ${PN}-tests" Do you mean I should use: PACKAGECONFIG ??= "full" PACKAGECONFIG[full] = ",,, ${PN}-full" RDEPENDS_${PN}-full = "${PN}-archive ${PN}-python ${PN}-perl ${PN}-tests" Best Regards Chong > Cheers, > > Richard > > > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V2 1/1] perf: fix issue about package splitting 2014-09-04 8:17 ` Chong Lu @ 2014-09-04 8:24 ` Richard Purdie 0 siblings, 0 replies; 9+ messages in thread From: Richard Purdie @ 2014-09-04 8:24 UTC (permalink / raw) To: Chong Lu; +Cc: openembedded-core On Thu, 2014-09-04 at 16:17 +0800, Chong Lu wrote: > On 09/04/2014 04:10 PM, Richard Purdie wrote: > > On Thu, 2014-09-04 at 16:06 +0800, Chong Lu wrote: > >> On 09/04/2014 03:27 PM, Chong Lu wrote: > >>> On 09/03/2014 06:42 PM, Richard Purdie wrote: > >>>> On Wed, 2014-09-03 at 17:05 +0800, Chong Lu wrote: > >>>>> Currently, perf can't split to perf-archive, perf-tests, perf-python > >>>>> and > >>>>> perf-perl. All files are included in perf package. Change the files > >>>>> paths to > >>>>> make split successfully and add PACKAGECONFIG to make main pkg > >>>>> depends on sub > >>>>> pkgs as default. > >>>>> > >>>>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com> > >>>>> --- > >>>>> meta/recipes-kernel/perf/perf.bb | 17 ++++++++++++----- > >>>>> 1 file changed, 12 insertions(+), 5 deletions(-) > >>>>> > >>>>> diff --git a/meta/recipes-kernel/perf/perf.bb > >>>>> b/meta/recipes-kernel/perf/perf.bb > >>>>> index bfd210c..baf0077 100644 > >>>>> --- a/meta/recipes-kernel/perf/perf.bb > >>>>> +++ b/meta/recipes-kernel/perf/perf.bb > >>>>> @@ -149,20 +149,27 @@ PACKAGE_ARCH = "${MACHINE_ARCH}" > >>>>> PACKAGES =+ "${PN}-archive ${PN}-tests ${PN}-perl ${PN}-python" > >>>>> +PACKAGECONFIG ??= "archive perl python tests" > >>>>> +PACKAGECONFIG[archive] = ",,, ${PN}-archive" > >>>>> +PACKAGECONFIG[perl] = ",,, ${PN}-perl" > >>>>> +PACKAGECONFIG[python] = ",,, ${PN}-python" > >>>>> +PACKAGECONFIG[tests] = ",,, ${PN}-tests" > >>>>> + > >>>>> RDEPENDS_${PN} += "elfutils" > >>>>> RDEPENDS_${PN}-archive =+ "bash" > >>>>> RDEPENDS_${PN}-python =+ "bash python" > >>>>> RDEPENDS_${PN}-perl =+ "bash perl perl-modules" > >>>>> +RDEPENDS_${PN}-tests =+ "python" > >>>> I now realise the trick you're playing with PACKAGECONFIG here. Instead > >>>> can we just define a package (say ${PN}-all but I'll accept a better > >>>> name) which has dependencies on archive perl python tests so then the > >>>> user can choose ${PN}, ${PN}-all or some other combination depending on > >>>> their needs? > >>> OK, I will put archive perl python and tests in ${PN}-full. > >> Sorry, I don't think we should use a pkg include four sub pkgs. > >> We have perf_feature_enabled to control whether enable perl and python, > >> so it is hard to use feature if we put four sub pkgs in one pkg. > > This isn't what I meant. I meant add a ${PN}-full package which > > RDEPENDS_${PN}-full = "${PN}-archive ${PN}-python ${PN}-perl > > ${PN}-tests" > > Do you mean I should use: > > PACKAGECONFIG ??= "full" > PACKAGECONFIG[full] = ",,, ${PN}-full" > RDEPENDS_${PN}-full = "${PN}-archive ${PN}-python ${PN}-perl ${PN}-tests" No, I do not believe we need a PACKAGECONFIG for this. Just install the particular package which fits your needs. Cheers, Richard ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V2 1/1] perf: fix issue about package splitting 2014-09-04 7:27 ` Chong Lu 2014-09-04 8:06 ` Chong Lu @ 2014-09-04 8:07 ` Richard Purdie 1 sibling, 0 replies; 9+ messages in thread From: Richard Purdie @ 2014-09-04 8:07 UTC (permalink / raw) To: Chong Lu; +Cc: openembedded-core On Thu, 2014-09-04 at 15:27 +0800, Chong Lu wrote: > On 09/03/2014 06:42 PM, Richard Purdie wrote: > > On Wed, 2014-09-03 at 17:05 +0800, Chong Lu wrote: > >> Currently, perf can't split to perf-archive, perf-tests, perf-python and > >> perf-perl. All files are included in perf package. Change the files paths to > >> make split successfully and add PACKAGECONFIG to make main pkg depends on sub > >> pkgs as default. > >> > >> Signed-off-by: Chong Lu <Chong.Lu@windriver.com> > >> --- > >> meta/recipes-kernel/perf/perf.bb | 17 ++++++++++++----- > >> 1 file changed, 12 insertions(+), 5 deletions(-) > >> > >> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb > >> index bfd210c..baf0077 100644 > >> --- a/meta/recipes-kernel/perf/perf.bb > >> +++ b/meta/recipes-kernel/perf/perf.bb > >> @@ -149,20 +149,27 @@ PACKAGE_ARCH = "${MACHINE_ARCH}" > >> > >> PACKAGES =+ "${PN}-archive ${PN}-tests ${PN}-perl ${PN}-python" > >> > >> +PACKAGECONFIG ??= "archive perl python tests" > >> +PACKAGECONFIG[archive] = ",,, ${PN}-archive" > >> +PACKAGECONFIG[perl] = ",,, ${PN}-perl" > >> +PACKAGECONFIG[python] = ",,, ${PN}-python" > >> +PACKAGECONFIG[tests] = ",,, ${PN}-tests" > >> + > >> RDEPENDS_${PN} += "elfutils" > >> RDEPENDS_${PN}-archive =+ "bash" > >> RDEPENDS_${PN}-python =+ "bash python" > >> RDEPENDS_${PN}-perl =+ "bash perl perl-modules" > >> +RDEPENDS_${PN}-tests =+ "python" > > I now realise the trick you're playing with PACKAGECONFIG here. Instead > > can we just define a package (say ${PN}-all but I'll accept a better > > name) which has dependencies on archive perl python tests so then the > > user can choose ${PN}, ${PN}-all or some other combination depending on > > their needs? > > OK, I will put archive perl python and tests in ${PN}-full. > > > > >> RSUGGESTS_SCRIPTING = "${@perf_feature_enabled('perf-scripting', '${PN}-perl ${PN}-python', '',d)}" > >> RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests ${RSUGGESTS_SCRIPTING}" > >> > >> -FILES_${PN} += "${libexecdir}/perf-core ${exec_prefix}/libexec/perf-core ${libdir}/traceevent" > >> +FILES_${PN} += "${libdir}/traceevent" > >> FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug" > >> -FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive" > >> -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests" > >> -FILES_${PN}-python = "${libdir}/python*/site-packages ${libdir}/perf/perf-core/scripts/python" > >> -FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl" > >> +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive" > >> +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests" > >> +FILES_${PN}-python = "${exec_prefix}/libexec/perf-core/scripts/python" > >> +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl" > > Can we use ${libexecdir} here please rather than hardcode it? > > I checked environment, the variable libexecdir is "/usr/lib/perf". If I > use this variable, package can't be split successfully. Perf should be putting the files into ${libexecdir}. We therefore probably need to set perfexecdir correctly, then use ${libexecdir} in FILES above. Cheers, Richard ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-09-04 8:24 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-09-03 9:05 [PATCH V2 0/1] perf: fix issue about package splitting Chong Lu 2014-09-03 9:05 ` [PATCH V2 1/1] " Chong Lu 2014-09-03 10:42 ` Richard Purdie 2014-09-04 7:27 ` Chong Lu 2014-09-04 8:06 ` Chong Lu 2014-09-04 8:10 ` Richard Purdie 2014-09-04 8:17 ` Chong Lu 2014-09-04 8:24 ` Richard Purdie 2014-09-04 8:07 ` Richard Purdie
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox