[PATCH] kernel.bbclass: handle .dsp firmware

[PATCH] kernel.bbclass: handle .dsp firmware

[Carlos Rafael Giani]

A few firmware files use this filename extension, like korg/k1212.dsp .
Create respective packages.

Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
---
 meta/classes/kernel.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index b02036f..4710719 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -387,6 +387,7 @@ python split_kernel_packages () {
     do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.bin$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
     do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.fw$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
     do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.cis$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
+    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.dsp$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
 }
 
 do_strip() {
-- 
1.9.1

Re: [PATCH] kernel.bbclass: handle .dsp firmware

[Richard Purdie]

On Mon, 2014-09-08 at 13:04 +0200, Carlos Rafael Giani wrote:
> A few firmware files use this filename extension, like korg/k1212.dsp .
> Create respective packages.
> 
> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
> ---
>  meta/classes/kernel.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index b02036f..4710719 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -387,6 +387,7 @@ python split_kernel_packages () {
>      do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.bin$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>      do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.fw$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>      do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.cis$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
> +    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.dsp$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>  }

Perhaps its time to improve the regex slightly here and use something
like file_regex='^(.*)\.(bin|fw|cis|dsp)$ rather than multiple calls to
do_split_packages?

Cheers,

Richard

Re: [PATCH] kernel.bbclass: handle .dsp firmware

[Carlos Rafael Giani]

On 09/08/14 13:18, Richard Purdie wrote:
> On Mon, 2014-09-08 at 13:04 +0200, Carlos Rafael Giani wrote:
>> A few firmware files use this filename extension, like korg/k1212.dsp .
>> Create respective packages.
>>
>> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
>> ---
>>   meta/classes/kernel.bbclass | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index b02036f..4710719 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -387,6 +387,7 @@ python split_kernel_packages () {
>>       do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.bin$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>>       do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.fw$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>>       do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.cis$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>> +    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.dsp$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>>   }
> Perhaps its time to improve the regex slightly here and use something
> like file_regex='^(.*)\.(bin|fw|cis|dsp)$ rather than multiple calls to
> do_split_packages?
>
> Cheers,
>
> Richard
>
>
>

I had the same thought. However, I figured that perhaps it would be 
better to do this in a followup patch, to keep the two distinct changes 
separate (add .dsp support + modify regex to the new and improved version).

Re: [PATCH] kernel.bbclass: handle .dsp firmware

[Otavio Salvador]

On Mon, Sep 8, 2014 at 9:08 AM, Carlos Rafael Giani
<dv@pseudoterminal.org> wrote:
> On 09/08/14 13:18, Richard Purdie wrote:
>>
>> On Mon, 2014-09-08 at 13:04 +0200, Carlos Rafael Giani wrote:
>>>
>>> A few firmware files use this filename extension, like korg/k1212.dsp .
>>> Create respective packages.
>>>
>>> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
...
>> Perhaps its time to improve the regex slightly here and use something
>> like file_regex='^(.*)\.(bin|fw|cis|dsp)$ rather than multiple calls to
>> do_split_packages?
>
> I had the same thought. However, I figured that perhaps it would be better
> to do this in a followup patch, to keep the two distinct changes separate
> (add .dsp support + modify regex to the new and improved version).

Agreed.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750